From: "'Florian Bezdeka' via isar-users" <isar-users@googlegroups.com>
To: Isaac True <itrue@emlix.com>, isar-users@googlegroups.com
Subject: Re: [PATCH 0/3] linux-custom: add linux-tools package and perf
Date: Wed, 26 Nov 2025 10:46:35 +0100 [thread overview]
Message-ID: <8ac5e55dc35010e8a5b2cc4dd22288310843a1b7.camel@siemens.com> (raw)
In-Reply-To: <20251126090202.3091051-5-itrue@emlix.com>
Hi Isaac,
On Wed, 2025-11-26 at 09:59 +0100, 'Isaac True' via isar-users wrote:
> Modify the linux-custom recipe to additionally generate a linux-tools
> package, build the perf binary, and add this binary to the new package.
> This is useful for profiling application and kernel performance on
> targets.
>
> Isaac True (3):
> linux-custom: add linux-tools package
> linux-custom: build perf and add it to linux-tools
> doc: custom_kernel: add perf and linux-tools
Patch ordering:
Patch 1 already adds the new package to PROVIDES while building the
package comes later with patch 2. That looks inconsistent.
I would vote for merging patch 1 and 2.
How long does it take to build that additional package? That additional
(and maybe unneeded) packet is being build unconditionally, right? As
kernel builds are normally compute intense that might matter for some
users.
Should we better hide that new "feature" / packet behind a feature flag
/ recipe variable?
Best regards,
Florian
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/8ac5e55dc35010e8a5b2cc4dd22288310843a1b7.camel%40siemens.com.
next prev parent reply other threads:[~2025-11-26 9:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 8:59 'Isaac True' via isar-users
2025-11-26 8:59 ` [PATCH 1/3] linux-custom: add linux-tools package 'Isaac True' via isar-users
2025-11-26 8:59 ` [PATCH 2/3] linux-custom: build perf and add it to linux-tools 'Isaac True' via isar-users
2025-11-26 9:09 ` 'Isaac True' via isar-users
2025-11-26 8:59 ` [PATCH 3/3] doc: custom_kernel: add perf and linux-tools 'Isaac True' via isar-users
2025-11-26 9:46 ` 'Florian Bezdeka' via isar-users [this message]
2025-11-26 9:59 ` [PATCH 0/3] linux-custom: add linux-tools package and perf 'Isaac True' via isar-users
2025-11-26 10:30 ` 'Florian Bezdeka' via isar-users
2025-11-27 7:17 ` 'Jan Kiszka' via isar-users
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ac5e55dc35010e8a5b2cc4dd22288310843a1b7.camel@siemens.com \
--to=isar-users@googlegroups.com \
--cc=florian.bezdeka@siemens.com \
--cc=itrue@emlix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox