From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6523072403514327040 X-Received: by 10.80.215.210 with SMTP id m18mr4056274edj.0.1519034964058; Mon, 19 Feb 2018 02:09:24 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.80.202.5 with SMTP id d5ls3898516edi.8.gmail; Mon, 19 Feb 2018 02:09:23 -0800 (PST) X-Google-Smtp-Source: AH8x226EojWEFNLei0VHEz7NuQDx/i2OckmuvEhy6uTyXa1U+JDkBbyASQqH9/H+1KdfAZo7PEHr X-Received: by 10.80.189.195 with SMTP id z3mr4063244edh.8.1519034963477; Mon, 19 Feb 2018 02:09:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519034963; cv=none; d=google.com; s=arc-20160816; b=lYdAN7iUYZaxtqZrJyk4LZ+SJUtEO1p6jp1OXI1oOHRFKajGF0FazL0dF3d9j82RLC agims/v3EyVHpl9GYSEo3x93Mabaj3MLOty8hLdaBZhC8HQ0cwqjdPldby1Zw1qAUajt 9oXACzHjqQrQKb+baik8TG4IxvBl4l67Up84UjjTek11R8k1tRAw1FYa7mCgAmRIZD+y phtJDzXbpJxMIGqDMCSJSp25HKuTz5zQ9kKBgbcpxXbNx+r5ndIehLvXybOt0ztqkIP/ dwxTM0pY3I7/UkfBsTwI65JaG1YBY43lenA7f+0fD5wRsWGNjjRe091KSc21JAsy1fFN Na4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=I2afn/Vx2GTsDwxKsqSDK6zJaOun+Y19oYlT1Dcc8TE=; b=akduUBvYtEqZ+o8dGthdHY9eSq1fwDLxDV1gFa3dqVM129yOXa2+Vv9pjZUyfYuAbg VE/t17yNZdtIW4JugzR4BCTuGfzWpaeBPD0C6BsmCz185zNJbXFiyTbauPzCiStwVSL2 6U/ubKlG++lJ1WE/4thE9FsdFu4cN4uakR+tBHQJAuybQg1q+yWgo59xM1hGYEU3DDQh 5wfW+v7Zlgo43gAXOQcAbyUu836X6fnguMpw3OFtzqayY2IHiM4T1GDZv/OxqRakHifP oTSzzoHbYuUh0Ex3n3F4yhf9kVnZZnsNYW4WBAIdSP3tvlhVodFaqPmKMMUOXy0ekCnH i8SA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id m12si711587edi.1.2018.02.19.02.09.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Feb 2018 02:09:23 -0800 (PST) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w1JA9Mca020624 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 19 Feb 2018 11:09:23 +0100 Received: from [139.25.68.223] (linux-ses-ext02.ppmd.siemens.net [139.25.68.223]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id w1JA9MfO002195; Mon, 19 Feb 2018 11:09:22 +0100 Subject: Consolidate mounting in tasks (was Re: [PATCH 1/8] Mount devtmpfs read-only into chroot) To: "[ext] Jan Kiszka" , isar-users References: <02a592150c34714e0729d4fc73f86ff031fee514.1518771143.git.jan.kiszka@siemens.com> From: Claudius Heine Message-ID: <8ada75f0-3116-d3ab-d3be-4c45d21018d0@siemens.com> Date: Mon, 19 Feb 2018 11:09:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <02a592150c34714e0729d4fc73f86ff031fee514.1518771143.git.jan.kiszka@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: +bpOoSAxpaiv Hi, On 02/16/2018 09:52 AM, [ext] Jan Kiszka wrote: > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass > index 5eef11b..78709f9 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -41,7 +41,7 @@ do_build() { > if ! grep -q ${BUILDCHROOT_DIR}/isar-apt /proc/mounts; then \ > mount --bind ${DEPLOY_DIR_APT}/${DISTRO} ${BUILDCHROOT_DIR}/isar-apt; \ > mount --bind ${DL_DIR} ${BUILDCHROOT_DIR}/downloads; \ > - mount -t devtmpfs -o mode=0755,nosuid devtmpfs ${BUILDCHROOT_DIR}/dev; \ > + mount --bind -o ro /dev ${BUILDCHROOT_DIR}/dev; \ > mount -t proc none ${BUILDCHROOT_DIR}/proc; \ > fi' > > diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb b/meta/recipes-devtools/buildchroot/buildchroot.bb > index 520daf9..1eca035 100644 > --- a/meta/recipes-devtools/buildchroot/buildchroot.bb > +++ b/meta/recipes-devtools/buildchroot/buildchroot.bb > @@ -66,7 +66,7 @@ do_build() { > "${WORKDIR}/multistrap.conf.in" > "${WORKDIR}/multistrap.conf" > > sudo mount --bind ${DEPLOY_DIR_APT}/${DISTRO} ${BUILDCHROOT_DIR}/isar-apt > - sudo mount -t devtmpfs -o mode=0755,nosuid devtmpfs ${BUILDCHROOT_DIR}/dev > + sudo mount --bind -o ro /dev ${BUILDCHROOT_DIR}/dev > sudo mount -t proc none ${BUILDCHROOT_DIR}/proc > > # Create root filesystem > Would it make sense to try to consolidate the default mounts into a bbclass? Maybe implement it via a task flag that hooks into TaskStarted, TaskFailed and TaskSucceeded events and handles mounting/unmounting there. If I read the bitbake documentation correctly, those events are triggered within the worker context, so they should be synchronous to the task code. Cheers, Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de