public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH 1/4] sbuild-chroot: Only install ccache is used
Date: Fri, 20 Jan 2023 09:28:15 +0100	[thread overview]
Message-ID: <8b0dda3c-78e7-489f-6a5a-12582a736fe2@siemens.com> (raw)
In-Reply-To: <7e1e814edc932a78be9e292c7c5f096f402ed71c.1673242355.git.jan.kiszka@siemens.com>

On 09.01.23 06:32, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Aligns sbuild-chroot with the behavior of buildchroot.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc
> index 4688da1d..fa4a295c 100644
> --- a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc
> +++ b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc
> @@ -14,7 +14,7 @@ SBUILD_CHROOT_PREINSTALL_COMMON = " \
>      fakeroot \
>      build-essential \
>      debhelper \
> -    ccache \
> +    ${@ 'ccache' if d.getVar('USE_CCACHE') == '1' else ''} \
>      devscripts \
>      equivs \
>  "

Subject should read "...if used".

Can v2 if there are other changes requested on this series. If not,
please fix up on merge.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux


  reply	other threads:[~2023-01-20  8:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09  5:32 [PATCH 0/4] sbuild-chroot optimizations Jan Kiszka
2023-01-09  5:32 ` [PATCH 1/4] sbuild-chroot: Only install ccache is used Jan Kiszka
2023-01-20  8:28   ` Jan Kiszka [this message]
2023-01-09  5:32 ` [PATCH 2/4] crossbuild-essential-riscv64: Drop unneeded crossbuild disabling Jan Kiszka
2023-01-09  5:32 ` [PATCH 3/4] sbuild-chroot: Pre-install cross-compiler and libc6-dev Jan Kiszka
2023-01-09  5:56   ` Moessbauer, Felix
2023-01-09  7:45     ` Jan Kiszka
2023-01-09  5:32 ` [PATCH 4/4] sbuild-chroot: Pre-install also libcpp-*-dev and libstdc++-*-dev Jan Kiszka
2023-01-24  7:33 ` [PATCH 0/4] sbuild-chroot optimizations Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b0dda3c-78e7-489f-6a5a-12582a736fe2@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox