* [PATCH] meta/classes/template: add BPN to default TEMPLATE_VARS
@ 2024-05-06 7:17 srinuvasan.a
2024-05-07 5:24 ` Srinuvasan Arjunan
2024-05-10 5:46 ` Uladzimir Bely
0 siblings, 2 replies; 6+ messages in thread
From: srinuvasan.a @ 2024-05-06 7:17 UTC (permalink / raw)
To: isar-users; +Cc: jan.kiszka, Srinuvasan A
From: Srinuvasan A <srinuvasan.a@siemens.com>
Add the base recipe name (BPN) to default template variables, this would be
helpful to replace the base recipe name in template file if the recipe
configured BPN across the builds.
Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
---
meta/classes/template.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/template.bbclass b/meta/classes/template.bbclass
index 7f8d5d8f..37e43196 100644
--- a/meta/classes/template.bbclass
+++ b/meta/classes/template.bbclass
@@ -4,7 +4,7 @@
# SPDX-License-Identifier: MIT
TEMPLATE_FILES ?= ""
-TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER DISTRO_ARCH"
+TEMPLATE_VARS ?= "BPN PN PV DESCRIPTION HOMEPAGE MAINTAINER DISTRO_ARCH"
do_transform_template[vardeps] = "TEMPLATE_FILES ${TEMPLATE_VARS}"
python do_transform_template() {
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] meta/classes/template: add BPN to default TEMPLATE_VARS
2024-05-06 7:17 [PATCH] meta/classes/template: add BPN to default TEMPLATE_VARS srinuvasan.a
@ 2024-05-07 5:24 ` Srinuvasan Arjunan
2024-05-07 9:24 ` Uladzimir Bely
2024-05-07 9:29 ` Jan Kiszka
2024-05-10 5:46 ` Uladzimir Bely
1 sibling, 2 replies; 6+ messages in thread
From: Srinuvasan Arjunan @ 2024-05-07 5:24 UTC (permalink / raw)
To: isar-users
[-- Attachment #1.1: Type: text/plain, Size: 1075 bytes --]
On Monday, May 6, 2024 at 12:46:47 PM UTC+5:30 srinuv...@siemens.com wrote:
From: Srinuvasan A <srinuv...@siemens.com>
Add the base recipe name (BPN) to default template variables, this would be
helpful to replace the base recipe name in template file if the recipe
configured BPN across the builds.
Signed-off-by: Srinuvasan A <srinuv...@siemens.com>
---
meta/classes/template.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/template.bbclass b/meta/classes/template.bbclass
index 7f8d5d8f..37e43196 100644
--- a/meta/classes/template.bbclass
+++ b/meta/classes/template.bbclass
@@ -4,7 +4,7 @@
# SPDX-License-Identifier: MIT
TEMPLATE_FILES ?= ""
-TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER DISTRO_ARCH"
+TEMPLATE_VARS ?= "BPN PN PV DESCRIPTION HOMEPAGE MAINTAINER DISTRO_ARCH"
do_transform_template[vardeps] = "TEMPLATE_FILES ${TEMPLATE_VARS}"
python do_transform_template() {
--
2.34.1
Hi All,
Any feedback on this changes?
Many thanks,
Srinu
[-- Attachment #1.2: Type: text/html, Size: 1532 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] meta/classes/template: add BPN to default TEMPLATE_VARS
2024-05-07 5:24 ` Srinuvasan Arjunan
@ 2024-05-07 9:24 ` Uladzimir Bely
2024-05-07 9:29 ` Jan Kiszka
1 sibling, 0 replies; 6+ messages in thread
From: Uladzimir Bely @ 2024-05-07 9:24 UTC (permalink / raw)
To: Srinuvasan Arjunan, isar-users
On Mon, 2024-05-06 at 22:24 -0700, Srinuvasan Arjunan wrote:
>
>
> On Monday, May 6, 2024 at 12:46:47 PM UTC+5:30 srinuv...@siemens.com
> wrote:
> > From: Srinuvasan A <srinuv...@siemens.com>
> >
> > Add the base recipe name (BPN) to default template variables, this
> > would be
> > helpful to replace the base recipe name in template file if the
> > recipe
> > configured BPN across the builds.
> >
> > Signed-off-by: Srinuvasan A <srinuv...@siemens.com>
> > ---
> > meta/classes/template.bbclass | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/template.bbclass
> > b/meta/classes/template.bbclass
> > index 7f8d5d8f..37e43196 100644
> > --- a/meta/classes/template.bbclass
> > +++ b/meta/classes/template.bbclass
> > @@ -4,7 +4,7 @@
> > # SPDX-License-Identifier: MIT
> >
> > TEMPLATE_FILES ?= ""
> > -TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER
> > DISTRO_ARCH"
> > +TEMPLATE_VARS ?= "BPN PN PV DESCRIPTION HOMEPAGE MAINTAINER
> > DISTRO_ARCH"
> >
> > do_transform_template[vardeps] = "TEMPLATE_FILES ${TEMPLATE_VARS}"
> > python do_transform_template() {
> > --
> > 2.34.1
>
>
> Hi All,
>
> Any feedback on this changes?
>
> Many thanks,
> Srinu
Hello.
The patch is being tested under CI, with other patches.
If there are no any issues and/or discussions on mail list, it will be
applied as usually.
--
Best regards,
Uladzimir.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] meta/classes/template: add BPN to default TEMPLATE_VARS
2024-05-07 5:24 ` Srinuvasan Arjunan
2024-05-07 9:24 ` Uladzimir Bely
@ 2024-05-07 9:29 ` Jan Kiszka
2024-05-07 14:24 ` Srinuvasan Arjunan
1 sibling, 1 reply; 6+ messages in thread
From: Jan Kiszka @ 2024-05-07 9:29 UTC (permalink / raw)
To: Srinuvasan Arjunan, isar-users
On 07.05.24 07:24, Srinuvasan Arjunan wrote:
>
>
> On Monday, May 6, 2024 at 12:46:47 PM UTC+5:30 srinuv...@siemens.com wrote:
>
> From: Srinuvasan A <srinuv...@siemens.com>
>
> Add the base recipe name (BPN) to default template variables, this
> would be
> helpful to replace the base recipe name in template file if the recipe
> configured BPN across the builds.
>
> Signed-off-by: Srinuvasan A <srinuv...@siemens.com>
> ---
> meta/classes/template.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/template.bbclass
> b/meta/classes/template.bbclass
> index 7f8d5d8f..37e43196 100644
> --- a/meta/classes/template.bbclass
> +++ b/meta/classes/template.bbclass
> @@ -4,7 +4,7 @@
> # SPDX-License-Identifier: MIT
>
> TEMPLATE_FILES ?= ""
> -TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER DISTRO_ARCH"
> +TEMPLATE_VARS ?= "BPN PN PV DESCRIPTION HOMEPAGE MAINTAINER
> DISTRO_ARCH"
>
> do_transform_template[vardeps] = "TEMPLATE_FILES ${TEMPLATE_VARS}"
> python do_transform_template() {
> --
> 2.34.1
>
>
> Hi All,
>
> Any feedback on this changes?
>
Please be more patient, specifically with feature extensions, even if
they are small and kind of obvious as this one.
Thanks,
Jan
--
Siemens AG, Technology
Linux Expert Center
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] meta/classes/template: add BPN to default TEMPLATE_VARS
2024-05-07 9:29 ` Jan Kiszka
@ 2024-05-07 14:24 ` Srinuvasan Arjunan
0 siblings, 0 replies; 6+ messages in thread
From: Srinuvasan Arjunan @ 2024-05-07 14:24 UTC (permalink / raw)
To: isar-users
[-- Attachment #1.1: Type: text/plain, Size: 1536 bytes --]
On Tuesday, May 7, 2024 at 3:00:00 PM UTC+5:30 Jan Kiszka wrote:
On 07.05.24 07:24, Srinuvasan Arjunan wrote:
>
>
> On Monday, May 6, 2024 at 12:46:47 PM UTC+5:30 srinuv...@siemens.com
wrote:
>
> From: Srinuvasan A <srinuv...@siemens.com>
>
> Add the base recipe name (BPN) to default template variables, this
> would be
> helpful to replace the base recipe name in template file if the recipe
> configured BPN across the builds.
>
> Signed-off-by: Srinuvasan A <srinuv...@siemens.com>
> ---
> meta/classes/template.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/template.bbclass
> b/meta/classes/template.bbclass
> index 7f8d5d8f..37e43196 100644
> --- a/meta/classes/template.bbclass
> +++ b/meta/classes/template.bbclass
> @@ -4,7 +4,7 @@
> # SPDX-License-Identifier: MIT
>
> TEMPLATE_FILES ?= ""
> -TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER DISTRO_ARCH"
> +TEMPLATE_VARS ?= "BPN PN PV DESCRIPTION HOMEPAGE MAINTAINER
> DISTRO_ARCH"
>
> do_transform_template[vardeps] = "TEMPLATE_FILES ${TEMPLATE_VARS}"
> python do_transform_template() {
> --
> 2.34.1
>
>
> Hi All,
>
> Any feedback on this changes?
>
Please be more patient, specifically with feature extensions, even if
they are small and kind of obvious as this one.
Thanks,
Jan
Sure jan, thanks for the update.
Many thanks,
Srinu
--
Siemens AG, Technology
Linux Expert Center
[-- Attachment #1.2: Type: text/html, Size: 2484 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] meta/classes/template: add BPN to default TEMPLATE_VARS
2024-05-06 7:17 [PATCH] meta/classes/template: add BPN to default TEMPLATE_VARS srinuvasan.a
2024-05-07 5:24 ` Srinuvasan Arjunan
@ 2024-05-10 5:46 ` Uladzimir Bely
1 sibling, 0 replies; 6+ messages in thread
From: Uladzimir Bely @ 2024-05-10 5:46 UTC (permalink / raw)
To: srinuvasan.a, isar-users
On Mon, 2024-05-06 at 12:47 +0530, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
>
> Add the base recipe name (BPN) to default template variables, this
> would be
> helpful to replace the base recipe name in template file if the
> recipe
> configured BPN across the builds.
>
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
> meta/classes/template.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/template.bbclass
> b/meta/classes/template.bbclass
> index 7f8d5d8f..37e43196 100644
> --- a/meta/classes/template.bbclass
> +++ b/meta/classes/template.bbclass
> @@ -4,7 +4,7 @@
> # SPDX-License-Identifier: MIT
>
> TEMPLATE_FILES ?= ""
> -TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER DISTRO_ARCH"
> +TEMPLATE_VARS ?= "BPN PN PV DESCRIPTION HOMEPAGE MAINTAINER
> DISTRO_ARCH"
>
> do_transform_template[vardeps] = "TEMPLATE_FILES ${TEMPLATE_VARS}"
> python do_transform_template() {
> --
> 2.34.1
>
Applied to next, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-05-10 5:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-06 7:17 [PATCH] meta/classes/template: add BPN to default TEMPLATE_VARS srinuvasan.a
2024-05-07 5:24 ` Srinuvasan Arjunan
2024-05-07 9:24 ` Uladzimir Bely
2024-05-07 9:29 ` Jan Kiszka
2024-05-07 14:24 ` Srinuvasan Arjunan
2024-05-10 5:46 ` Uladzimir Bely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox