From: "Maxim Yu. Osipov" <mosipov@ilbers.de>
To: Jan Kiszka <jan.kiszka@siemens.com>,
isar-users <isar-users@googlegroups.com>
Cc: "Jin, Le" <le.jin@siemens.com>
Subject: Re: [PATCH] Use generated changelog for customized u-boot
Date: Thu, 28 Mar 2019 18:08:39 +0100 [thread overview]
Message-ID: <8ba0155b-0050-e47f-3de2-3181f50c88dc@ilbers.de> (raw)
In-Reply-To: <de3dca9d-7f88-dc8d-d6e1-7e7c4f7643e1@siemens.com>
On 3/26/19 6:58 PM, Jan Kiszka wrote:
> From: "Le Jin" <le.jin@siemens.com>
>
> Current timestamp in changelog for customized u-boot recipe
> is hard coded. This will cause a wrong build timestamp in the binary. So
> replace it with generated changelog.
Applied to the 'next'.
Thanks,
Maxim.
> Signed-off-by: Le Jin <le.jin@siemens.com>
> [Jan: rebased]
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> meta/recipes-bsp/u-boot/files/debian/changelog.tmpl | 5 -----
> meta/recipes-bsp/u-boot/u-boot-custom.inc | 5 +++--
> 2 files changed, 3 insertions(+), 7 deletions(-)
> delete mode 100644 meta/recipes-bsp/u-boot/files/debian/changelog.tmpl
>
> diff --git a/meta/recipes-bsp/u-boot/files/debian/changelog.tmpl b/meta/recipes-bsp/u-boot/files/debian/changelog.tmpl
> deleted file mode 100644
> index 6e59e06..0000000
> --- a/meta/recipes-bsp/u-boot/files/debian/changelog.tmpl
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -${PN} (${PV}) unstable; urgency=low
> -
> - * Generated package.
> -
> - -- ISAR project <isar-users@googlegroups.com> Tue, 6 Feb 2018 00:00:00 +0000
> diff --git a/meta/recipes-bsp/u-boot/u-boot-custom.inc b/meta/recipes-bsp/u-boot/u-boot-custom.inc
> index b3eab46..baf46c6 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-custom.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot-custom.inc
> @@ -17,13 +17,14 @@ SRC_URI += "file://debian/"
>
> BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git"
>
> -TEMPLATE_FILES = "debian/changelog.tmpl \
> - debian/control.tmpl"
> +TEMPLATE_FILES = "debian/control.tmpl"
> TEMPLATE_VARS += "MACHINE BUILD_DEPENDS"
>
> do_prepare_build() {
> cp -r ${WORKDIR}/debian ${S}/
>
> + deb_add_changelog
> +
> echo "${U_BOOT_BIN} /usr/lib/u-boot/${MACHINE}" > \
> ${S}/debian/u-boot-${MACHINE}.install
>
>
--
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov
prev parent reply other threads:[~2019-03-28 17:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 17:58 Jan Kiszka
2019-03-28 17:08 ` Maxim Yu. Osipov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ba0155b-0050-e47f-3de2-3181f50c88dc@ilbers.de \
--to=mosipov@ilbers.de \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
--cc=le.jin@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox