From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6672760539324612608 X-Received: by 2002:a17:906:8597:: with SMTP id v23mr1533244ejx.14.1553792927035; Thu, 28 Mar 2019 10:08:47 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:18b2:: with SMTP id c18ls5206004ejf.1.gmail; Thu, 28 Mar 2019 10:08:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqwddrMBQ5l8wqrUDGpNnTX5+9PzzxdOQMmXb7skrk4iRBpMivwGV5CMcXCg808S9amds9eB X-Received: by 2002:a17:906:4757:: with SMTP id j23mr1894239ejs.15.1553792926607; Thu, 28 Mar 2019 10:08:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553792926; cv=none; d=google.com; s=arc-20160816; b=bI638AmsVPTl7aNVozJy37cMFvjfFS9wbuFYhywqrnLAvx5+A+FdraKb6kExSf5vGZ CPfDSkdIyAZ47g92M9FJxQhca18wHqrCyd/gXge0ceF5/tFz7EiE29wMqtSg6cCbPnRq Lv2m9PTjcugTzpVS2X4QU92PtCXp3UJLcZsO93UIOJz+ggJu2hOb6oRAK7TvrpvnfeUY pnv8qQpVS96SZG4wBOqko71A64TYg4xJILB359robzoM1KJQk/BBI9B4WaMQZY3BdDUU dCAxwLkU8mZw45BRIR3b6yVGjeYjolJzLYfX0YoftVuSLOd3MMT3fKI7KGKm1TBk3M8e Nawg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:cc:to :subject; bh=98efO3UtcO/V6ybpY4GyYxnkxKCdsY0d4B2GydQ8gVs=; b=sUsrCgGPZ8CBIlIroNU91XLBpXEw1VZXeZUiK7JXwt476TTCj4OxypVt5eR6zD6i8C SkjFVfGWe2QTDbAtIPh2pI8iLvBqYtOJPs3/RlBBC8kCXnuEQRo2wbu4i6SWsNqPEHn2 D0hvdsYVosrV49cKikQxbwdUmsQ5vO9iFomQvjZkcQcKuhKqLldPhQ4o+dF+PwLYYRt7 6NxjNbeZxKk0QNwFH+2FCQ6E29oF4mAOxaHdqALcUWTtujXmOMc/YOVPVhoFhk2lI4TI RJmiRl/1EBtQp+dVBz0d+qJzSkIwYc71GmjraGde1W4pkAD/2J6K5+uZTjDFgZr+ir/m /Y7A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 55si250552edu.3.2019.03.28.10.08.46 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 10:08:46 -0700 (PDT) Received-SPF: pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.1.3] (158.126-181-91.adsl-dyn.isp.belgacom.be [91.181.126.158] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x2SH8jW2007106 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Mar 2019 18:08:45 +0100 Subject: Re: [PATCH] Use generated changelog for customized u-boot To: Jan Kiszka , isar-users Cc: "Jin, Le" References: From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <8ba0155b-0050-e47f-3de2-3181f50c88dc@ilbers.de> Date: Thu, 28 Mar 2019 18:08:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: mmL3uYE/1wJI On 3/26/19 6:58 PM, Jan Kiszka wrote: > From: "Le Jin" > > Current timestamp in changelog for customized u-boot recipe > is hard coded. This will cause a wrong build timestamp in the binary. So > replace it with generated changelog. Applied to the 'next'. Thanks, Maxim. > Signed-off-by: Le Jin > [Jan: rebased] > Signed-off-by: Jan Kiszka > --- > meta/recipes-bsp/u-boot/files/debian/changelog.tmpl | 5 ----- > meta/recipes-bsp/u-boot/u-boot-custom.inc | 5 +++-- > 2 files changed, 3 insertions(+), 7 deletions(-) > delete mode 100644 meta/recipes-bsp/u-boot/files/debian/changelog.tmpl > > diff --git a/meta/recipes-bsp/u-boot/files/debian/changelog.tmpl b/meta/recipes-bsp/u-boot/files/debian/changelog.tmpl > deleted file mode 100644 > index 6e59e06..0000000 > --- a/meta/recipes-bsp/u-boot/files/debian/changelog.tmpl > +++ /dev/null > @@ -1,5 +0,0 @@ > -${PN} (${PV}) unstable; urgency=low > - > - * Generated package. > - > - -- ISAR project Tue, 6 Feb 2018 00:00:00 +0000 > diff --git a/meta/recipes-bsp/u-boot/u-boot-custom.inc b/meta/recipes-bsp/u-boot/u-boot-custom.inc > index b3eab46..baf46c6 100644 > --- a/meta/recipes-bsp/u-boot/u-boot-custom.inc > +++ b/meta/recipes-bsp/u-boot/u-boot-custom.inc > @@ -17,13 +17,14 @@ SRC_URI += "file://debian/" > > BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git" > > -TEMPLATE_FILES = "debian/changelog.tmpl \ > - debian/control.tmpl" > +TEMPLATE_FILES = "debian/control.tmpl" > TEMPLATE_VARS += "MACHINE BUILD_DEPENDS" > > do_prepare_build() { > cp -r ${WORKDIR}/debian ${S}/ > > + deb_add_changelog > + > echo "${U_BOOT_BIN} /usr/lib/u-boot/${MACHINE}" > \ > ${S}/debian/u-boot-${MACHINE}.install > > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov