From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6750261011454885888 Date: Wed, 23 Oct 2019 23:58:06 -0700 (PDT) From: chombourger@gmail.com To: isar-users Message-Id: <8ba37251-4ee6-40fb-b076-a6e75ab8e183@googlegroups.com> In-Reply-To: <20191022155642.h7cofdpjco3rgqcl@yssyq.m.ilbers.de> References: <1571667598-657-1-git-send-email-Cedric_Hombourger@mentor.com> <1571667598-657-2-git-send-email-Cedric_Hombourger@mentor.com> <20191022093609.5ed343a5@md1za8fc.ad001.siemens.net> <514fe94a-882a-9b77-b554-f79b255a89d3@mentor.com> <20191022155642.h7cofdpjco3rgqcl@yssyq.m.ilbers.de> Subject: Re: [PATCH 1/1] bitbake: update to version 1.44.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_3393_186039145.1571900286766" X-Google-Token: EP6Wxe0F8S5daOtygCo0 X-Google-IP: 139.181.48.2 X-TUID: JMln8bHGIC/A ------=_Part_3393_186039145.1571900286766 Content-Type: multipart/alternative; boundary="----=_Part_3394_1616939218.1571900286766" ------=_Part_3394_1616939218.1571900286766 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Thanks Baurzhan Is this patch OK to merge then? Cedric On Tuesday, October 22, 2019 at 5:56:46 PM UTC+2, Baurzhan Ismagulov wrote: > > On Tue, Oct 22, 2019 at 09:41:59AM +0200, Cedric Hombourger wrote: > > I have debated (with myself :)) and I agree that there are pros and cons > > with each approach. > > I ended up submitting a single commit at the end of the day to support > > people needing to "git bisect". > > I have otherwise no issues resubmitting the changes if we prefer to have > the > > bitbake upgrade clearly separated from the Isar changes (either way is > fine > > with me - @maintainers just let me know what your preference is!) > > Since the bitbake commit breaks stuff, I have to prefer :) a single > commit. I > agree it is ugly. > > With kind regards, > Baurzhan. > ------=_Part_3394_1616939218.1571900286766 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
Thanks Baurzhan

Is this patch OK to merge then?

Cedric

On Tuesday, October 22, 2019 at 5:56:46 PM UTC+2, Baurzhan Ismagulov wrote:
On Tue, Oct 22, 2019 at 09:41:59AM +0200, Cedric Hombourger wrote:
> I have debated (with myself :)) and I agree that there are pros and cons
> with each approach.
> I ended up submitting a single commit at the end of the day to support
> people needing to "git bisect".
> I have otherwise no issues resubmitting the changes if we prefer to have the
> bitbake upgrade clearly separated from the Isar changes (either way is fine
> with me - @maintainers just let me know what your preference is!)

Since the bitbake commit breaks stuff, I have to prefer :) a single commit. I
agree it is ugly.

With kind regards,
Baurzhan.
------=_Part_3394_1616939218.1571900286766-- ------=_Part_3393_186039145.1571900286766--