From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6805226701613694976 X-Received: by 2002:a2e:98d3:: with SMTP id s19mr12522851ljj.139.1584946564021; Sun, 22 Mar 2020 23:56:04 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9099:: with SMTP id l25ls445537ljg.7.gmail; Sun, 22 Mar 2020 23:56:03 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvyMHZYYlbvzZu/MHJ/VH1ZKK5pweW6HITZKwOxAb+u4belqjr2K9N3d/Ivfl7SzqHUgUzX X-Received: by 2002:a2e:89c9:: with SMTP id c9mr13109359ljk.181.1584946563225; Sun, 22 Mar 2020 23:56:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584946563; cv=none; d=google.com; s=arc-20160816; b=oa6/OuxFwDePDhzk/IPBmoGhBlQKVAEtGOZor/GZijAg1tCqGSB+2NtHwECEkrQt1n vDRFHc2yetR1LKexraxAiQ5NzuSlmC2P0vKhczLifhSgi+UpeszQVqxxB0KM3f/M/uN7 0CSQZhORiT2RpkPDuoRBIljl/9I5hiDFgKJQIXX0Xw0jC5Z8kgCN4dQ+14JxLP6fd3ZL cjnL+YTYjoLk1Z4NGUofADugznXfQsLmmG3zi7bU3RtjQkyb3LaS7ZlcxShuBHT37685 d04EHJ6FN7HBqjhodvQksWtZzFclAnM69eycyjtNDkMvUITp8Lpq8xWtthSUwkNFgKiu H1DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=oe7KeU8yBiPd00HuVB2lVXBLG4BMFPQfYqVvdIxHJ/A=; b=T3B61y+xFD0nQUfxgfB/xxfjesok+q6NQQiTT6fDwJwU3SGs9fcuRDg/GgfVTrUO9h lo28gP9rxhF2I9J8JERbS+I89ZmCm55IsFTriEeWR/BTup60VD+tBuvIthtjzOrIJfI2 XySEWdCmPI66VRiIP0Rj6U1zZOqjJZeuN/FC4KAeXA1IjpQlpLqZaO/SHOYcWQHokGw8 fBS1KPZsFPytyiMM+vbbMklk9BgWh/yGC9y3rrlkSKtgJy+Yj/VnjATbc7EwPzbiMKCb yHAPoIaQHtukkMoTncUyInuOg2tRx60+2PA3O6qE97XayRO7J3Ihk45gzrRSjKuazIRV 3+Yg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id s22si606677ljp.0.2020.03.22.23.56.03 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 22 Mar 2020 23:56:03 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 02N6u2LX018473 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Mar 2020 07:56:02 +0100 Received: from [139.21.64.131] ([139.21.64.131]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 02N6txZr020689; Mon, 23 Mar 2020 07:56:00 +0100 Subject: Re: [PATCH v2] linux-custom: Install config and map file to /boot To: Henning Schild Cc: Vijai Kumar K , isar-users@googlegroups.com, Vijai Kumar K References: <20200318083443.57bfb489@md1za8fc.ad001.siemens.net> <20200318132137.26828-1-Vijaikumar_Kanagarajan@mentor.com> <3c561d87-4082-b25c-2a7d-932ebca37a73@siemens.com> <20200323075351.0607ceb8@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: <8bfc26fd-627b-bfa8-cbfc-6d1c7614ac47@siemens.com> Date: Mon, 23 Mar 2020 07:55:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200323075351.0607ceb8@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: sjfPbOTNQsml On 23.03.20 07:53, Henning Schild wrote: > On Mon, 23 Mar 2020 07:12:00 +0100 > "[ext] Jan Kiszka" wrote: > >> On 18.03.20 14:21, Vijai Kumar K wrote: >>> Align with upstream debian linux-image package. Install the config >>> and System.map file to /boot directory. Skip installation for User >>> Mode Linux. >>> >>> Signed-off-by: Vijai Kumar K >>> --- >>> Changes in v2: >>> - Moved um condition check as per Henning's comment >>> >>> .../linux/files/debian/isar/install.tmpl | 12 >>> ++++++++++++ 1 file changed, 12 insertions(+) >>> >>> diff --git >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index >>> 12d592d..849da5e 100644 --- >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ -37,6 >>> +37,10 @@ do_install() { set -x >>> install_image >>> + if [ "${ARCH}" != "um" ]; then >>> + install_config >>> + install_map >>> + fi >>> install_hooks >>> install_dtbs >>> install_kmods >>> @@ -69,6 +73,14 @@ install_image() { >>> install_image_debug >>> } >>> >>> +install_config() { >>> + cp ${O}/.config ${deb_img_dir}/$(dirname >>> ${kimage_path})/config-${krel} +} >>> + >>> +install_map() { >>> + cp ${O}/System.map ${deb_img_dir}/$(dirname >>> ${kimage_path})/System.map-${krel} >> >> I think those cp calls should be install with proper modes, no? > > I wanted to say that as well, but in fact the whole scripts seems to > use a mix of cp and install and this one does not make things worse. Yes, there are 2 other cases that should be fixed, separately. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux