From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6488313435861811200 X-Received: by 10.25.142.69 with SMTP id q66mr547068lfd.31.1511275973852; Tue, 21 Nov 2017 06:52:53 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.82.14 with SMTP id g14ls216665ljb.0.gmail; Tue, 21 Nov 2017 06:52:53 -0800 (PST) X-Google-Smtp-Source: AGs4zMb3uIyTw5Ba4jUFnI2k7zYAJc6hlcRNn7+UnqFrguo/h53l2aaCHtN0lj2B/S5rMTNFFz3V X-Received: by 10.46.116.16 with SMTP id p16mr682615ljc.0.1511275973127; Tue, 21 Nov 2017 06:52:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511275973; cv=none; d=google.com; s=arc-20160816; b=04LtubMe0YsBP6w2Hff727BikpxEivbyeEpnMDW2Bu1NYZ63AWULuLpIGXk3Ek3WZ8 v8YlZD0VV2q0hWOvFZXBFmi/CD56jLp7Jr1w8dhTVg+74BeEnRWxJ80wmCThjLTiBAh/ znn92mWJZRt81tYvRSLDFAiGSBZM3wcJcbI3CyuzH4aldzQyeIsfcJqctT3P06mDzVoj iIrdwhshZ6aw4vvgKQLXm64u8e5VqTZR1DS94Inv+JgND5/Cj0ngd5QAI8sWAtmHJQhJ EDOk9hKDwv0h3Qt971U6uaGSzoddggQueLlvVA+DYA7vb8BSmpo7wpSAWbxzahSg4jfA 9pog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=2o/yjcHxqIDTup1Wl3+kgVpxvLbWwfVcIL0/vJ1bb04=; b=V8KyDmKF9JlxhXhYer4aycOxoXfhKZbhZ3hpgTCgRGZPrRwoTbEYwgsbkx3ajH3Xz5 /dOoOllmWVHlNhpmrJDtKzlduTob45xSdQTDEiqIynlB5JSSssEKKno5T48vQf9joSPd 6ppKN+BfM3W2dTToXOfgBDrbmh2kNY5+MP9nmNZ5y243HlPJpYbsI/nWTFtHuy0ctgbB bxxjE8P5SY67xxwiROG5YV9Z2GWrARRlPkYcByn350/e6v0RK5NJxRRaDZ7eU5VpDija xN548Zd4INnFYJOoNiypK/YM00sEh8lp45iARhN010oy7Z7vHytab7RQwHX255PjoY0f 7jtQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id i8si1118836lfl.3.2017.11.21.06.52.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Nov 2017 06:52:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id vALEqmwK000894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Tue, 21 Nov 2017 15:52:51 +0100 Subject: Re: [PATCH] Map git objects to buildchroot To: isar-users@googlegroups.com References: <20171121081424.fkbr2amupexta2sc@MD1KR9XC.ww002.siemens.net> From: Alexander Smirnov Message-ID: <8d3214bf-8280-1ba9-8521-f120d8809daf@ilbers.de> Date: Tue, 21 Nov 2017 17:52:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171121081424.fkbr2amupexta2sc@MD1KR9XC.ww002.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: HEjB38ydpTA5 Hi again, On 11/21/2017 11:14 AM, Christian Storm wrote: >> [...] >> BTW: we always have option to clone git repository to workspace by >> running in ${WORKDIR}/git: >> >> $ git repack -a >> >> in do_build() task. With this, no extra mount/umount logic is needed. > > Yes, right, providing a (proper) git checkout in the working directory > solves the problem, as a mount --bind does. For a proper checkout, > you'll have to have the (entire) history/tags available, i.e., not a > shallow clone. For large repositories, this may take some time which a > mount --bind does not consume. On the pro side, using a (proper) > checkout, there's no way to mess with the repository from within the > buildroot, i.e., building from the same source twice - for whatever > reason - uses the exact same revision as base: Changes made to the > repository in one don't affect the other. > That said, I'm fine with both solutions. > > So, would you go ahead and post a patch, Alex? Yeah, could do this now. Alex > > >> We could consider this behavior for source 3.0 packages only by using >> some flag in recipe. > > Well, no. This way you're entangling Debian packaging internals to the > recipe. I would opt against this. Most probably you'll want to do git > operations even if you don't use source 3.0 (git) packages, e.g., > getting the latest git tag or whatever. So, I'd opt for doing it for > every source git package, unconditionally. >