Re: [PATCH v3 5/5] events: Warn if mounted paths left

[Jan Kiszka <jan.kiszka@siemens.com>]

On 08.05.21 08:25, Anton Mikanovich wrote:
> Output warnings in case any mounts are left after build.
> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  meta/classes/isar-events.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass
> index 4c49635..73419b4 100644
> --- a/meta/classes/isar-events.bbclass
> +++ b/meta/classes/isar-events.bbclass
> @@ -52,6 +52,7 @@ python build_completed() {
>      with open('/proc/mounts') as f:
>          for line in f.readlines():
>              if basepath in line:
> +                bb.warn('%s left mounted, unmounting...' % line.split()[1])
>                  subprocess.call(
>                      ["sudo", "umount", "-l", line.split()[1]],
>                      stdout=subprocess.DEVNULL,
> 

This is misplaced: If you want to warn about imbalanced mount/umount,
check that all mounts are reverted after a task class successfully
finished. We should not spam the user with additional warnings when the
build is already failing, specifically as only dpkg implements a
try-finally pattern (in way that breaks existing users...), the rest not.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux