From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6959801776553852928 X-Received: by 2002:ac2:44cf:: with SMTP id d15mr31498778lfm.427.1625140267499; Thu, 01 Jul 2021 04:51:07 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:a783:: with SMTP id c3ls1054658ljf.2.gmail; Thu, 01 Jul 2021 04:51:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFGNJjx9nCKnle0tXCdFZH8grf5WQt+sdMG2G/UlLro72yC9Oo3aDNjLbfZveQj6AOfFFL X-Received: by 2002:a2e:5811:: with SMTP id m17mr8499521ljb.59.1625140266218; Thu, 01 Jul 2021 04:51:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625140266; cv=none; d=google.com; s=arc-20160816; b=r0/14uRvuwG/JahCB/3YFp7C6/tE6SoDbk082MtOw9ndh6YnDJP2LTLBGrABR3GFTi q9Jy8ta5h5fpRRotdK+9gm7/QNcXz15Ig4KwdCRkXO8YP8gVGvq5/cJCr+Cb/hFHSlyt kktneSiVFgeJWX9aQNwELmrS/iSWc1S5ye5u+cGF3V3fwD1044ijrxO12c8Y+OR+IokC 2edOQyIlbbNZf5uAgtMbmCgWpOB+MOBE+iaLr5uKYbDJBZhJT75myW8VTX/X/AX+8YJX 7Q+aqglMw3MCv4D7Seplqr1G+ioiguB0+Hxh9Jse1ixWNrDEnvX/rEctd1kzhz0PehuA vGZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=3xHMm+mvYkKXmIegWP19mBGIf81zEiKPbXL5/I2/5hw=; b=fzPbstAQGc+KlndV+gPptEeEz2mQt8/wapjNNA8KRGV/Vd3k1LOgOmQ4OTYNCQg9IH ceN3Hj5Rh0xgi7orBN7jdK0ysOECYTIUpOSlH4ZTGAvlKSa7VoGu7vTmoNeFegl6D53U Romf+SjWey+HhzQOVjgHbR7EqXwBalVbCl6ksE82Pu2gt3MGXL0+Hk1s64nK+Sl+JCZA 5o2SP992cj2TOubpfYMLj+XJ9+HzE6ud6JQN38YHY0EsV/JWW3Y7ZMxXi8DZTMqPA0uZ b3AhUWNpfRo5+LE2spiig7sPqYWky9iRhApdMfoC8CzEoHeAQFWlZzb3jCMC1Yc2dA2R angg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id c10si875584lfv.7.2021.07.01.04.51.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Jul 2021 04:51:06 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 161Bp5sP003546 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 1 Jul 2021 13:51:05 +0200 Received: from [167.87.0.185] ([167.87.0.185]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 161Bp4rd018759; Thu, 1 Jul 2021 13:51:04 +0200 Subject: Re: [PATCH v3 5/5] events: Warn if mounted paths left To: Anton Mikanovich , isar-users@googlegroups.com References: <20210508062518.83852-1-amikan@ilbers.de> <20210508062518.83852-6-amikan@ilbers.de> From: Jan Kiszka Message-ID: <8e237790-4b21-e0f8-f4ea-b2fbbf5c3fbd@siemens.com> Date: Thu, 1 Jul 2021 13:51:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210508062518.83852-6-amikan@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: yvpMUpMb/2c6 On 08.05.21 08:25, Anton Mikanovich wrote: > Output warnings in case any mounts are left after build. > > Signed-off-by: Anton Mikanovich > --- > meta/classes/isar-events.bbclass | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass > index 4c49635..73419b4 100644 > --- a/meta/classes/isar-events.bbclass > +++ b/meta/classes/isar-events.bbclass > @@ -52,6 +52,7 @@ python build_completed() { > with open('/proc/mounts') as f: > for line in f.readlines(): > if basepath in line: > + bb.warn('%s left mounted, unmounting...' % line.split()[1]) > subprocess.call( > ["sudo", "umount", "-l", line.split()[1]], > stdout=subprocess.DEVNULL, > This is misplaced: If you want to warn about imbalanced mount/umount, check that all mounts are reverted after a task class successfully finished. We should not spam the user with additional warnings when the build is already failing, specifically as only dpkg implements a try-finally pattern (in way that breaks existing users...), the rest not. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux