From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6767012587809800192 Date: Thu, 6 Feb 2020 10:58:14 -0800 (PST) From: vijai kumar To: isar-users Message-Id: <8ee4e92c-a488-4e59-a0c6-c35d4a8292f2@googlegroups.com> In-Reply-To: <20200129063349.GA13616@oxygen> References: <20191205174441.16406-1-Vijaikumar_Kangarajan@mentor.com> <85e91f0a-da08-5345-a666-b3026bee4d96@siemens.com> <20191205191735.GA16912@oxygen> <7972e109-f8a0-6f21-bd00-4312610fd414@siemens.com> <20200129063349.GA13616@oxygen> Subject: Re: [PATCH] targz-img: Ignore tar exit code 1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_1594_1469838661.1581015494334" X-Google-Token: EMbD8fEF793ppCljg840 X-Google-IP: 192.94.34.34 X-TUID: ySIYWAB96ll4 ------=_Part_1594_1469838661.1581015494334 Content-Type: multipart/alternative; boundary="----=_Part_1595_426156775.1581015494334" ------=_Part_1595_426156775.1581015494334 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On Wednesday, January 29, 2020 at 12:03:56 PM UTC+5:30, vijai kumar wrote: > > On Thu, Dec 05, 2019 at 08:31:48PM +0100, Jan Kiszka wrote: > > On 05.12.19 20:17, Vijai Kumar K wrote: > > > On Thu, Dec 05, 2019 at 07:04:07PM +0100, Jan Kiszka wrote: > > >> On 05.12.19 18:44, vijaikumar.kanagarajan@gmail.com wrote: > > >>> From: Vijai Kumar K > > >>> > > >>> Sometimes during packaging tar prints a warning "file changed as we > read it" > > >>> and exits with return code 1. This is observed when we generete both > > >>> wic-img and targz-img together. Ignore the error. > > >> > > >> Ignoring errors is rarely a good idea. In this case, it tells you > that > > >> you have a bug in your layer that missing a dependency. I know this > > >> because we once had the same issue in a product layer. So: NAK > > >> > > >> Jan > > > > > > Ah! Ok. Back to square one I guess. Its currently observed in our > downstream setups > > > only. I have no good reason to justify it. Reproducing this issue is > gonna be difficult. > > > Let me see if I can monitor file changes and pinpoint the exact > condition. > > > But this is going to take a while. > > > > > > If it helps, the scenario is IMAGE_TYPE set to wic-img and targz-img > is > > > inherited so both are executed for a build. Also, on a seperate note > > > > wic may have found a reason to modify the rootfs while integrating it. > > So a first shot could be making targz depend on wic completion. > > > > BTW, this sounds similar to > > > https://gitlab.com/cip-project/cip-core/isar-cip-core/blob/next/classes/wic-targz-img.bbclass > > - and that class may have the same issue... > > > > > IMAGE_TYPE's functionality could be extended to provide multiple image > types. > > > I believe we could specify only one right now. Former is more clean > and particularly > > > useful if one wants a wic for sd boot and tar for nfsroot. Planning to > take this up > > > next. > > > > Right, that is of general interest, indeed. Quirin has something planned > > around the same use case as well. > > Hi Quirin, > > Do you have anything planned on this? If not, I can have a look. > Please do let me know. > > Ping. -Vijai Kumar K > Thanks, > Vijai Kumar K > > > > > Jan > > > > -- > > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > > Corporate Competence Center Embedded Linux > ------=_Part_1595_426156775.1581015494334 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable


On Wednesday, January 29, 2020 at 12:03:56 PM UTC+= 5:30, vijai kumar wrote:
On Thu= , Dec 05, 2019 at 08:31:48PM +0100, Jan Kiszka wrote:
> On 05.12.19 20:17, Vijai Kumar K wrote:
> > On Thu, Dec 05, 2019 at 07:04:07PM +0100, Jan Kiszka wrote:
> >> On 05.12.19 18:44, vijaikumar.kanagarajan@gmail.com wrote:
> >>> From: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> >>>
> >>> Sometimes during packaging tar prints a warning "= ;file changed as we read it"
> >>> and exits with return code 1. This is observed when w= e generete both
> >>> wic-img and targz-img together. Ignore the error.
> >>
> >> Ignoring errors is rarely a good idea. In this case, it t= ells you that
> >> you have a bug in your layer that missing a dependency. I= know this
> >> because we once had the same issue in a product layer. So= : NAK
> >>
> >> Jan
> >=20
> > Ah! Ok. Back to square one I guess. Its currently observed in= our downstream setups
> > only. I have no good reason to justify it. Reproducing this i= ssue is gonna be difficult.
> > Let me see if I can monitor file changes and pinpoint the exa= ct condition.
> > But this is going to take a while.
> >=20
> > If it helps, the scenario is IMAGE_TYPE set to wic-img and ta= rgz-img is
> > inherited so both are executed for a build. Also, on a sepera= te note
>=20
> wic may have found a reason to modify the rootfs while integrating= it.
> So a first shot could be making targz depend on wic completion.
>=20
> BTW, this sounds similar to
> https://gitlab.com/cip-project/cip-core/isar-cip-core/blob/nex= t/classes/wic-targz-img.bbclass
> - and that class may have the same issue...
>=20
> > IMAGE_TYPE's functionality could be extended to provide m= ultiple image types.
> > I believe we could specify only one right now. Former is more= clean and particularly
> > useful if one wants a wic for sd boot and tar for nfsroot. Pl= anning to take this up
> > next.
>=20
> Right, that is of general interest, indeed. Quirin has something p= lanned
> around the same use case as well.

Hi Quirin,

Do you have anything planned on this? If not, I can have a look.
Please do let me know.


Ping.

-Vijai = Kumar K
=C2=A0
= Thanks,
Vijai Kumar K

>=20
> Jan
>=20
> --=20
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
------=_Part_1595_426156775.1581015494334-- ------=_Part_1594_1469838661.1581015494334--