From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6751292434813026304 X-Received: by 2002:a17:906:24d4:: with SMTP id f20mr36180069ejb.182.1573056531053; Wed, 06 Nov 2019 08:08:51 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:aa7:c582:: with SMTP id g2ls749927edq.0.gmail; Wed, 06 Nov 2019 08:08:50 -0800 (PST) X-Google-Smtp-Source: APXvYqzXLgjqXkO9LtdJ1Y7BVqLofqxTnYy6+ikA5kl1GrAkgTWmw/un3mL5CX0rvkaETvBiiH0F X-Received: by 2002:aa7:d0c4:: with SMTP id u4mr3563516edo.8.1573056530507; Wed, 06 Nov 2019 08:08:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573056530; cv=none; d=google.com; s=arc-20160816; b=gpFwOPAXTRx5k5i8SJkwaAYte2lk63ipNhDRVyidOGq6xhcfBw3qvzEWXi73cKaGEU pI2DgydbolzeMVil4vsvMO7BxlEvGc4cc/Ep9lBrW3zCZUUr9EVRmHgBHlxdar/3cEuZ LuhUrG6T1RPoFX2a82UZy+FSH2F4U6ZuMdbVIa1QK2VsoYz+Jxi6WE6Nj2y9HWp6IPJ4 YJglgnwgCHODNUK0LwbtWGjan1BRAsFTOM96fB4I6lMXXRzVfSkTIHta8vNNefqQTxOE +y6n/QFa8gfP7NdQx5HmkcMoos2yreGv/lHBcUuqFbL+E1TbQhVnpYcEWWQ/YdFzh8vd WDqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=IZ76F9dGIKHUJfdtZSVUozfQ/DgKTaHW2f4ISZFqrIM=; b=tTUOUFKQzeWmwl1m+jAsOjCD0rRNsvz/XnUNfnIbd0pRnKnGhi0uwS7QRaYWKvamMi 0QDgj1V5WIU427GWJdW5iZ9kt2P6xnx9Pzn122BY9c1/xP1ok1sds/kSPEJYqfXehts5 qhCALw5zxeAnVDayzL0dwHiVVU2N8GhtL4hsQlMibcX/gufy81YxVLVou8K8Lf2wOQ68 fVVv5mhrpAylBuMnCpzd/E685eQ3oBGwpaN5OVnBGFY1kT5eqPEqSPnFvc1/TAqBkTSP tnHfqmAHaxp4hL8XVaw+dOswdb6QQkTOYBjy6Jjs5ffwXiHokqBtp9bKW8HsD4rla9Tp YX6Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id c28si1369064eda.4.2019.11.06.08.08.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Nov 2019 08:08:50 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id xA6G8oJ5015608 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 6 Nov 2019 17:08:50 +0100 Received: from [139.22.41.172] ([139.22.41.172]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id xA6G8nZa010651; Wed, 6 Nov 2019 17:08:49 +0100 Subject: Re: [PATCH 07/10] image: add CUSTOM_IMAGE_EXTENSIONS for user layers/machines to use To: "[ext] Henning Schild" , Cedric Hombourger Cc: isar-users@googlegroups.com References: <1571907744-1121-1-git-send-email-Cedric_Hombourger@mentor.com> <1571907744-1121-8-git-send-email-Cedric_Hombourger@mentor.com> <20191024200903.6743650a@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: <8efb826c-2021-0646-ba4e-daa14d05e534@siemens.com> Date: Wed, 6 Nov 2019 17:08:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191024200903.6743650a@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: +NVbRNONPiW7 On 24.10.19 20:09, [ext] Henning Schild wrote: > Very smelly and hacky ;). There is no such way since there is a strict > policy to try and solve everything with packages ... except for where > this is not possible ... > > I am strongly against that, it will be abused. If you need to inherit > image.bbclass in your own funny-image.bbclass and add the hack in a > layer. Ack, specifically while we do not know the actual use case. Can you explain it, Cedric? And if you want to hack, nothing prevent you from defining a custom image /recipe/ that inherits "CUSTOM_IMAGE_EXTENSION" directly. Jan > > Henning > > Am Thu, 24 Oct 2019 11:02:21 +0200 > schrieb Cedric Hombourger : > >> Some machines may require additional post-processing on the image >> before the actual file-system image is created. The image extension >> mechanism was designed for this purpose but does not seem to provide >> any way for user layers/machines to use. Add a >> CUSTOM_IMAGE_EXTENSIONS variable to fill this gap. >> >> Signed-off-by: Cedric Hombourger >> --- >> meta/classes/image.bbclass | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass >> index 7690bc5..633b514 100644 >> --- a/meta/classes/image.bbclass >> +++ b/meta/classes/image.bbclass >> @@ -30,6 +30,9 @@ BUILDROOT_DEPLOY = "${BUILDCHROOT_DIR}${PP_DEPLOY}" >> BUILDROOT_ROOTFS = "${BUILDCHROOT_DIR}${PP_ROOTFS}" >> BUILDROOT_WORK = "${BUILDCHROOT_DIR}${PP_WORK}" >> >> +# Default to no custom image extensions >> +CUSTOM_IMAGE_EXTENSIONS ?= "" >> + >> python(){ >> if (d.getVar('IMAGE_TRANSIENT_PACKAGES')): >> bb.warn("IMAGE_TRANSIENT_PACKAGES is set and no longer >> supported") @@ -71,6 +74,7 @@ inherit image-tools-extension >> inherit image-postproc-extension >> inherit image-locales-extension >> inherit image-account-extension >> +inherit ${CUSTOM_IMAGE_EXTENSIONS} >> >> # Extra space for rootfs in MB >> ROOTFS_EXTRA ?= "64" > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux