public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Quirin Gylstorff' via isar-users" <isar-users@googlegroups.com>
To: Felix Moessbauer <felix.moessbauer@siemens.com>,
	isar-users@googlegroups.com
Cc: jan.kiszka@siemens.com, cedric.hombourger@siemens.com,
	adriaan.schmidt@siemens.com, christoph.steiger@siemens.com
Subject: Re: [PATCH 1/2] dpkg-raw: add files to source package
Date: Thu, 4 Dec 2025 11:31:54 +0100	[thread overview]
Message-ID: <8f357977-c8fe-4db8-bae9-e52a9068b664@siemens.com> (raw)
In-Reply-To: <20250820124140.281190-2-felix.moessbauer@siemens.com>

Hi,

On 8/20/25 14:41, 'Felix Moessbauer' via isar-users wrote:
> In dpkg-raw, the user can place files in ${D} which are then installed
> into the resulting binary package. Hereby, ${D} is a directory outside
> of ${S} (since b19cd25) to not interfere with other data added to ${S}.
> However, by that the files are not added to the source package. This
> remained unnoticed, as the directory dh_install installs from is set
> to absolute path, hence the installed files actually came from the
> absolute path and not from the extracted source package. In case of
> ${PN} == ${BPN}, this path was always there as it has been created by
> previous tasks. However, with the switch in 2ca3a7e5 to only build the
> source package once, the path is not always there.
> 
> We fix this by adding the files to the source package (under image) and
> install from a relative base. We further use a sub-path (image) in ${S}
> as a temporary location to not run into the issue solved in b19cd25.
> 
> Fixes: 2ca3a7e5 ("dpkg-source: Build source package only once")
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---

This patch  breaks the possibility to install *.so (for example from 
external deliveries) into the system.

Quirin>   meta/classes/dpkg-raw.bbclass | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/dpkg-raw.bbclass b/meta/classes/dpkg-raw.bbclass
> index a7bf204a..d4cb7d8a 100644
> --- a/meta/classes/dpkg-raw.bbclass
> +++ b/meta/classes/dpkg-raw.bbclass
> @@ -5,7 +5,7 @@
>   
>   inherit dpkg
>   
> -D = "${WORKDIR}/image"
> +D = "${S}/image"
>   
>   # Default to creating a binary-indep package
>   DPKG_ARCH ??= "all"
> @@ -30,6 +30,6 @@ do_prepare_build() {
>   	cat <<EOF >> ${S}/debian/rules
>   
>   override_dh_install:
> -	dh_install --sourcedir=${PP}/image
> +	dh_install --sourcedir=image
>   EOF
>   }

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/8f357977-c8fe-4db8-bae9-e52a9068b664%40siemens.com.

  parent reply	other threads:[~2025-12-04 10:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-20 12:41 [PATCH 0/2] handle DPKG_ARCH=all case for transitive deps 'Felix Moessbauer' via isar-users
2025-08-20 12:41 ` [PATCH 1/2] dpkg-raw: add files to source package 'Felix Moessbauer' via isar-users
2025-10-03 11:09   ` Anton Mikanovich
2025-12-04 10:31   ` 'Quirin Gylstorff' via isar-users [this message]
2025-12-04 10:50     ` 'MOESSBAUER, Felix' via isar-users
2025-12-04 19:54       ` 'Quirin Gylstorff' via isar-users
2025-08-20 12:41 ` [PATCH 2/2] handle DPKG_ARCH=all case for transitive deps 'Felix Moessbauer' via isar-users
2025-09-10 11:00   ` Andreas Naumann
2025-09-11 10:20     ` 'MOESSBAUER, Felix' via isar-users
2025-09-12 15:50       ` Andreas Naumann
2025-09-15  7:55         ` 'MOESSBAUER, Felix' via isar-users
2025-09-15 17:49   ` Andreas Naumann
2025-09-16  7:16     ` 'MOESSBAUER, Felix' via isar-users
2025-09-19  7:15       ` Andreas Naumann
2025-10-06 14:05         ` 'MOESSBAUER, Felix' via isar-users
2025-10-07 10:57           ` 'Andreas Naumann' via isar-users
2025-10-07 12:31   ` Zhihang Wei
2025-10-20 12:07     ` 'cedric.hombourger@siemens.com' via isar-users
2025-10-20 12:23       ` 'Jan Kiszka' via isar-users
2025-10-20 12:25         ` 'cedric.hombourger@siemens.com' via isar-users
2025-10-24 13:03   ` 'MOESSBAUER, Felix' via isar-users
2025-11-03 13:56   ` 'Jan Kiszka' via isar-users
2025-11-03 15:44     ` 'MOESSBAUER, Felix' via isar-users
2025-10-24  5:34 ` [PATCH 0/2] " 'cedric.hombourger@siemens.com' via isar-users
2025-10-24  7:36   ` 'MOESSBAUER, Felix' via isar-users
2025-10-27 13:35   ` 'Andreas Naumann' via isar-users
2025-10-31 11:10 ` 'Niedermayr, BENEDIKT' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f357977-c8fe-4db8-bae9-e52a9068b664@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=adriaan.schmidt@siemens.com \
    --cc=cedric.hombourger@siemens.com \
    --cc=christoph.steiger@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=quirin.gylstorff@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox