From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6755874534332563456 X-Received: by 2002:a05:6000:1:: with SMTP id h1mr8562888wrx.284.1573221423366; Fri, 08 Nov 2019 05:57:03 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:5284:: with SMTP id c4ls5790494wrv.15.gmail; Fri, 08 Nov 2019 05:57:02 -0800 (PST) X-Google-Smtp-Source: APXvYqzq3so+jeNaDe+7+FAGksg1ZmU7urvxs42tEO2g1a6+WsdYfgw+Rm6qJ68T6vahLgw+MpQ7 X-Received: by 2002:a5d:4ecd:: with SMTP id s13mr8936677wrv.216.1573221422635; Fri, 08 Nov 2019 05:57:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573221422; cv=none; d=google.com; s=arc-20160816; b=Og5XXDG2+VUwgVj9bBa0il1yrj1MfriRdpJZoERd5Kvbw1A6EMN17Kt8p9/lSKmBdf OxtRACsR6jWP6u26PX8s1NchDsduPI9YuhD74RyctNzpmpmI7B2gPmeu4LZkUbWCMSPi /yFJnRfK+wdeWJil/eeqzkN1aCEwyXZuKMgVp7EN/Kwv/JqSqZf6MSuTSu4TwWZNn7uQ VjqgXJuwXkCNSbYmnOQudtQxbwth/aelKc40Gb0JPa7txS8bVvaSdgDp54uqbEfm8gG5 Hm9KbsUVaNyYrPSufDTROFkB1IasKPHdQwtxbuqhUOOsL95pwbIEDcM5IO3pT9yT7Jzo 06zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:from:subject; bh=px2spX8hmEPfB9CWCnmoaj6YwJmBkF5tqbHhax79luY=; b=O2aknVFPJKRfr6M/VuCo94exqD3zkb9N79K4JbQJB4KQd+os70WO8bKLSNg64wSNDV oybYmEo8DJ9VPldEeAi+/wOFzTyixpmpNTYJsvBz8wGLKovC2mQAacLZzUBujmIlVLky 0aHo9w5LHKZBe50cx811hITvyz8FnTDZQJ89z4IiVD/HQxuuE2QhwzNIdFM6qDSuFjSi cTU2RnpBhUCwcn7tjs3PCQQBOxRvjh2vZYRb4Nji/31JYVJiFVTJ3ZL8Cfp14mVFGl5i eJNLE3zVz6i/9vdJrXDNXSo8W7TEZwH1rDM0zztpWVflR+PEIjoeV2fCKK3GhL4mP6wx NULg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id i15si416739wrv.0.2019.11.08.05.57.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Nov 2019 05:57:02 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id xA8Dv2to002063 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Nov 2019 14:57:02 +0100 Received: from [139.25.68.37] ([139.25.68.37]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id xA8Dv2XY020157; Fri, 8 Nov 2019 14:57:02 +0100 Subject: Re: [PATCH] isar-events: Hook into BuildStarted for task-once cleanup From: Jan Kiszka To: isar-users , Baurzhan Ismagulov References: Message-ID: <8fa4bb39-44ad-c303-9e0d-6fb68cef37f5@siemens.com> Date: Fri, 8 Nov 2019 14:56:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: ONPLHDX5Cgcq On 05.11.19 18:23, [ext] Jan Kiszka wrote: > From: Jan Kiszka > > The Parse* events are unfortunately only fired when there is no cache. > Hooking into the BuildStarted does not have this shortcoming, just > implies multiple events (one per multiconfig), but that is harmless. > > Signed-off-by: Jan Kiszka > --- > meta/classes/isar-events.bbclass | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass > index cad1d57..4c49635 100644 > --- a/meta/classes/isar-events.bbclass > +++ b/meta/classes/isar-events.bbclass > @@ -4,12 +4,12 @@ > # Copyright (C) 2015-2017 ilbers GmbH > # Copyright (c) Siemens AG, 2018 > > -addhandler parse_completed > +addhandler build_started > > -python parse_completed() { > +python build_started() { > bb.utils.remove(d.getVar('TMPDIR') + "/work/*/*/*/temp/once.*") > } > -parse_completed[eventmask] = "bb.event.ParseCompleted" > +build_started[eventmask] = "bb.event.BuildStarted" > > def task_once_stamp(d): > return "{temp}/once.{task}".format(temp=d.getVar('T'), > I think this should take a fast-path as it resolves many wrong and misleading error messages. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux