public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: alexander.heinisch@siemens.com, isar-users@googlegroups.com
Subject: Re: [PATCH] Fixing: Handling of unattended installers target overwrite mode.
Date: Wed, 06 Nov 2024 15:33:55 +0300	[thread overview]
Message-ID: <901325bf1904b594edced2a20406fa9a0e6af444.camel@ilbers.de> (raw)
In-Reply-To: <20241031163340.785408-1-alexander.heinisch@siemens.com>

On Thu, 2024-10-31 at 17:33 +0100, alexander.heinisch via isar-users
wrote:
> From: Alexander Heinisch <alexander.heinisch@siemens.com>
> 
> This bug was introduced in 934fe3ef due to over-motivated search and
> replace.
> 
> Signed-off-by: Alexander Heinisch <alexander.heinisch@siemens.com>
> ---
>  .../deploy-image/files/usr/bin/deploy-image-wic.sh          | 6
> ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-isar/recipes-installer/deploy-
> image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-
> installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> index e6ee426d..91c0518b 100755
> --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-
> image-wic.sh
> +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-
> image-wic.sh
> @@ -130,9 +130,11 @@ if ! cmp /dev/zero "$installer_target_dev" -n
> 1M; then
>                  --yesno "WARNING: Target device is not empty!
> Continue anyway?" 5 60; then
>          exit 0
>      else
> -        if [ "$installer_target_overwrite" !=
> "installer_target_overwrite" ]; then
> +        if [ "$installer_target_overwrite" != "OVERWRITE" ]; then
>              echo "Target device is not empty! -> Abort"
> -            echo "If you want to override existing data set
> \"installer_target_overwrite=installer_target_overwrite\""
> +            echo "If you want to override existing data set
> \"installer.target.overwrite=OVERWRITE\" on your kernel cmdline or
> edit your \"auto.install\" file accordingly."
> +
> +            exit 1
>          fi
>      fi
>  fi
> -- 
> 2.43.0
> 

Applied to next, thanks.

-- 
Best regards,
Uladzimir.



-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/901325bf1904b594edced2a20406fa9a0e6af444.camel%40ilbers.de.

      reply	other threads:[~2024-11-06 12:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31 16:33 alexander.heinisch via isar-users
2024-11-06 12:33 ` Uladzimir Bely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=901325bf1904b594edced2a20406fa9a0e6af444.camel@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=alexander.heinisch@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox