From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7221425893476925440 X-Received: by 2002:a7b:cd09:0:b0:3f8:f13b:fd0c with SMTP id f9-20020a7bcd09000000b003f8f13bfd0cmr7967417wmj.21.1687180227815; Mon, 19 Jun 2023 06:10:27 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:6917:b0:3f8:fa9e:5fa0 with SMTP id fo23-20020a05600c691700b003f8fa9e5fa0ls215136wmb.0.-pod-prod-06-eu; Mon, 19 Jun 2023 06:10:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4O9Ril+tc5wyDE+4+EpL6nfxcTPHAekZrrGXw/Ea/d09MLZQDpGb01iXJ9K3RM/z7AZ1nk X-Received: by 2002:adf:ef8d:0:b0:30e:38d3:cc4f with SMTP id d13-20020adfef8d000000b0030e38d3cc4fmr5695840wro.36.1687180226169; Mon, 19 Jun 2023 06:10:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687180226; cv=none; d=google.com; s=arc-20160816; b=ZM2Q6gClGlrhgT4V8b2znGqSXJp3DDBYgO97mA6V9WmTtu7iwwUwg4zZyppyWSAzKk lRunDnsUPxq/S5Lo4tDrnrD6MdU9v0dIbaJYlWz9/ylElqzZMxwrUydPreMuReZOfMHz 5M1fnemt99Kqnx9FOYffQhjFH164x+ZuJuPvtZndbr4f3hcHwWnH6wkvZ3VhNmDGnEEs iDw/Jg1Mu+lQgzmencRV8oC5OwvdR6619Tkb/gFEBHEJt5VYOrFgUtU8tZh9DQAfhCVU bqigIjD7xCqUJ2wEuxYnFKFwj5B1QlP2Wq4t5sfjavxQMDkxQG8Toow3EQxzPhEOlZpH T1Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:mime-version:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:dkim-signature; bh=MsaDRa1xn7ZUiPMh9TyrmpDQS6uyu3r9fMse2E8IP4A=; b=jZdFL12MyYaa6FDPQvucNqIr8oXeGcQAiZeCrXqXTv4FZjCYmERRb7s1IUDPMo99B+ oe2/5AqyMf04e/+SV7vgHZQRhKwt9QMxRrmR2HftWbz7/mOF1kTLU0v3V+0JRPeqKwXc 91j4mfGH3qofjTZqHy2/wWamxK/SqX2gpZD12s6X86f6IKPcuNuelpxMLDt4PtSdp65Q j4k6N2renKmxEFxutR7znCsDzSlEa+aIYOyorbDm6uQrP2m/aYgzCDlkJoZ8jSkP0QPL qQMyUlW9SE65Wd0A2mTVcfJE9AWWkl24Iv0230eSPWgr+0DvG/4T/ZpwVd2yHzEtCQeW fccw== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=VBI0cKSC; spf=pass (google.com: domain of fm-72506-202306191310252ffe2debf08d089442-s5lena@rts-flowmailer.siemens.com designates 185.136.65.228 as permitted sender) smtp.mailfrom=fm-72506-202306191310252ffe2debf08d089442-S5leNa@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from mta-65-228.siemens.flowmailer.net (mta-65-228.siemens.flowmailer.net. [185.136.65.228]) by gmr-mx.google.com with ESMTPS id bq2-20020a5d5a02000000b003111816630dsi620695wrb.5.2023.06.19.06.10.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Jun 2023 06:10:26 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-72506-202306191310252ffe2debf08d089442-s5lena@rts-flowmailer.siemens.com designates 185.136.65.228 as permitted sender) client-ip=185.136.65.228; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=VBI0cKSC; spf=pass (google.com: domain of fm-72506-202306191310252ffe2debf08d089442-s5lena@rts-flowmailer.siemens.com designates 185.136.65.228 as permitted sender) smtp.mailfrom=fm-72506-202306191310252ffe2debf08d089442-S5leNa@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: by mta-65-228.siemens.flowmailer.net with ESMTPSA id 202306191310252ffe2debf08d089442 for ; Mon, 19 Jun 2023 15:10:25 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=felix.moessbauer@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:References:In-Reply-To; bh=MsaDRa1xn7ZUiPMh9TyrmpDQS6uyu3r9fMse2E8IP4A=; b=VBI0cKSC7Rt3i8AaFgrctydbU2qy0dVUF/0JRsNwDw60F/mQ2b30bEeVB1Ap8ds9l30qsf rLTEf+JNWEkyYh2IETWbR2KZKsPDqmTX22MiQW1J6ZMIOW6BxELpOg9nSLwjjsJsusV/Zp7r 7UodWgSW16JClpau8EOF2Nt0SrMgs=; Message-ID: <90d556c033d3266ce219880accb2aabdb2d9976c.camel@siemens.com> Subject: Re: [PATCH 1/2] add support for derived sbuild chroots From: Moessbauer Felix To: Jan Kiszka , Uladzimir Bely , isar-users@googlegroups.com, Baurzhan Ismagulov Date: Mon, 19 Jun 2023 21:10:20 +0800 In-Reply-To: <05246f6a-cd48-60b2-766a-028db42100ea@siemens.com> References: <20230413070026.3511123-1-felix.moessbauer@siemens.com> <902a5e9b613428bb7e7782ae6a5405b067c0333e.camel@ilbers.de> <05246f6a-cd48-60b2-766a-028db42100ea@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-72506:519-21489:flowmailer X-TUID: Uq42pexbpvh1 On Mon, 2023-06-19 at 07:58 +0200, Jan Kiszka wrote: > On 13.06.23 08:24, Uladzimir Bely wrote: > > On Thu, 2023-04-13 at 07:00 +0000, 'Felix Moessbauer' via isar- > > users > > wrote: > > > This patch adds support to create derived sbuild chroots to > > > speedup > > > the > > > build process. For packages that share a large set of common > > > build > > > dependencies, a derived sbuild chroot can be created to avoid the > > > overhead of installing all base build-deps on each sbuild > > > invocation. > > >=20 > > > Signed-off-by: Felix Moessbauer > > > --- > > > =C2=A0doc/user_manual.md=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 27 > > > +++++++++++++++++++ > > > =C2=A0meta/classes/crossvars.bbclass=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 11 +++++--- > > > =C2=A0.../sbuild-chroot/sbuild-chroot.inc=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 7 ++++- > > > =C2=A03 files changed, 41 insertions(+), 4 deletions(-) > >=20 > > We are going to merge this in near few days in spite of an open > > question left in discussion. The reasons: > >=20 > > 1. It passes internal CI (dev/fast/full). > >=20 > > 2. It was useful in case of 'meta-iot2050' downstream for rewriting > > "npm.bbclass" in order not to use buildchroot.bbclass (that is > > going to > > be deleted with "Imager schroot migration" patchset that is to be > > merged soon too. >=20 > To track what I discussed with Baurzhan offlist: I would be good to > have > some QA check running when using a derived sbuild chroot that the > package built has all extra packages as part of its Build-Depends so > that we are not create again silently broken debianizations. Any > ideas > how to achieve that best, considering also implicit inclusions of the > Build-Depends? This is hard to achieve. The only way I could currently imagine is to run the same package build in the standard chroot and check if it still properly builds (by definition, the derived chroot has a superset of the packages). For the created artifact, too-many packages in a build chroot are not problematic. Given that, at least the created packages are fine. >=20 > Furthermore, I had a small comment on patch 2. I would rather postpone the "derive chroot name" aspect to later. It is a minor thing and currently I lack the time to implement it. Feel free to add a patch on top. Felix >=20 > Jan >=20