public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'MOESSBAUER, Felix' via isar-users" <isar-users@googlegroups.com>
To: "Koch, Stefan" <stefan-koch@siemens.com>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Cc: "Kiszka, Jan" <jan.kiszka@siemens.com>,
	"Storm, Christian" <christian.storm@siemens.com>,
	"Adler, Michael" <michael.adler@siemens.com>,
	"Schertler, Daniel" <daniel.schertler@siemens.com>,
	"Becker, Sascha" <becker@siemens.com>,
	"ubely@ilbers.de" <ubely@ilbers.de>
Subject: Re: [PATCH v2] Fix ZeroDivisionError for kernels without modules
Date: Fri, 17 Apr 2026 12:10:18 +0000	[thread overview]
Message-ID: <90eddff3bc46d2f426843c8adeb9b354f7e5cc5f.camel@siemens.com> (raw)
In-Reply-To: <20260417114032.1255396-1-stefan-koch@siemens.com>

On Fri, 2026-04-17 at 13:40 +0200, Stefan Koch wrote:
> Ensure that `num_pkgs` is at least 1 to avoid division by zero.
> 
> Fixes: 938dab36 ("Report approximate progress during initrd generation")

Thanks!

Reviewed-by: Felix Moessbauer <felix.moessbauer@siemens.com>

This should also go into the v1.0.1 release.

Felix

> 
> Signed-off-by: Stefan Koch <stefan-koch@siemens.com>
> ---
>  meta/lib/rootfs_progress.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/lib/rootfs_progress.py b/meta/lib/rootfs_progress.py
> index 6feed9df..58d16574 100644
> --- a/meta/lib/rootfs_progress.py
> +++ b/meta/lib/rootfs_progress.py
> @@ -77,7 +77,7 @@ class InitrdProgressHandler(PkgsProgressHandler):
>          m = re.search(r'^Total number of modules: ([0-9]+)', line)
>          if m:
>              # in MODULES=most mode, we install ~half of all modules
> -            self._num_pkgs = int(m.group(1)) // 2
> +            self._num_pkgs = max(1, int(m.group(1)) // 2)
>              self._stage = 'post-prepare'
>  
>      def process_line(self, line):
> -- 
> 2.47.3

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/90eddff3bc46d2f426843c8adeb9b354f7e5cc5f.camel%40siemens.com.

  reply	other threads:[~2026-04-17 12:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-17 11:40 'Stefan Koch' via isar-users
2026-04-17 12:10 ` 'MOESSBAUER, Felix' via isar-users [this message]
2026-04-22 10:27 ` Zhihang Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90eddff3bc46d2f426843c8adeb9b354f7e5cc5f.camel@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=becker@siemens.com \
    --cc=christian.storm@siemens.com \
    --cc=daniel.schertler@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=michael.adler@siemens.com \
    --cc=stefan-koch@siemens.com \
    --cc=ubely@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox