Re: [PATCH 1/2] Add basic patch support

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2018-02-20 12:12, Alexander Smirnov wrote:
> On 02/18/2018 10:39 PM, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Add a do_patch task after unpack the processes .patch files in the
>> SRC_URI. We likely miss some special features compared to OE, but this
>> covers the common case of few individual patches. Application order is
>> derived from appearance in SRC_URI list. Strip level can be configured
>> via "striplevel=N" URI parameter. The application is controlled
>> explicitly via the "apply=yes|no" parameter.
> 
> What's the issue to take the full implementation from OE? How this
> user-interface differs from OE?

The OE version is much more complex, consisting of a class + some
library code at least. The library code seems to have further
dependencies on OE functions. Importing all that, possibly changing
things to work again, requires some clear maintenance/synchronization
strategy. TBH, that appeared too complex to me at this point, and so
went for the simpler solution. That does not exclude enhancing/replacing
this later on, specifically as this implementation here is compatible
from user-perspective.

Jan