From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6523981284478287872 X-Received: by 10.25.181.150 with SMTP id g22mr144960lfk.33.1519205765122; Wed, 21 Feb 2018 01:36:05 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.25.170.83 with SMTP id t80ls96242lfe.0.gmail; Wed, 21 Feb 2018 01:36:04 -0800 (PST) X-Google-Smtp-Source: AH8x224ZW6qqwge4UxTSfavJnUBZ+l/pMxEWtY8Q0+wFtOEB4HQxwudjA4Tk7ZYBUMhUtvAv8tPB X-Received: by 10.25.235.140 with SMTP id f12mr136080lfk.19.1519205764353; Wed, 21 Feb 2018 01:36:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519205764; cv=none; d=google.com; s=arc-20160816; b=NW4mxG/I+T6L5V4z/odIRf6ZKPz/PS2x8PKyE4/6ysMU3MXjWkR11sjnrQWyfyX5ko l/yIZGNV/+Z03Kvyvig7Zs+zSudWjNBnBiYViqd9tIltJRqcVF+s51GmUlKofJjvlZIz i167i7siIUYPC53Hfocf20x+FceA0B82kA/Qn1uBG8KxNFlEfr93IQ8bFFjiXjXmDcIq lJ7ZpwnK7wb/u3rp0bXtV2Fg7fwq/FWaBHVune8YtUAHB3RcbHyQ6hxMOTRS+d/agYKC mF/0pPfRQPb7m29qI1DqDQwho3Zfsd6gC+raQoqy1qxLpUbeKiObP8sdPuHSZSnvrFbx O58w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=YPaNlB+s1j7RMHQao8jdzlZQ8MNw+Q5qWQW1YVvwgvQ=; b=XPwiiqfs5NFB3Oa0Buut+LEpyUPeF330wN34UxI3hukGlRB3Wnkyw3uoiPRPHrWqpv DstkSxWQW2Xoy1BUpNdiJu0+DnCwHRh4FsUuID2bPcGuLXOWC0sn8orRU9cbdBNQOKQb X4l80VQeRIco9iVkcHttfBVIfl9VjLmkEymxbOXRaEJM/0T+ZXIHGVc3RymcSwgg+f0F zROmVQLtMU8oPLLX279oND/kuFaZuoZwLx+meCoanNaTXrF+6FyoynLmBJfFpPyjlaGT vaISHHEhu6flv+QsBDiWrWv8Cn0iaYn784EjfXeWWePo2/Rq08aM4PUfizShEHhildar oQUA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id z25si158126lfg.5.2018.02.21.01.36.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Feb 2018 01:36:04 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w1L9a37a019406 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Feb 2018 10:36:03 +0100 Received: from [167.87.9.13] ([167.87.9.13]) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id w1L9a1j1005635; Wed, 21 Feb 2018 10:36:02 +0100 Subject: Re: [PATCH 1/2] Add basic patch support To: Alexander Smirnov , isar-users References: <389542c1-1367-2639-a13c-ebbb9318c05b@siemens.com> <4a2e08c0-a483-3469-2466-1aadbc51218c@ilbers.de> From: Jan Kiszka Message-ID: <9106ed79-3d3d-f485-a551-deca62862804@siemens.com> Date: Wed, 21 Feb 2018 10:36:01 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <4a2e08c0-a483-3469-2466-1aadbc51218c@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: +ZVYC90hL7dP On 2018-02-20 12:12, Alexander Smirnov wrote: > On 02/18/2018 10:39 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Add a do_patch task after unpack the processes .patch files in the >> SRC_URI. We likely miss some special features compared to OE, but this >> covers the common case of few individual patches. Application order is >> derived from appearance in SRC_URI list. Strip level can be configured >> via "striplevel=N" URI parameter. The application is controlled >> explicitly via the "apply=yes|no" parameter. > > What's the issue to take the full implementation from OE? How this > user-interface differs from OE? The OE version is much more complex, consisting of a class + some library code at least. The library code seems to have further dependencies on OE functions. Importing all that, possibly changing things to work again, requires some clear maintenance/synchronization strategy. TBH, that appeared too complex to me at this point, and so went for the simpler solution. That does not exclude enhancing/replacing this later on, specifically as this implementation here is compatible from user-perspective. Jan