public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "vijaikumar....@gmail.com" <vijaikumar.kanagarajan@gmail.com>
To: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH v6 00/13] Deb-src caching
Date: Thu, 26 Nov 2020 02:43:06 -0800 (PST)	[thread overview]
Message-ID: <911cf383-3e22-4ca6-a1ac-55867327776cn@googlegroups.com> (raw)
In-Reply-To: <20201126102123.GE31950@yssyq.m.ilbers.de>


[-- Attachment #1.1: Type: text/plain, Size: 2032 bytes --]



On Thursday, November 26, 2020 at 3:51:34 PM UTC+5:30 i...@radix50.net 
wrote:

> On Tue, Nov 24, 2020 at 10:04:24PM -0800, vijaikumar....@gmail.com wrote: 
> > You might want to set BASE_REPO_FEATURES ?= "cache-deb-src" in local 
> conf. 
> > By default its disabled. Not everyone 
> > want to cache the deb sources. It takes a lot of time. 
>
> Thanks Vijai Kumar, will play with v8. It's good to have this in the 
> manual. 
>
> What about the issues below? Should I include them myself? 
>

Oops. Sorry about that. I somehow missed to see these comments. I will 
address these in v9.

Thanks,
Vijai Kumar K
 

>
>
> p1: 
>
> On Tue, Nov 24, 2020 at 08:47:11PM +0100, Baurzhan Ismagulov wrote: 
> > On Wed, Sep 30, 2020 at 11:32:47AM +0530, Vijai Kumar K wrote: 
> > > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass 
> > > index afec1cb..eae14d5 100644 
> > > --- a/meta/classes/rootfs.bbclass 
> > > +++ b/meta/classes/rootfs.bbclass 
> > > @@ -201,45 +201,6 @@ rootfs_generate_manifest () { 
> > > ${ROOTFS_MANIFEST_DEPLOY_DIR}/"${PF}".manifest 
> > > } 
> > > 
> > > -ROOTFS_POSTPROCESS_COMMAND += 
> "${@bb.utils.contains('ROOTFS_FEATURES', 'finalize-rootfs', 
> 'rootfs_postprocess_finalize', '', d)}" 
> > 
> > Suggest also removing the 'finalize-rootfs' comment before 
> ROOTFS_FEATURES ?= 
> > "". 
>
>
> p3, p9: 
>
> On Tue, Nov 24, 2020 at 08:49:19PM +0100, Baurzhan Ismagulov wrote: 
> > On Wed, Sep 30, 2020 at 11:32:49AM +0530, Vijai Kumar K wrote: 
> > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass 
> > > index 2391529..6ca5759 100644 
> > > --- a/meta/classes/image.bbclass 
> > > +++ b/meta/classes/image.bbclass 
> > > @@ -63,7 +63,7 @@ image_do_mounts() { 
> > > } 
> > > 
> > > ROOTFSDIR = "${IMAGE_ROOTFS}" 
> > > -ROOTFS_FEATURES += "clean-package-cache generate-manifest" 
> > > +ROOTFS_FEATURES += "clean-package-cache generate-manifest 
> cach-deb-src" 
> > 
> > Should it be "cache-deb-src"? The same for p9. 
>
>
> With kind regards, 
> Baurzhan. 
>

[-- Attachment #1.2: Type: text/html, Size: 2714 bytes --]

      reply	other threads:[~2020-11-26 10:43 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30  6:02 Vijai Kumar K
2020-09-30  6:02 ` [PATCH v6 01/13] rootfs: Make rootfs finalize a separate task Vijai Kumar K
2020-11-24 19:47   ` Baurzhan Ismagulov
2020-09-30  6:02 ` [PATCH v6 02/13] deb-dl-dir: Cache host distro debs separately Vijai Kumar K
2020-09-30  6:02 ` [PATCH v6 03/13] meta: cache deb srcs as part of postprocessing Vijai Kumar K
2020-09-30  6:06   ` [PATCH v6 04/13] deb-dl-dir: Make debsrc_download faster Vijai Kumar K
2020-09-30  6:06     ` [PATCH v6 05/13] deb-dl-dir: Download files only belonging to the current image Vijai Kumar K
2020-09-30  6:07     ` [PATCH v6 06/13] deb-dl-dir: Factor out the mounting part Vijai Kumar K
2020-09-30  6:07     ` [PATCH v6 07/13] deb-dl-dir: Fix skipping of removed files Vijai Kumar K
2020-09-30  6:07     ` [PATCH v6 08/13] repository: Add a sanity test to check missing sources Vijai Kumar K
2020-09-30  6:18       ` [PATCH v6 09/13] base-apt: Introduce BASE_REPO_FEATURES Vijai Kumar K
2020-09-30  6:18         ` [PATCH v6 10/13] repository: Fix failures due to missing section Vijai Kumar K
2020-09-30  6:18         ` [PATCH v6 11/13] scripts/ci_build.sh: Enable deb-src caching Vijai Kumar K
2020-09-30  6:18         ` [PATCH v6 12/13] rootfs: Fix possible overwrite of existing resolv.conf Vijai Kumar K
2020-09-30  6:21           ` [PATCH v6 13/13] rootfs: Handle failures when postprocess is rerun Vijai Kumar K
2020-11-24 19:49   ` [PATCH v6 03/13] meta: cache deb srcs as part of postprocessing Baurzhan Ismagulov
2020-11-26 10:52     ` vijaikumar....@gmail.com
2020-11-26 11:03       ` Baurzhan Ismagulov
2020-11-26 11:07         ` vijaikumar....@gmail.com
2020-11-23 15:08 ` [PATCH v6 00/13] Deb-src caching vijaikumar....@gmail.com
2020-11-23 15:38   ` Jan Kiszka
2020-11-23 15:47     ` vijaikumar....@gmail.com
2020-11-24  5:41       ` Jan Kiszka
2020-11-24  6:30         ` vijaikumar....@gmail.com
2020-11-24 19:45 ` Baurzhan Ismagulov
2020-11-25  5:51   ` Jan Kiszka
2020-11-25  6:04   ` vijaikumar....@gmail.com
2020-11-25  6:48     ` Jan Kiszka
2020-11-25  7:16       ` vijaikumar....@gmail.com
2020-11-26 10:21     ` Baurzhan Ismagulov
2020-11-26 10:43       ` vijaikumar....@gmail.com [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=911cf383-3e22-4ca6-a1ac-55867327776cn@googlegroups.com \
    --to=vijaikumar.kanagarajan@gmail.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox