On Thursday, November 26, 2020 at 3:51:34 PM UTC+5:30 i...@radix50.net 
wrote:

> On Tue, Nov 24, 2020 at 10:04:24PM -0800, vijaikumar....@gmail.com wrote: 
> > You might want to set BASE_REPO_FEATURES ?= "cache-deb-src" in local 
> conf. 
> > By default its disabled. Not everyone 
> > want to cache the deb sources. It takes a lot of time. 
>
> Thanks Vijai Kumar, will play with v8. It's good to have this in the 
> manual. 
>
> What about the issues below? Should I include them myself? 
>

Oops. Sorry about that. I somehow missed to see these comments. I will 
address these in v9.

Thanks,
Vijai Kumar K
 

>
>
> p1: 
>
> On Tue, Nov 24, 2020 at 08:47:11PM +0100, Baurzhan Ismagulov wrote: 
> > On Wed, Sep 30, 2020 at 11:32:47AM +0530, Vijai Kumar K wrote: 
> > > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass 
> > > index afec1cb..eae14d5 100644 
> > > --- a/meta/classes/rootfs.bbclass 
> > > +++ b/meta/classes/rootfs.bbclass 
> > > @@ -201,45 +201,6 @@ rootfs_generate_manifest () { 
> > > ${ROOTFS_MANIFEST_DEPLOY_DIR}/"${PF}".manifest 
> > > } 
> > > 
> > > -ROOTFS_POSTPROCESS_COMMAND += 
> "${@bb.utils.contains('ROOTFS_FEATURES', 'finalize-rootfs', 
> 'rootfs_postprocess_finalize', '', d)}" 
> > 
> > Suggest also removing the 'finalize-rootfs' comment before 
> ROOTFS_FEATURES ?= 
> > "". 
>
>
> p3, p9: 
>
> On Tue, Nov 24, 2020 at 08:49:19PM +0100, Baurzhan Ismagulov wrote: 
> > On Wed, Sep 30, 2020 at 11:32:49AM +0530, Vijai Kumar K wrote: 
> > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass 
> > > index 2391529..6ca5759 100644 
> > > --- a/meta/classes/image.bbclass 
> > > +++ b/meta/classes/image.bbclass 
> > > @@ -63,7 +63,7 @@ image_do_mounts() { 
> > > } 
> > > 
> > > ROOTFSDIR = "${IMAGE_ROOTFS}" 
> > > -ROOTFS_FEATURES += "clean-package-cache generate-manifest" 
> > > +ROOTFS_FEATURES += "clean-package-cache generate-manifest 
> cach-deb-src" 
> > 
> > Should it be "cache-deb-src"? The same for p9. 
>
>
> With kind regards, 
> Baurzhan. 
>