From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7093814202197868544 X-Received: by 2002:a05:6512:1105:b0:477:b97f:4971 with SMTP id l5-20020a056512110500b00477b97f4971mr1759972lfg.87.1652872371620; Wed, 18 May 2022 04:12:51 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:651c:4ca:b0:24f:f52e:16e0 with SMTP id e10-20020a05651c04ca00b0024ff52e16e0ls3549529lji.3.gmail; Wed, 18 May 2022 04:12:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZfmGMblYMZBEuf7GD3uAe1g4h6yH9M5SNSx8SoWLq5tpLxys8NNMAQ77HI+DPpAGFU21L X-Received: by 2002:a2e:98d8:0:b0:253:cd20:f346 with SMTP id s24-20020a2e98d8000000b00253cd20f346mr625769ljj.28.1652872370468; Wed, 18 May 2022 04:12:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652872370; cv=none; d=google.com; s=arc-20160816; b=UJ3T0Fo+zqBl5BrvJesVi+p0LWgGsASLc2cEvsEImcoMoptuiW/UAg/UGvZh6hnvhW k6hbkxhfpLTWW5Fp/fV6qsMo/vZPHbGrlkY1Jho1XAqbI5tn0bRjNTf9Z2jBMxePb6Iv QblxIOYyn3HS7+Ovn48lY5b9wbu2P5ESAVY1CafILTvJW8zMO+cYynRVTgEE5+hUGvFD B3vmOrp7s6pndsWdeq4+rW6b838f/R2E2skPidBiHXb/W/vQyj9QXywMXotLrq1ZmCbt na9CVWQeMmw83k+SvJrRojotOzCooJ2NooeqPXy/2noiF4fFxzsygpUmA/B/KSrqfrIo XcFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id; bh=fEPdOGvCrGj1hvmNspo6ykSTVO6Ke7sr51npKqVBIZg=; b=RLlWyt2xKfIkdFMmmtXR/dLcE1HwTZd7Z4PcPGhpDUVGXRK8IXjDAwSmT6n7+M+YgX uygxpH9qii3faPj4aMk3pKKFV0XXZZs966d26Ce0r3q+vatp+aaCWCmDnQzdIsME3wuv lHzMW2uW+dOiFQaF7j7X89lcgZ1udmUudpvzhTBVXS9Y3P1W/UI82wWn7fMZEVxthocJ IXv1xTmnqPZBvdMztNGeGa+stoYjfehsEheSADWVDDWWCyTtc12ioBK7VhPMH+FnJ/53 5Ovir2OY3ET2Z+O5W4XTrno3hQLPPNl+4V8mdjX/cVT6f7X5NFUi4HCeO/1k/iA7Ygvm aWRQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id i4-20020a056512340400b004723ec9fc4asi90314lfr.0.2022.05.18.04.12.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 May 2022 04:12:50 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 24IBCl01001543 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 May 2022 13:12:49 +0200 Message-ID: <916167fc-72dd-a083-fa42-1a307c7afb54@ilbers.de> Date: Wed, 18 May 2022 14:12:47 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 1/1] fix: mount pts into rootfs Content-Language: en-US To: Felix Moessbauer , isar-users@googlegroups.com Cc: jan.kiszka@siemens.com, ibr@radix50.net References: <20220511093824.1118893-1-felix.moessbauer@siemens.com> <20220511093824.1118893-2-felix.moessbauer@siemens.com> From: Anton Mikanovich In-Reply-To: <20220511093824.1118893-2-felix.moessbauer@siemens.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: r4ilMZVYMM2S 11.05.2022 12:38, Felix Moessbauer wrote: > This fixes a regression introduced in 4e1dacc. > Pseudo ttys might be required during package building > as well as package installation > (e.g. to make expect work). > > The patch mounts /dev/pts from the host. > > Signed-off-by: Felix Moessbauer > --- > meta/classes/buildchroot.bbclass | 3 ++- > meta/classes/rootfs.bbclass | 3 ++- > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 2 ++ > 3 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/buildchroot.bbclass b/meta/classes/buildchroot.bbclass > index 3d2211b9..af391dff 100644 > --- a/meta/classes/buildchroot.bbclass > +++ b/meta/classes/buildchroot.bbclass > @@ -43,7 +43,8 @@ buildchroot_do_mounts() { > fi > mountpoint -q '${BUILDCHROOT_DIR}/dev' || > ( mount --bind /dev '${BUILDCHROOT_DIR}/dev' && > - mount -t tmpfs none '${BUILDCHROOT_DIR}/dev/shm' ) > + mount -t tmpfs none '${BUILDCHROOT_DIR}/dev/shm' && > + mount --bind /dev/pts '${BUILDCHROOT_DIR}/dev/pts' ) > mountpoint -q '${BUILDCHROOT_DIR}/proc' || > mount -t proc none '${BUILDCHROOT_DIR}/proc' > mountpoint -q '${BUILDCHROOT_DIR}/sys' || > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index 7e9fb0f3..2f4ea008 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -35,7 +35,8 @@ rootfs_do_mounts() { > set -e > mountpoint -q '${ROOTFSDIR}/dev' || \ > ( mount --bind /dev '${ROOTFSDIR}/dev' && > - mount -t tmpfs none '${ROOTFSDIR}/dev/shm' ) > + mount -t tmpfs none '${ROOTFSDIR}/dev/shm' && > + mount --bind /dev/pts '${ROOTFSDIR}/dev/pts' ) > mountpoint -q '${ROOTFSDIR}/proc' || \ > mount -t proc none '${ROOTFSDIR}/proc' > mountpoint -q '${ROOTFSDIR}/sys' || \ > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > index 6cc62a5e..7b4def14 100644 > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > @@ -370,6 +370,7 @@ do_bootstrap() { > > # update APT > mount --bind /dev ${ROOTFSDIR}/dev > + mount --bind /dev/pts ${ROOTFSDIR}/dev/pts > mount -t tmpfs none "${ROOTFSDIR}/dev/shm" > mount -t proc none ${ROOTFSDIR}/proc > mount --rbind /sys ${ROOTFSDIR}/sys > @@ -391,6 +392,7 @@ do_bootstrap() { > -o Debug::pkgProblemResolver=yes > > umount -l "${ROOTFSDIR}/dev/shm" > + umount -l "${ROOTFSDIR}/dev/pts" > umount -l "${ROOTFSDIR}/dev" > umount -l "${ROOTFSDIR}/proc" > umount -l "${ROOTFSDIR}/sys" Hello, It looks like we also have other issue caused by 4e1dacc with /dev/shm mounting. Here is an easy example for reproduce: $ bitbake mc:qemuamd64-bullseye:isar-bootstrap-target mc:qemuarm64-bullseye:isar-bootstrap-target mc:qemuarm-bullseye:isar-bootstrap-target sometimes fails with: | umount: /home/amikan/isar/build/tmp/work/debian-bullseye-arm64/isar-bootstrap-target/1.0-r0/rootfs/dev/shm: not mounted. ERROR: Task (mc:qemuarm64-bullseye:/home/amikan/isar/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb:do_bootstrap) failed with exit code '1' So there are 2 options: 1) revert 4e1dacc 2) fix also /dev/shm