Re: [PATCH v6 17/17] run-tests: add support for isar-rootless mode

[Zhihang Wei <wzh@ilbers.de>]

On 6/19/26 12:03, MOESSBAUER, Felix wrote:
> On Fri, 2026-06-19 at 11:08 +0200, Zhihang Wei wrote:
>> On 6/15/26 11:24, 'Felix Moessbauer' via isar-users wrote:
>>> If the testsuite is started in rootless mode (-p rootless=1), then start
>>> the container in rootless mode as well. By that, we can seamlessly
>>> switch between rootfull and rootless mode when testing.
>>>
>>> Note, that this requires a recent enough kas-container version (>5.3).
>>>
>>> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
>>> ---
>>>    scripts/run-tests.sh | 7 ++++++-
>>>    1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh
>>> index bce10d70..ed373af7 100755
>>> --- a/scripts/run-tests.sh
>>> +++ b/scripts/run-tests.sh
>>> @@ -15,4 +15,9 @@ TEST_CONTAINER_VERSION=$(cat ${ISAR_DIR}/testsuite/dockerdata/version)
>>>    export KAS_CONTAINER_IMAGE_DISTRO="container:$TEST_CONTAINER_VERSION"
>>>    export KAS_CONTAINER_IMAGE=${CONTAINER_BASENAME:-ghcr.io/ilbers/isar}/test
>>>    
>>> -${ISAR_DIR}/kas/kas-container --isar --repo-ro shell -c "$*"
>>> +ISAR_FLAG="--isar"
>>> +case "$*" in
>>> +    *"-p rootless=1"*) ISAR_FLAG="--isar-rootless" ;;
>>> +esac
>>> +
>>> +${ISAR_DIR}/kas/kas-container ${ISAR_FLAG} --repo-ro shell -c "$*"
>> "-p rootless=1" is also passed to avocado, seems unintended.
> This is intended as we manually need to tell isar to build in rootless
> mode. Please check p16:
>
> --- a/testsuite/cibuilder.py
> +++ b/testsuite/cibuilder.py
> @@ -128,6 +128,7 @@ class CIBuilder(Test):
>           customizations=None,
>           generate_sbom=False,
>           lines=None,
> +        rootless=False,
>           **kwargs,
>       ):
>           # write configuration file and set bitbake_args
> @@ -140,6 +141,9 @@ class CIBuilder(Test):
>           if not sstate:
>               sstate = bool(int(self.params.get('sstate', default=0)))
>   
> +        if not rootless:
> +            rootless = bool(int(self.params.get('rootless',
> default=0)))

Understand.

>> isar$ scripts/run-tests.sh -t dev -p rootless=1
>> + avocado run --max-parallel-tasks=1 --disable-sysinfo -t dev -p
>> rootless=1 testsuite/citest.py
> This will not work, as this starts the container in rootless mode, but
> the build in privileged mode (which also explains the error pattern
> from the other mail).

But why would this not work? I can see from the Avocado test log:

[stdlog] 2026-06-1916:17:36,287avocado.testparameters L0141 DEBUG| 
PARAMS (key=rootless, path=*, default=0) => '1'
[stdlog] 2026-06-1916:17:36,287avocado.testcibuilder L0164 INFO| 
===================================================
......
[stdlog] rootless = True
......

So the build is done in rootless mode.

Or could you share how you are testing it? Thanks.

Zhihang

> Felix

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/91bf1599-1a36-416f-9c8f-df48223d7145%40ilbers.de.