public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Anton Mikanovich <amikan@ilbers.de>,
	Nicu Liviu Huhulea <nicusor.huhulea@gmail.com>,
	isar-users <isar-users@googlegroups.com>,
	Ilia Skochilov <iskochilov@ilbers.de>
Subject: Re: [PATCH] Fix do_copy_boot_files error
Date: Mon, 12 Feb 2024 10:20:49 +0100	[thread overview]
Message-ID: <92041b3c-1e7a-435a-8e35-113998ddf28e@siemens.com> (raw)
In-Reply-To: <0a2d2db0-785d-4efc-90e2-4924ca07f483@ilbers.de>

On 12.02.24 08:58, Anton Mikanovich wrote:
> 09/02/2024 14:21, Nicu Liviu Huhulea wrote:
>> Hello,
>>
>> It seems that I get the same behavior, but with other steps: having 2
>> images that uses the same dtbs for booting. First image will complete
>> the build fine and the dtbs are in the deploydir.
>> The 2nd image does not complete the build because the dtbs are already
>> in the deploydir.
>> This happens because of the introduction of the
>> do_copy_boot_files_setscene() where this verification takes place.
>> From my perspective a possible solution would be to copy those files
>> only if they don't exist.
> 
> Hello,
> This approach will not work if two dtbs with the same name will have any
> changes.
> Two different distro versions (with different kernel versions) may have
> different dtbs but with the same name.
> That's why we need to separate them any in case.

Separation is not wrong but also does not solve the issue when
rebuilding into a dirty deploy dir with a different config for the same
machine/distro.

Jan

-- 
Siemens AG, Technology
Linux Expert Center


      reply	other threads:[~2024-02-12  9:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 14:44 Ilia Skochilov
2024-02-09 12:21 ` Nicu Liviu Huhulea
2024-02-12  7:58   ` Anton Mikanovich
2024-02-12  9:20     ` Jan Kiszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92041b3c-1e7a-435a-8e35-113998ddf28e@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    --cc=iskochilov@ilbers.de \
    --cc=nicusor.huhulea@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox