Re: [PATCH v2 0/9] Avoid using shell environment during the build

[Jan Kiszka <jan.kiszka@siemens.com>]

On 25.01.22 14:51, Uladzimir Bely wrote:
> In the email from вторник, 25 января 2022 г. 16:29:28 +03 user Jan Kiszka
> wrote:
>> On 25.01.22 13:32, Uladzimir Bely wrote:
>>> This patchset is a subseries of 'Sbuild/Schroot migration' patchset
>>> including only preparation patches. It doesn't require any changes
>>> in host machine configuration for downstreams (meta-iot2050 and
>>> xenomai-images were tested) so can be merged independently.
>>>
>>> In this patchset the main topic is a migration to template files that
>>> allows to use cleaner build environment.
>>>
>>> When this patchset is merged, it will make maintenance of remaining
>>> sbuild-related patches easier and will shorten their number.
>>>
>>> Changes since v1:
>>> - Introduced `dpkg_build_export` function to be used for passing
>>> variables to build environment;
>>
>> I wonder - as just written in the iot2050 PR - if we have any chance to
>> detect old exports and warn the user if their recipes need to be
>> converted to dpkg_build_export. Any ideas?
>>
>> Jan
>>
> 
> That's an interesting question. If we could make a hook that could intercept
> any 'export' call in dpkg_runbuild (usually, in _prepend), we could make a
> warning. On the other hand, in this case we could not introduce a new
> function, but just do what we really need instead of doing shell export.
> 
> For now I have no ideas how we could do it.
> 

Maybe a hook at the beginning of that task which collects the 
environment and one at the end that does that again, checking for 
additionally exported vars?

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux