From: Uladzimir Bely <ubely@ilbers.de>
To: isar-users@googlegroups.com
Cc: Henning Schild <henning.schild@siemens.com>
Subject: Re: [PATCH v2 3/4] CI: install qemu-system when qemu testing is requested
Date: Sat, 14 Jan 2023 23:15:54 +0300 [thread overview]
Message-ID: <92997740.IzOArtZ34E@home> (raw)
In-Reply-To: <20230112235929.1437-4-henning.schild@siemens.com>
In the email from Friday, 13 January 2023 02:59:28 +03 user Henning Schild
wrote:
> And also change gitlab ci config to request qemu testing.
>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
> .gitlab-ci.yml | 2 +-
> scripts/ci_build.sh | 5 +++++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index fcdefa87bf66..dc8a01b9d1d6 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -27,7 +27,7 @@ fast-ci:
> except:
> - schedules
> script:
> - - scripts/ci_build.sh -q -f -n
> + - scripts/ci_build.sh -q -f
>
> full-ci:
> <<: *common-build
> diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh
> index e5f20d4f0a1f..1704ec17af89 100755
> --- a/scripts/ci_build.sh
> +++ b/scripts/ci_build.sh
> @@ -127,6 +127,11 @@ fi
>
> if [ -n "$NORUN" ]; then
> TAGS="$TAGS,-startvm"
> +else
> + if ! command -v qemu-system-x86 > /dev/null; then
> + sudo apt-get update -qq
> + sudo apt-get install -y qemu-system
This seems to be incorrect. In our CI chroot we have `qemu-system-x86_64` and
`/usr/bin/qemu-system-i386` (among other archs), but not `-x86` one. So, the
check always fails and apt-get is always called (with "qemu-system is already
the newest version" message from apt).
> + fi
> fi
>
> # Provide working path
next prev parent reply other threads:[~2023-01-14 20:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 23:59 [PATCH v2 0/4] CI rework of gitlab fast job Henning Schild
2023-01-12 23:59 ` [PATCH v2 1/4] CI: move to avocado to 99.0 Henning Schild
2023-01-12 23:59 ` [PATCH v2 2/4] CI: fix shell coding style Henning Schild
2023-01-12 23:59 ` [PATCH v2 3/4] CI: install qemu-system when qemu testing is requested Henning Schild
2023-01-14 20:15 ` Uladzimir Bely [this message]
2023-01-23 8:51 ` Henning Schild
2023-01-24 20:53 ` Anton Mikanovich
2023-01-12 23:59 ` [PATCH v2 4/4] testsuite: remove tests from "fast" set Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92997740.IzOArtZ34E@home \
--to=ubely@ilbers.de \
--cc=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox