Re: [PATCH v4 0/6] Python refactoring

["Maxim Yu. Osipov" <mosipov@ilbers.de>]

Hi Claudius,

On 3/4/19 5:21 PM, Claudius Heine wrote:
> Hi,
> 
> On 04/03/2019 14.07, [ext] claudius.heine.ext@siemens.com wrote:
>> From: Claudius Heine <ch@denx.de>
>>
>> Hi,
>>
>> I just took Haralds patchset + Maxims rebase and fixed it up.
>>
>> There was just a tiny change necessary, I added that in an additional 
>> patch.
>> It builds on my machine (qemuamd64) and I am currently testing it on 
>> isar-ci.
> 
> Ok I run this patchset two times on the isar-ci now. The exact same 
> commit id failed the first time after ~10 minutes [1] and will go green 
> the second time [2] (Not completely finished yet, but it looks good so 
> far after 1h50m.)
> 
> We really should fix the nondeterminism in the CI.

 From the first glance the error caused build failure was

E: Couldn't download packages: locales

How are you going to fix such "non-determinism"?

Regards,
Maxim.

> 
> regards,
> Claudius
> 
> [1] http://isar-build.org:8080/job/isar_claudius_ilbers-ci/22/
> [2] http://isar-build.org:8080/job/isar_claudius_ilbers-ci/23/
> 
>>
>> If that is successful and review is ok, my patch can be merged into the
>> 'Remove all uses of subprocess.call(shell=True)' or left separately.
>>
>> regards,
>> Claudius
>>
>> Claudius Heine (1):
>>    isar-bootstrap-helper: get_deb_host_arch: fix decoding
>>
>> Harald Seiler (5):
>>    Remove all uses of subprocess.call(shell=True)
>>    Use modern python formatting
>>    image: Remove recursion in get_image_name
>>    wic: Refactor fakeroot script
>>    Fix python style
>>
>>   .../example-module/example-module.bb          |  8 ++-
>>   meta/classes/base.bbclass                     | 70 ++++++++++++-------
>>   meta/classes/image.bbclass                    | 22 ++++--
>>   meta/classes/isar-bootstrap-helper.bbclass    |  8 +--
>>   meta/classes/isar-events.bbclass              | 14 ++--
>>   meta/classes/patch.bbclass                    | 13 ++--
>>   meta/classes/wic-img.bbclass                  | 21 ++++--
>>   .../isar-bootstrap/isar-bootstrap-host.bb     |  9 ++-
>>   .../isar-bootstrap/isar-bootstrap-target.bb   |  5 +-
>>   .../isar-bootstrap/isar-bootstrap.inc         | 12 ++--
>>   scripts/wic_fakeroot                          |  9 +--
>>   11 files changed, 120 insertions(+), 71 deletions(-)
>>
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov