public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Clara Kowalsky' via isar-users" <isar-users@googlegroups.com>
To: "Heinisch,
	Alexander (FT RPD CED SES-AT)" <alexander.heinisch@siemens.com>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Cc: "Bezdeka, Florian (FT RPD CED OES-DE)" <florian.bezdeka@siemens.com>
Subject: Re: [PATCH] installer: only include wic.bmap for IMAGE_DATA_POSTFIX wic
Date: Wed, 29 Jul 2026 12:47:28 +0200	[thread overview]
Message-ID: <933621e4-6ee7-4ab2-87c2-bf73459f0c2c@siemens.com> (raw)
In-Reply-To: <fadbe73b20f24e475e818f467235bc21be25caed.camel@siemens.com>



On 7/27/26 15:57, Heinisch, Alexander (FT RPD CED SES-AT) wrote:
> On Fri, 2026-07-24 at 11:16 +0200, 'Clara Kowalsky' via isar-users
> wrote:
>> If a target image type other than wic is added to the installer's
> 
> Can you rephrase the commit message, so it's clear that wic.xz,
> wic.zst, aso. remain valid options for bmap file copying?

Done, sent v2. Thanks for pointing out.
BR,
Clara
> 
>> rootfs, there is no corresponding wic.bmap file. Add the wic.bmap to
>> the
>> rootfs only if the IMAGE_DATA_POSTFIX is wic.
>>
>> Signed-off-by: Clara Kowalsky <clara.kowalsky@siemens.com>
>> ---
>>   meta-isar/classes-recipe/installer-add-rootfs.bbclass | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta-isar/classes-recipe/installer-add-rootfs.bbclass
>> b/meta-isar/classes-recipe/installer-add-rootfs.bbclass
>> index 111506df..c4921bc6 100644
>> --- a/meta-isar/classes-recipe/installer-add-rootfs.bbclass
>> +++ b/meta-isar/classes-recipe/installer-add-rootfs.bbclass
>> @@ -58,6 +58,7 @@ def get_mc_depends(d, task):
>>   
>>   python() {
>>       entries = []
>> +    image_data_postfix = d.getVar("IMAGE_DATA_POSTFIX") or ""
>>   
>>       def add_entries(postfix, suffix):
>>           sources = get_installer_sources(d, suffix)
>> @@ -70,8 +71,9 @@ python() {
>>               d.setVarFlag(var, "source", src)
>>               d.setVarFlag(var, "destination", dst)
>>   
>> -    add_entries("", d.getVar("IMAGE_DATA_POSTFIX"))
>> -    add_entries("-bmap", "wic.bmap")
>> +    add_entries("", image_data_postfix)
>> +    if image_data_postfix.startswith("wic"):
>> +        add_entries("-bmap", "wic.bmap")
>>   
>>       d.setVar("ROOTFS_ADDITIONAL_FILES", " ".join(entries))
>>   }
>> -- 
>> 2.54.0
> 

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/933621e4-6ee7-4ab2-87c2-bf73459f0c2c%40siemens.com.

      reply	other threads:[~2026-07-29 10:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24  9:16 'Clara Kowalsky' via isar-users
2026-07-27 13:57 ` 'Heinisch, Alexander' via isar-users
2026-07-29 10:47   ` 'Clara Kowalsky' via isar-users [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=933621e4-6ee7-4ab2-87c2-bf73459f0c2c@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=alexander.heinisch@siemens.com \
    --cc=clara.kowalsky@siemens.com \
    --cc=florian.bezdeka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox