From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 25 Oct 2024 15:58:05 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-wm1-f61.google.com (mail-wm1-f61.google.com [209.85.128.61]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 49PDvwjS023791 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 25 Oct 2024 15:57:58 +0200 Received: by mail-wm1-f61.google.com with SMTP id 5b1f17b1804b1-4316ac69e6dsf16150595e9.0 for ; Fri, 25 Oct 2024 06:57:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1729864672; cv=pass; d=google.com; s=arc-20240605; b=TxdBGSP9aNwNMqVZ2H9olWUCxg7UvRtNORI6uJdFRpjBgFX8xKt8aBgAp95JDQEcsR N+B33oBh/5DIh4WFlm/R2TOvzzqsNDiB1WjjyNN797LXOcHB7hoJTHXzoExbuwkuTpc5 piloD031NW97joZsQJRSa+By40FkOq9pEAbGz7LAQhNkjhVS8dUOqyv651QBqdw0rAHy JdsraGD3nTauOUUUrZ6piTE7auT4pa3bkznWDYOFKFrHXnfqlCNcQ2bqJQpXF08lcH9r 9lH812SQlBc71VT/mo13XHZ0EURAJwKNu3ZyeqLZRXdJ/hk6PnAN5ZiAuleZo8Re0rzJ Y2Nw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:to:from :subject:message-id:sender:dkim-signature; bh=nWuRSl3fNzH//v1ZumgXmBzFpRz/4DkOSh6POETqYYU=; fh=R/M0zs0V8by9+K6ej6Sm3GnkWIvUVR/GbnRdl2G5DRQ=; b=YSQda+uHys/qLOWEYoKo0vkfxJ65K5VZOW4kf2TCdOzHcfmTAKTcdqmf5H946qZhzx /4uM2ToVt6zc4Wi6+jSjjIF2EhSgFetK0iHvuVVdtjrkLnWo+GuyWPwz9oTeVMXQxqUO 1myNbEKwLzj5K8mLlCURrIODEYR/ArmuNUkQjoxpGfhe9nmRuEDo1VcTryKQUasXXgog F2ogQ8CCaKxijgBbGrTeKVP4fS5Agba964HAp1SlU1fFZTdFU/HGEtSagkDQlWFZBJ8Q jWSGzI/CBu0L2oPSqajnuHcjTNOFaup7wmxtUG0cZKcs3g8n0xnqaxrVijCRDcMTNpt8 3Iaw==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1729864672; x=1730469472; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:user-agent:content-transfer-encoding :references:in-reply-to:date:to:from:subject:message-id:sender:from :to:cc:subject:date:message-id:reply-to; bh=nWuRSl3fNzH//v1ZumgXmBzFpRz/4DkOSh6POETqYYU=; b=KeFiRGW442XeDXQaS02A2bauPszEpZG5pjCHh7P8tV7g6Dc8FcdYmwN+IOVZ06q3aL Dg8WQYxE+jSi5bfjJhohXqRdrFmu/ZLn9GTkbwoty9Mc412dNU432Vnu4DaE57Ve5/u+ bqJboKdTebIh3zRzbVEGcr5/tUP4TePVeJQ2iurwtWqVsU4KD1Fq1VvC72Eh5inhwZJh eiv+DkBVUoNOED2VDN8EFGuLPlinv6L5FeGkNtJECKtRrEtwSjCq7z16JxMtmjW9oS2k p5KJ/e1Lnzf7HlC4uAFVmPnFvhF/yOo/ZjZR/iG8icYuyX/arXk9qOp9SrEFql/GA2Nt g9bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729864672; x=1730469472; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :user-agent:content-transfer-encoding:references:in-reply-to:date:to :from:subject:message-id:x-beenthere:x-gm-message-state:sender:from :to:cc:subject:date:message-id:reply-to; bh=nWuRSl3fNzH//v1ZumgXmBzFpRz/4DkOSh6POETqYYU=; b=AITSQ0jsY5oTGOOQg0/iua8tLA9hmp6XcTDsDRBCUhHfzlL9/qm4XlYXyxxjEqQSB3 5oS8tlKAiFtKLZnVc8f23j6oVPtzY1J+bwGAwmfMMT7ex3VGT/cO7BfSkoNCkF3CcIM+ 6/fbvmP7hNkmfFw4uMZr3gzPVONWUV6mT/PXR6AzYRD3c1GgRfDBAc0ItKIWVrEGwRiX Kyz7Az89tp8M0hNibwDinvZkkvu9WHouB9XY5CdXfe/JKjoSFpEHmH5GJDvYpFAfN//e 0esxR4LfzeNh68oreyfv3igWEE0XTP3iCYuTB1S3bX4+cmg+ewbFrr+Fug/r1NASvb/N 09Lg== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCWkiIEmsn3qHSNwFq5KgDzhewe3n7HEPSeam8oUrhfaHNMbFAV6gQLYxCp9RyP1s548o8/v@ilbers.de X-Gm-Message-State: AOJu0YyvzFaMJWNnvn2ETekjbv2f21qepoA5ZOtlYn9Xx9LT/lICNqYv 7vDsdjUeCEk+RfE3vVO/n1KU06GQya5tH8hOVlf/w+ykXqWmX+E7 X-Google-Smtp-Source: AGHT+IFrrnhJ0fg/oPhoTGlk0GVgcqlL28cQv+fUEenqUn9ht8PHKLn/LKbDTeTkXOFDv6OyzbTPdw== X-Received: by 2002:a05:600c:4e91:b0:431:5d4f:73a3 with SMTP id 5b1f17b1804b1-4318c705ef8mr40371845e9.18.1729864671214; Fri, 25 Oct 2024 06:57:51 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:4203:b0:431:9388:1f54 with SMTP id 5b1f17b1804b1-43193882198ls2874825e9.2.-pod-prod-09-eu; Fri, 25 Oct 2024 06:57:49 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVo74KDlQKE6mRLvmq5HJxwQ7OfXJIVeu70g4JtpEFFGP+nMZvDzjhUcg3TCNda/eFvPQ4KCjjzMr4j@googlegroups.com X-Received: by 2002:a05:600c:1d98:b0:430:5356:ac92 with SMTP id 5b1f17b1804b1-4318c6e8ad6mr48897255e9.7.1729864669027; Fri, 25 Oct 2024 06:57:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729864669; cv=none; d=google.com; s=arc-20240605; b=IQTmWKmWNeosfPvLnHqPjo0YHUpgg+lencNp78oO61FJR9DlncJYlYjQwXFTlPaqom frcPuBaH+NZ9meH70q6Vdnjj1unS6Ye8CdJu6vym3KCFgvduJzgPa8BkNZnrfI6yrF7j Ag0JfN59c7DpAt9mazZOLoboeDfYhEDmOTSNnX6DezPYosEM9OZjdInGuLhTiHDCGhh6 Z56DD0drjRii9FaNMAdJ1qLDPEhDRYTCDVXbMKP4IRjcPLTbZQxJprwZ5Y/G13ZUKunR wlg8gz0Zeg12as70z5+TZpICMBC5jp4r3M0d+I6eQ+mLfnUn2NVE6bcN33ecuLw/4MuO 1mbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id; bh=c3xkvNXukjt9/MoEc+xu6J+rL+KdOB7i1VmnE/jfyMc=; fh=JZvUnqoG0jWph92hWpw0EINycbLveqkIcdkusZDYok4=; b=Z/+BOKAkaeDNJX7fh0JykK4PpbnOGyY2KpXAYWlXc5ypUHcUpTNvYI5qHz1XhNXiWH EYANXWnCYkYPD8b3pI/6am5cHxLeXv8W0k6ivlt3Hpwqhp8fhkd6lqI74/u3GSYMFLW1 rmPp1xBTW49CMiGUAU8bXyqvEch0TJ61XBwXroKUIwd+mwlZELhR6hjUxIPtWVTvYPsR dDw/I5B5Gu+JD8gf5cPq8Dc924UHU+RxuReu84oEafwQ9J8HOT2j1I+6qMVbIpgTkvBr i3yublbnMq9bXrCttOtk+rbSchcsXolAuK7XzI86avkN0LobzrPVX9WbnbA/zYRlmw90 OLHg==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 5b1f17b1804b1-4317d02bc69si5734925e9.0.2024.10.25.06.57.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Oct 2024 06:57:48 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 49PDvjQh023779 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 25 Oct 2024 15:57:47 +0200 Message-ID: <93beef8a0a8e736e3746a955829e5b8c9650c940.camel@ilbers.de> Subject: Re: [PATCH v2] deb-dl-dir: Avoid hanging mounts on failed download From: Uladzimir Bely To: Anton Mikanovich , isar-users@googlegroups.com Date: Fri, 25 Oct 2024 16:57:45 +0300 In-Reply-To: <20241024100946.214428-1-amikan@ilbers.de> References: <20241024100946.214428-1-amikan@ilbers.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.0 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: ubely@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: WR62kcZ4HG9i On Thu, 2024-10-24 at 13:09 +0300, Anton Mikanovich wrote: > If apt-get fails during debsrc_download execution, one mount will be > left behind. If ISAR_FAIL_ON_CLEANUP is set to 1, an additional error > will be observed: >=20 > > Err:1 http://ftp.de.debian.org/debian=C2=A0bookworm/main rtmpdump > > 2.4+20151223.gitfa8646d.1-2 (dsc) > > =C2=A0 Could not connect to ftp.de.debian.org:80=C2=A0(141.76.2.4), > > connection timed out > > Err:2 http://ftp.de.debian.org/debian=C2=A0bookworm/main rtmpdump > > 2.4+20151223.gitfa8646d.1-2 (tar) > > =C2=A0 Unable to connect to ftp.de.debian.org:80: > > Err:3 http://ftp.de.debian.org/debian=C2=A0bookworm/main rtmpdump > > 2.4+20151223.gitfa8646d.1-2 (diff) > > =C2=A0 Unable to connect to ftp.de.debian.org:80: > > E: Failed to fetch > > http://ftp.de.debian.org/debian/pool/main/r/rtmpdump/rtmpdump_2.4%2b201= 51223.gitfa8646d.1-2.dsc > > =C2=A0 Could not connect to ftp.de.debian.org:80=C2=A0(141.76.2.4), > > connection timed out > > E: Failed to fetch > > http://ftp.de.debian.org/debian/pool/main/r/rtmpdump/rtmpdump_2.4%2b201= 51223.gitfa8646d.1.orig.tar.gz > > =C2=A0 Unable to connect to ftp.de.debian.org:80: > > E: Failed to fetch > > http://ftp.de.debian.org/debian/pool/main/r/rtmpdump/rtmpdump_2.4%2b201= 51223.gitfa8646d.1-2.debian.tar.xz > > =C2=A0 Unable to connect to ftp.de.debian.org:80: > > E: Failed to fetch some archives. > > WARNING: exit code 100 from a shell command. > > DEBUG: Executing shell function rootfs_do_umounts > > DEBUG: Shell function rootfs_do_umounts finished > > DEBUG: Python function do_rootfs_postprocess finished > NOTE: recipe isar-image-ci-1.0-r0: task do_rootfs_postprocess: Failed > NOTE: Tasks Summary: Attempted 699 tasks of which 391 didn't need to > be rerun and 1 failed. > ERROR: build/tmp/work/debian-bookworm-armhf/isar-image-ci- > qemuarm/1.0-r0/rootfs/deb-src left mounted >=20 > Protect mounting with a trap for cleanup in case of failure. >=20 > Signed-off-by: Anton Mikanovich > --- > =C2=A0meta/classes/deb-dl-dir.bbclass | 3 +++ > =C2=A01 file changed, 3 insertions(+) >=20 > diff --git a/meta/classes/deb-dl-dir.bbclass b/meta/classes/deb-dl- > dir.bbclass > index 55e56c50..7ebd057e 100644 > --- a/meta/classes/deb-dl-dir.bbclass > +++ b/meta/classes/deb-dl-dir.bbclass > @@ -48,6 +48,9 @@ debsrc_download() { > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0 debsrc_do_mounts "${rootfs}" > =C2=A0 > +=C2=A0=C2=A0=C2=A0 trap 'exit 1' INT HUP QUIT TERM ALRM USR1 > +=C2=A0=C2=A0=C2=A0 trap 'debsrc_undo_mounts "${rootfs}"' EXIT > + > =C2=A0=C2=A0=C2=A0=C2=A0 ( flock 9 > =C2=A0=C2=A0=C2=A0=C2=A0 set -e > =C2=A0=C2=A0=C2=A0=C2=A0 printenv | grep -q BB_VERBOSE_LOGS && set -x > --=20 > 2.34.1 >=20 Applied to next. --=20 Best regards, Uladzimir. --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/= 93beef8a0a8e736e3746a955829e5b8c9650c940.camel%40ilbers.de.