From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6621956091070644224 Date: Tue, 13 Nov 2018 02:43:44 -0800 (PST) From: chombourger@gmail.com To: isar-users Message-Id: <93fdfb3c-d759-4157-a269-f7f4987d581d@googlegroups.com> In-Reply-To: <1542085173-650-2-git-send-email-Cedric_Hombourger@mentor.com> References: <20181112103125.6884a9af@md1za8fc.ad001.siemens.net> <1542085173-650-1-git-send-email-Cedric_Hombourger@mentor.com> <1542085173-650-2-git-send-email-Cedric_Hombourger@mentor.com> Subject: Re: [PATCH v3 2/2] buildchroot: add sysfs mount since expected by some packages MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_2326_1663618771.1542105825114" X-Google-Token: EODVqt8F9D3f5psVXBM0 X-Google-IP: 192.94.31.2 X-TUID: VBLKp2+iP4D3 ------=_Part_2326_1663618771.1542105825114 Content-Type: multipart/alternative; boundary="----=_Part_2327_821411428.1542105825115" ------=_Part_2327_821411428.1542105825115 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hello all, While testing this patch series further in a more complex environment, I noticed some build errors that I did not get with pristine Isar builds. The build logs show mkstemp being called in the buildchroot'ed environment and failing to find /tmp. Gentoo's guide was also bind mounting /tmp I am however unclear on why this shows up with this particular change. Cedric On Monday, November 12, 2018 at 8:59:49 PM UTC-8, Cedric Hombourger wrote: > > Some packages look for /sys when they configure, build or test themselves > (for > instance golang-google-grpc). > > Signed-off-by: Cedric Hombourger > > --- > meta/classes/buildchroot.bbclass | 2 ++ > meta/classes/image.bbclass | 1 + > meta/classes/isar-bootstrap-helper.bbclass | 3 +++ > meta/classes/isar-image.bbclass | 1 + > 4 files changed, 7 insertions(+) > > diff --git a/meta/classes/buildchroot.bbclass > b/meta/classes/buildchroot.bbclass > index 26d5e80..d2f138f 100644 > --- a/meta/classes/buildchroot.bbclass > +++ b/meta/classes/buildchroot.bbclass > @@ -31,5 +31,7 @@ buildchroot_do_mounts() { > mount --make-rslave ${BUILDCHROOT_DIR}/dev > mount --rbind /proc ${BUILDCHROOT_DIR}/proc > mount --make-rslave ${BUILDCHROOT_DIR}/proc > + mount --rbind /sys ${BUILDCHROOT_DIR}/sys > + mount --make-rslave ${BUILDCHROOT_DIR}/sys > fi' > } > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index d033cf5..5806a59 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -110,6 +110,7 @@ do_populate_sdk() { > > sudo umount ${SDKCHROOT_DIR}/rootfs/dev || true > sudo umount ${SDKCHROOT_DIR}/rootfs/proc || true > + sudo umount ${SDKCHROOT_DIR}/rootfs/sys || true > > # Create SDK archive > sudo tar -C ${SDKCHROOT_DIR} > --transform="s|^rootfs|sdk-${DISTRO}-${DISTRO_ARCH}|" \ > diff --git a/meta/classes/isar-bootstrap-helper.bbclass > b/meta/classes/isar-bootstrap-helper.bbclass > index 62c0839..7b2ddf3 100644 > --- a/meta/classes/isar-bootstrap-helper.bbclass > +++ b/meta/classes/isar-bootstrap-helper.bbclass > @@ -107,6 +107,9 @@ setup_root_file_system() { > sudo mount --make-rslave ${ROOTFSDIR}/dev > sudo mount --rbind /proc ${ROOTFSDIR}/proc > sudo mount --make-rslave ${ROOTFSDIR}/proc > + sudo install -m 755 -d ${ROOTFSDIR}/sys > + sudo mount --rbind /sys ${ROOTFSDIR}/sys > + sudo mount --make-rslave ${ROOTFSDIR}/sys > > # Install packages: > E="${@ bb.utils.export_proxies(d)}" > diff --git a/meta/classes/isar-image.bbclass > b/meta/classes/isar-image.bbclass > index e0508be..356c97a 100644 > --- a/meta/classes/isar-image.bbclass > +++ b/meta/classes/isar-image.bbclass > @@ -61,6 +61,7 @@ isar_image_cleanup() { > sudo rmdir ${IMAGE_ROOTFS}/isar-apt > sudo umount -l ${IMAGE_ROOTFS}/dev > sudo umount -l ${IMAGE_ROOTFS}/proc > + sudo umount -l ${IMAGE_ROOTFS}/sys > sudo rm -f "${IMAGE_ROOTFS}/etc/apt/apt.conf.d/55isar-fallback.conf" > } > > -- > 2.11.0 > > ------=_Part_2327_821411428.1542105825115 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Hello all,

While testing this patch ser= ies further in a more complex environment, I noticed some build errors that= I did not get with pristine Isar builds.
The build logs show mks= temp being called in the buildchroot'ed environment and failing to find= /tmp. Gentoo's guide was also bind mounting /tmp
I am howeve= r unclear on why this shows up with this particular change.

<= /div>
Cedric

On Monday, November 12, 2018 at 8:59:49 PM UTC-8, C= edric Hombourger wrote:
Some pa= ckages look for /sys when they configure, build or test themselves (for
instance golang-google-grpc).

Signed-off-by: Cedric Hombourger <Cedric_H...@mentor.com>
---
=C2=A0meta/classes/buildchroot.bbclass =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 | 2 ++
=C2=A0meta/classes/image.bbclass =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 | 1 +
=C2=A0meta/classes/isar-bootstrap-helper.bbclass | 3 +++
=C2=A0meta/classes/isar-image.bbclass =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0| 1 +
=C2=A04 files changed, 7 insertions(+)

diff --git a/meta/classes/buildchroot.bbclass b/meta/classes/build= chroot.bbclass
index 26d5e80..d2f138f 100644
--- a/meta/classes/buildchroot.bbclass
+++ b/meta/classes/buildchroot.bbclass
@@ -31,5 +31,7 @@ buildchroot_do_mounts() {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0mount --make-rslave ${B= UILDCHROOT_DIR}/dev
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0mount --rbind /proc ${B= UILDCHROOT_DIR}/proc
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0mount --make-rslave ${B= UILDCHROOT_DIR}/proc
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0mount --rbind /sys ${BUILDCH= ROOT_DIR}/sys
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0mount --make-rslave ${BUILDC= HROOT_DIR}/sys
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fi'
=C2=A0}
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index d033cf5..5806a59 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -110,6 +110,7 @@ do_populate_sdk() {
=C2=A0
=C2=A0 =C2=A0 =C2=A0sudo umount ${SDKCHROOT_DIR}/rootfs/dev || true
=C2=A0 =C2=A0 =C2=A0sudo umount ${SDKCHROOT_DIR}/rootfs/proc || true
+ =C2=A0 =C2=A0sudo umount ${SDKCHROOT_DIR}/rootfs/sys || true
=C2=A0
=C2=A0 =C2=A0 =C2=A0# Create SDK archive
=C2=A0 =C2=A0 =C2=A0sudo tar -C ${SDKCHROOT_DIR} --transform=3D"s|= ^rootfs|sdk-${DISTRO}-${DISTRO_ARCH}|" \
diff --git a/meta/classes/isar-bootstrap-helper.bbclass b/meta/cla= sses/isar-bootstrap-helper.bbclass
index 62c0839..7b2ddf3 100644
--- a/meta/classes/isar-bootstrap-helper.bbclass
+++ b/meta/classes/isar-bootstrap-helper.bbclass
@@ -107,6 +107,9 @@ setup_root_file_system() {
=C2=A0 =C2=A0 =C2=A0sudo mount --make-rslave ${ROOTFSDIR}/dev
=C2=A0 =C2=A0 =C2=A0sudo mount --rbind /proc ${ROOTFSDIR}/proc
=C2=A0 =C2=A0 =C2=A0sudo mount --make-rslave ${ROOTFSDIR}/proc
+ =C2=A0 =C2=A0sudo install -m 755 -d ${ROOTFSDIR}/sys
+ =C2=A0 =C2=A0sudo mount --rbind /sys ${ROOTFSDIR}/sys
+ =C2=A0 =C2=A0sudo mount --make-rslave ${ROOTFSDIR}/sys
=C2=A0
=C2=A0 =C2=A0 =C2=A0# Install packages:
=C2=A0 =C2=A0 =C2=A0E=3D"${@ bb.utils.export_proxies(d)}"
diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-i= mage.bbclass
index e0508be..356c97a 100644
--- a/meta/classes/isar-image.bbclass
+++ b/meta/classes/isar-image.bbclass
@@ -61,6 +61,7 @@ isar_image_cleanup() {
=C2=A0 =C2=A0 =C2=A0sudo rmdir ${IMAGE_ROOTFS}/isar-apt
=C2=A0 =C2=A0 =C2=A0sudo umount -l ${IMAGE_ROOTFS}/dev
=C2=A0 =C2=A0 =C2=A0sudo umount -l ${IMAGE_ROOTFS}/proc
+ =C2=A0 =C2=A0sudo umount -l ${IMAGE_ROOTFS}/sys
=C2=A0 =C2=A0 =C2=A0sudo rm -f "${IMAGE_ROOTFS}/etc/apt/apt.c= onf.d/55isar-fallback.conf"
=C2=A0}
=C2=A0
--=20
2.11.0

------=_Part_2327_821411428.1542105825115-- ------=_Part_2326_1663618771.1542105825114--