From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6517147827419742208 X-Received: by 10.25.201.208 with SMTP id z199mr2345030lff.2.1517399006867; Wed, 31 Jan 2018 03:43:26 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.21.76 with SMTP id 12ls529996ljv.5.gmail; Wed, 31 Jan 2018 03:43:26 -0800 (PST) X-Google-Smtp-Source: AH8x227uBX6uxO/L0NFbogBZlYB4HSBsKSONcrqGlFsl8KW1ZeySZwBItmS/diMc3dhj9Plwf7K5 X-Received: by 10.25.16.228 with SMTP id 97mr2330630lfq.43.1517399006153; Wed, 31 Jan 2018 03:43:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517399006; cv=none; d=google.com; s=arc-20160816; b=J+eq/LtqEu4O42LTahbxSJ5GmKTp2CWfteBmXhcmbVjuHJMRCD8CukZ9KIqwlE7JI4 CdKs+2FSG+2RIlex+8f6i4pswHVyVvaoOQ4xuBgtRHbSYIzywOEqT29LZ+MDPpYFXk7K gG8WXbfnzzwmNMs22GmbB9s7T+iSUxM41KGj0AcjhuoDJsbJHuapYPG+p11WZg5x0tQT YCNSI2AQMJveBWlLQ8BBzV5Eo/S6gKH/DLM3tgoNQC0Ggi/8+wMSuFSo9cnMIKz7JOqI 2M34Z0KatGNNjBKxyQ1uiS716UMwmdnXU7pCZmzJUn3FrvNsRwxNs+0u3fnYuZQ+wo5u Sjsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=18sk6xZAzQy+8zZC39DhDVenTv6aFq2M9j9/bXUj98Q=; b=pDxA4+iIfgDFJRZnOT4JkwkwhNTfEUcJD4wn2KDkOQwum0whIPHjoGZ2ms0HdRUmyv 4UALkYANPBZybvS/9r45jbRs/ROF9ei3o0GnnAyeyfc0zSOV5XAs6Zho/R0TSZd7PaXg oSgjR23tyss0J6DWqaouqn1N05nR0g0zB3TSYRf9IHPPWsuURPCWt417jF6Gm/TE0XyE DPp9wZIUWBLAKuClXDXmIlrXnRfbV82BWnO/sxPVUykSZfTmgrDM6Z47edib6Si3nQPN OYUMqqDjJ9RW5PovG8bZQL2sdH9kATEWHA+xCL+2bS4ziZcMCBxzWAmqO0zEmG0pmu71 5MXw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id m2si79385lfj.2.2018.01.31.03.43.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Jan 2018 03:43:26 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w0VBhPmX009003 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Jan 2018 12:43:25 +0100 Received: from [167.87.8.100] ([167.87.8.100]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w0VBhOdd017717; Wed, 31 Jan 2018 12:43:24 +0100 Subject: Re: [PATCH 9/9] wic: now truly go for the wic version we claim to have To: Alexander Smirnov , isar-users@googlegroups.com References: <540bb04ce24f67c121c83801288a3aea6f4cedac.1517390790.git.henning.schild@siemens.com> <9882db52-7c2e-d135-2ca5-13c5b9a722a7@siemens.com> From: Jan Kiszka Message-ID: <943545ea-d6a4-8fb0-2c95-3d62b1375ad6@siemens.com> Date: Wed, 31 Jan 2018 12:43:24 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: Y8VvRvQ9kWA9 On 2018-01-31 12:11, Alexander Smirnov wrote: > On 01/31/2018 01:55 PM, Jan Kiszka wrote: >> On 2018-01-31 11:11, Alexander Smirnov wrote: >>> On 01/31/2018 12:42 PM, Henning Schild wrote: >>>> 2b164b18fd639c9 claims to introduce wic hash 131629ca6238ea05 >>>> This commit really carries that version of wic. >>>> >>>> Issue: >>>>    - the wic version in Isar was modified >>>>    - that causes: >>>>     - confusion, maintainability and updateability issues >>>>     - potential quality issues >>>> >>>> Impact: >>>>    This patch and the previous reverts get wic back to a state where >>>> all >>>>    these Issues are solved. We could now just update our wic without >>>> having >>>>    to worry about local patches. In case of a wic-update Isar and >>>> layers >>>>    on top would still have to review their plugins. >>> >>> Does upstream wic script rely on the content from lib/plugins? >>> >>> For example some recent commit updates both: >>> >>> https://github.com/openembedded/openembedded-core/commit/00420ec42140c1b752132bda190dede85756d157#diff-df4a70bc146d3159891d7a410f2521a1 >>> >>> >>> >>> So due to customized plugins below we should worry and keep this in >>> mind. >> >> Sure, we have to keep an eye on wic<->plugin API changes when updating >> wic to the next upstream version. Nothing new, though, when you write >> plugins for wic (like we do for firmware update mechanisms, also over >> Yocto). > > This patch claims that the wic maintenance becomes easier. What is the > idea of this claim? Wic is based on both: 'scripts/wic' and 'lib/wic', > they don't work without each other. Whole this series performs migration > of changes from 'scripts/wic' to 'lib/wic', so eventually there is no > unmodified upstream wic support, the only script stays unmodified while > plugins are patched. > > So I'm a bit confused, what is the core difference with existing > approach, and how this approach fixes maintainability and updateability > issues? Study patch 2 again, I think you misunderstood what it changed: all adaptations are consolidated in those 100 lines now. Now longer a fork of wic, only few external wrappings (without changing scripts or lib). Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux