From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6465966180629741568 X-Received: by 10.25.143.201 with SMTP id s70mr201958lfk.38.1505834119179; Tue, 19 Sep 2017 08:15:19 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.22.90 with SMTP id 26ls11898ljw.46.gmail; Tue, 19 Sep 2017 08:15:18 -0700 (PDT) X-Google-Smtp-Source: AOwi7QDj+aFxxXlN7DwMZYjMfX9EzrkzCieF9vf3MVQtKPa/EfV+6Goh+hQvPfNiGCJEjhw1kfuB X-Received: by 10.46.93.19 with SMTP id r19mr200474ljb.43.1505834118893; Tue, 19 Sep 2017 08:15:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505834118; cv=none; d=google.com; s=arc-20160816; b=ZJxv/XHSfo4bEoS9k/xDXc5gZZhT+2ELq5ZOEuzKMkQw2bTvRr9BQb8HB62e0Z1Bg2 kWOGtHMDxDf6RpsI7xATnxa3kz7KX40omcfM4XJJkh+hLEF3DSNm6xxSs2q4l+FA+svY UdZo+DSgRMveIwOkNn1YVvnX0Mhh0W13m6oM2dIl2RBQWoXZv5G1XNWg35zRcs8GLtRp PAdCwCcxFw1BrzT4z4ypBe34NoSVOS4OYSn0z7yp+oThKRwqAEAsUYy29N68MSFPN72R RNdfz56lta7FuL9Knn4J4PGa3pbjd39eHgAU4gFVGlntO2Q1hlB4QwYnvu7WAlBvRhYm GRuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=6YSDd4ezwSZC4uq38MacNvC2GBof5kOwcNGh7Ui4ISQ=; b=Cer1YJ1D3jMTQ29+rbaMvtrPc7EAyQyrDwG8/6M1AA/m4nFsOJpW6UagF9A/baEQzJ 9KKIIFMd3jTZ9Hg5FHA0MUEXZMell5IkZJd6NpDkyre5n96bB3Uw33KS/eHxoIriKfaS cy7oFKMJT4EKqEYNRiAvAWfM5xxelgZSDKWMd2IRb1jNSuf6wKQ2YLm1+kmw/Qqi/Ixs p/HqOHwnqYErveEBwfjcauTHTjzWNc1nFz2hrqbdguA+VsBaMyOwbwbwkTZ2OwTvH/6V oJBJqmaCw8DTdEAnm0nifhg6Czc0Cx6oQuhaqukf7LVt0WgGVYY04CNNwJZVdwODaIf/ 3p1w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id t142si268414wmt.2.2017.09.19.08.15.18 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Sep 2017 08:15:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id v8JFFFgm010797 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 19 Sep 2017 17:15:17 +0200 Subject: Re: [PATCH 1/2] meta: dpkg-base: rename 'install' to 'deploy_deb' To: Henning Schild , isar-users@googlegroups.com References: From: Alexander Smirnov Message-ID: <943c0320-5c68-bb59-43f2-79804af3bd50@ilbers.de> Date: Tue, 19 Sep 2017 18:15:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: oVHZQbjA6Cq/ Applied to next, thanks. On 09/15/2017 02:31 PM, Henning Schild wrote: > Issue: > The task name 'install' is a well known name from OE, gentoo, and other > similar build-systems. But in Isar it is used in a completely different > context, that might confuse Isar users. And we can not use the name for > what people would expect, as long as it is taken. > > Change: > Rename the task. > > Impact: > This patch does not change the behaviour of Isar. It just addresses the > issue. > > Signed-off-by: Henning Schild > --- > doc/technical_overview.md | 2 +- > meta/classes/dpkg-base.bbclass | 8 ++++---- > meta/classes/image.bbclass | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/doc/technical_overview.md b/doc/technical_overview.md > index f8ed9ee..c73cf08 100644 > --- a/doc/technical_overview.md > +++ b/doc/technical_overview.md > @@ -190,7 +190,7 @@ Both consist of the following steps: > without compiling anything > > > -5. Task `do_install`: install successfully built packages > +5. Task `do_deploy_deb`: install successfully built packages > `${WORKDIR}/*.deb` to deploy directory `${DEPLOY_DIR_DEB}` > > ## 3.5 Populate Target Filesystem > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass > index 2402858..9ded3ae 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -27,10 +27,10 @@ do_build() { > } > > # Install package to dedicated deploy directory > -do_install() { > +do_deploy_deb() { > install -m 644 ${WORKDIR}/*.deb ${DEPLOY_DIR_DEB}/ > } > > -addtask install after do_build > -do_install[dirs] = "${DEPLOY_DIR_DEB}" > -do_install[stamp-extra-info] = "${MACHINE}" > +addtask deploy_deb after do_build > +do_deploy_deb[dirs] = "${DEPLOY_DIR_DEB}" > +do_deploy_deb[stamp-extra-info] = "${MACHINE}" > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 590725c..5bf9524 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -28,4 +28,4 @@ do_populate() { > } > > addtask populate before do_build > -do_populate[deptask] = "do_install" > +do_populate[deptask] = "do_deploy_deb" >