From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7203018052316692480 X-Received: by 2002:a81:a745:0:b0:536:3c2c:bf5e with SMTP id e66-20020a81a745000000b005363c2cbf5emr789394ywh.8.1677563415422; Mon, 27 Feb 2023 21:50:15 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a25:c0cf:0:b0:9a0:d4d:5471 with SMTP id c198-20020a25c0cf000000b009a00d4d5471ls6967609ybf.0.-pod-prod-gmail; Mon, 27 Feb 2023 21:50:14 -0800 (PST) X-Google-Smtp-Source: AK7set+FA0ABGuRcAH7txzlR6wnkIxFXHvwnyuy1cfWlJyApUeCwnlPvukICyGFWyOpILJWQOxja X-Received: by 2002:a25:8b11:0:b0:a03:da3f:2e6f with SMTP id i17-20020a258b11000000b00a03da3f2e6fmr945748ybl.39.1677563414552; Mon, 27 Feb 2023 21:50:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677563414; cv=none; d=google.com; s=arc-20160816; b=N/eH8i/PuUlkE2mFuRPI2amaLvc3oKpST4aH1b+MbhfT0z/qqWF0QLl8d0F6+pO7Bp wprVRarVVouUwTvERKOBT/cTTAf5iB8VCV4RDK9JTtGh5bIoAce24lqql/P864/M6/ho kh7nePEunMrS4plnCHWB8q7b1hxRNaLF1jr2y14rOyi4EdCC4t2hAM91vfSZg8+cEU06 90WY+YUVqn6J3bOYyCGt59Ba7J8vUWlx19nSOW2rFmPFHwskGFhrcgQn2Jg1QAlBeZsV AnRkFPyzBFa3nkAgPtEFSVOXNUw++gLv+4tmgg5mUwBpJXYL1x1zM9MU4BvuuK1ZfDG9 FNvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from; bh=689gGGCkXAbhlNw//2742GsukiW4FAaoWWvNe0x2zDo=; b=A2qUGVNyo7JXwORahC/ywsNUTKN1x4ql7AnH8ZzEVe8vdAcTrMqxWnleS00x6wu3ou Zgy0zyuUCRvpmGMw09KHkthxR8XmqNh5spMvIBy5mioLusxUEfi18Ei2ISw5uR0ZAPKF j8KmrR1HShdj4jmoiW431+L5BP2UcMKiSXoxeTEtbZc0ZsVjrQKS6cUlPUb0PS3rVk5x XBao1gAUN4zqoEPRWRVy9MFbIN1UPPEJmqXvmcxO8+Vrurc/Jjmr6w4SHCxYerS+UN4V +3j4cCTmNRordiAGppiaWdbKvk0MemAcpz+GYYdAqMrwmMQx4sSBcygVAAOxHAwKHjma Nlyg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id m138-20020a25d490000000b00966dfffc287si750158ybf.3.2023.02.27.21.50.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Feb 2023 21:50:14 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from hp.localnet (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 31S5o8Ob010299 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 28 Feb 2023 06:50:09 +0100 From: Uladzimir Bely To: isar-users Subject: Re: [PATCH] sdk: Avoid parsing errors when DISTRO_ARCH is not yet set Date: Tue, 28 Feb 2023 08:50:15 +0300 Message-ID: <9489441.eNJFYEL58v@hp> In-Reply-To: <4ac8a0a6-50ac-5a76-88c0-3eef5d2f96a9@siemens.com> References: <4ac8a0a6-50ac-5a76-88c0-3eef5d2f96a9@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: P/vqjsMx38ji In mail from Wednesday, 22 February 2023 19:28:42 +03 user Jan Kiszka wrote: > From: Jan Kiszka > > In multiconfig setups, it can happen during some parsing steps that a > machine and, thus, a concrete DISTRO_ARCH is not yet set, leading to > > The stack trace of python calls that resulted in this exception/failure was: > File: '', lineno: 4, function: > 0001:__anon_158__build____work_isar_meta_classes_base_bbclass(d) > 0002:__anon_162__build____work_isar_meta_classes_sstate_bbclass(d) > 0003:__anon_56__build____work_isar_meta_classes_image_bbclass(d) > *** 0004:__anon_56__build____work_isar_meta_classes_sdk_bbclass(d) > 0005:__anon_21__build____work_isar_meta_classes_buildchroot_bbclass(d) > > 0006:__anon_84__build____work_isar_meta_classes_imagetypes_wic_bbclass(d) > 0007:__anon_24__build____work_isar_meta_classes_imagetypes_container_bbclas > s(d) 0008:__anon_305__build____work_isar_meta_classes_image_bbclass(d) File: > '/build/../work/isar/meta/classes/sdk.bbclass', lineno: 52, function: > __anon_56__build____work_isar_meta_classes_sdk_bbclass 0048: distro_arch > = d.getVar('DISTRO_ARCH') > 0049: if mode == "0" or d.getVar('HOST_ARCH') == distro_arch: > 0050: toolchain = "build-essential" > 0051: else: > *** 0052: toolchain = "crossbuild-essential-" + distro_arch > 0053: if d.getVar('ISAR_ENABLE_COMPAT_ARCH', True) == "1": > 0054: toolchain += " crossbuild-essential-" + > d.getVar('COMPAT_DISTRO_ARCH') 0055: d.setVar('TOOLCHAIN', toolchain) > 0056:} > Exception: TypeError: can only concatenate str (not "NoneType") to str > > Signed-off-by: Jan Kiszka > --- > > Found in mtda: https://github.com/siemens/mtda/pull/283 > > meta/classes/sdk.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass > index 0a98ea04..01eb3a67 100644 > --- a/meta/classes/sdk.bbclass > +++ b/meta/classes/sdk.bbclass > @@ -46,7 +46,7 @@ SDK_PREINSTALL += " \ > python __anonymous() { > mode = d.getVar('ISAR_CROSS_COMPILE', True) > distro_arch = d.getVar('DISTRO_ARCH') > - if mode == "0" or d.getVar('HOST_ARCH') == distro_arch: > + if mode == "0" or d.getVar('HOST_ARCH') == distro_arch or distro_arch > == None: toolchain = "build-essential" > else: > toolchain = "crossbuild-essential-" + distro_arch Applied to next, thanks