From: Alexander Smirnov <asmirnov@ilbers.de>
To: claudius.heine.ext@siemens.com, isar-users@googlegroups.com
Cc: Claudius Heine <ch@denx.de>
Subject: Re: [PATCH v3 2/2] meta-isar/*-configscript: added removal of qemu-*-static binaries
Date: Mon, 14 May 2018 14:47:21 +0300 [thread overview]
Message-ID: <954c05a0-57b2-086e-cf20-be1e6b7a4032@ilbers.de> (raw)
In-Reply-To: <20180412070121.31332-3-claudius.heine.ext@siemens.com>
Hi,
On 04/12/2018 10:01 AM, claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
>
> After the image has finished building, the qemu-*-static binaries that
> are installed by quemu-debootstrap can be removed because they are no
> longer needed.
>
> Reported-by: Henning Schild <henning.schild@siemens.com>
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
> meta-isar/recipes-core/images/files/debian-configscript.sh | 3 +++
> meta-isar/recipes-core/images/files/raspbian-configscript.sh | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/meta-isar/recipes-core/images/files/debian-configscript.sh b/meta-isar/recipes-core/images/files/debian-configscript.sh
> index 042b530..e6d5335 100755
> --- a/meta-isar/recipes-core/images/files/debian-configscript.sh
> +++ b/meta-isar/recipes-core/images/files/debian-configscript.sh
> @@ -63,3 +63,6 @@ fi
> # Purge unused locale and installed packages' .deb files
> localepurge
> apt-get clean
> +
> +# Remove qemu-*-static:
> +find /usr/bin -maxdepth 1 -name 'qemu-*-static' -delete
If user requested to install 'qemu-user-static' package via
IMAGE_INSTALL, this line will totally corrupt it. I think that the
additional check like `dpkg -S xxx` before removing could help to avoid
this.
Alex
> diff --git a/meta-isar/recipes-core/images/files/raspbian-configscript.sh b/meta-isar/recipes-core/images/files/raspbian-configscript.sh
> index ec05a6b..d7bdc07 100644
> --- a/meta-isar/recipes-core/images/files/raspbian-configscript.sh
> +++ b/meta-isar/recipes-core/images/files/raspbian-configscript.sh
> @@ -63,3 +63,6 @@ EOF
>
> localepurge
> apt-get clean
> +
> +# Remove qemu-*-static:
> +find /usr/bin -maxdepth 1 -name 'qemu-*-static' -delete
prev parent reply other threads:[~2018-05-14 11:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 7:01 [PATCH v3 0/2] Cleanup of the configscripts claudius.heine.ext
2018-04-12 7:01 ` [PATCH v3 1/2] meta-isar/isar-image-base: remove uncesessary cmd lines from cfg scripts claudius.heine.ext
2018-04-12 7:01 ` [PATCH v3 2/2] meta-isar/*-configscript: added removal of qemu-*-static binaries claudius.heine.ext
2018-05-14 11:47 ` Alexander Smirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=954c05a0-57b2-086e-cf20-be1e6b7a4032@ilbers.de \
--to=asmirnov@ilbers.de \
--cc=ch@denx.de \
--cc=claudius.heine.ext@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox