From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7044234567900725248 X-Received: by 2002:a2e:960a:: with SMTP id v10mr13030951ljh.208.1643614160883; Sun, 30 Jan 2022 23:29:20 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:651c:556:: with SMTP id q22ls2501236ljp.1.gmail; Sun, 30 Jan 2022 23:29:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJw2ulQO/DqbqXGnrk31k+Td4iFAwLJkn43cCmCl7KJPIpxP9iT8WuY2FmFnn4UW8OnGocEC X-Received: by 2002:a2e:7a11:: with SMTP id v17mr13039089ljc.63.1643614159750; Sun, 30 Jan 2022 23:29:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1643614159; cv=pass; d=google.com; s=arc-20160816; b=aH1DCqhChrQ0K7Bzc2DB2yDzXCTZQwJAaPfVCvfBUiXoETEcKLiQk9CJBL2ymrZfxk rdVPOMe34SOjDZRHac1dcIIv3xWq2mBxlTSWRJ8YbBTIXXYvU/hROI7E/6BxA8TR8Xv4 gM33OO5U1X9VIaawFnVMjNgb5EYZ2m2PH856zhK5unkyoHiX71WyrW2fD+XZugMm2YLg glFdHp3S48UCj+Mwraf1BR8oPRV3d2bpFE537m9nuz2wajleEKQjCheYSry1M2K4osK/ gzCz7VZ/Mf2WaSD9tPPe5AV+f5zKJEhf5e1HhBrje0NeJPkCqrLION1UDJq8yz+jzaHZ 7l9A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=ONE7O+vCavlVeFcfoKvG/FdHIHQ248ViKAp9VWaipyY=; b=vehTHhlMRXqE66w4dOpTlkeMKeWSHZdpe5sStu3BFZFeyvecPeH1xOwJboePF1FAFe TbTzaN2bejtXOPI1ezgs1gSgNgKbuX03Pi0iJVENEJ6hIGxfuasWffEuzqqznS4vgcts UjQVfjXfOho5rer2Sp46JQO3B/nI/qCnhMIs/eguIGtks8RDcCxASuDupYa6AoTrZ6xh LMGPdeKORAl8Pegj1qkRkkspYk98GCJapcdXQ1Z6ZRH10bKPoDFPPZwJv3xLxtoDCkUR 1UGQY/a8yXmWHPJM1gn6k0IPGgOY9HHoAJj0w1AxAUCi+856hDZRN36svkVU4d5uF/Ei 2MpQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=wmkxaUIO; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.21.53 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2053.outbound.protection.outlook.com. [40.107.21.53]) by gmr-mx.google.com with ESMTPS id q5si507637lfg.3.2022.01.30.23.29.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Jan 2022 23:29:19 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.21.53 as permitted sender) client-ip=40.107.21.53; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=wmkxaUIO; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.21.53 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f5YoXxqQ/WbYiRzgUB2LyLekCKwKHEj2+vINtT7aavGa3ytkvrBW5a677wHdzCROF2qiwGXBVZmGaOlYTTsGTz38GB0uQrw/mlpS0q3btuGgjxReQdRtrMoPytwtF8XIUfSPsZwhFR8uzZhDxp8qIS9yATfgH+Vw3zKjVOtCjMgHgIvpiA4wEBoWXUTC+eQFHSBqCTN+LbNsQao3pL3tUqjIUCYMuYKxEs2eN/a3K9poEZMAM+CbC/ySWn6wxYgE8+bsS4u9HP+K5fq+AimPmpi/jxI8x/kgvBJ4n+J0UaZ4tLaxWkmlvgDyHj6MbarZDEbnAjMxU32Qi1CRt9+0ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ONE7O+vCavlVeFcfoKvG/FdHIHQ248ViKAp9VWaipyY=; b=HJZYAAF1LhERrkBvAz0dWUFty8DtTG62bxeP8a5ar3r9XfcXoyNEtGmPqXGmJhzKUxLBuU0Zlu2PxsmQ8xDiNgjGWJILndzcsT9E6T3HpGyZ0ePYoQOt1H1uXGrjqKHtXz2oltAw9TjYWa8GXTe/c1Fe2ZTjmZNXF3yc2vTWEYy3fhb6vf4jzoEAX+bIKumh0kH1Jz6nUX/Q94XUYDbUXg1LNXM1hI1Z6ttr9qHlf4Y3wzz3V/OeYc3y3EZA9/BquQLjiQ7KCJ73D7jXtiNmDH4dsrSTYoqBtHCrV6/whyrM4RLSYaImNiwbmwOb6Zl2ITnZ5et1fpCe7THvA7s10g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.71) smtp.rcpttodomain=googlegroups.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ONE7O+vCavlVeFcfoKvG/FdHIHQ248ViKAp9VWaipyY=; b=wmkxaUIOTZIoOALk4rpgNJaiVUwcuCmJNohNVwBNe23kyaga/sC2dEa9am5A3L0Yfi8298UibklQDMDS1sGdjLs5OPXPjb6ArwMb5Rw467N59XU1fiKcGarv8SVxAQq0CsQ2FSiPAQrCKuAiROBAt++wY3MoJDRPgIJKOEILjMGF60zp8reVFPvkRD6DhyJ4/M+6tRLub/T3Cf7LMZIszOtVBek4pitP5HnRpeVRHSwa9OQUF+JGvu4UwVxoS7NCfqrPaR7CcR4ODM5jaYGK1aNH6Xux3BOAMNvDU+OPD8W42MOLQdVo5hnZXdfS1RttwDvXSw0/s+9eZmsHtSYStw== Received: from DB7PR05CA0057.eurprd05.prod.outlook.com (2603:10a6:10:2e::34) by DB8PR10MB3766.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:149::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Mon, 31 Jan 2022 07:29:18 +0000 Received: from DB5EUR01FT049.eop-EUR01.prod.protection.outlook.com (2603:10a6:10:2e:cafe::9c) by DB7PR05CA0057.outlook.office365.com (2603:10a6:10:2e::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.21 via Frontend Transport; Mon, 31 Jan 2022 07:29:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.71) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.71 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.71; helo=hybrid.siemens.com; Received: from hybrid.siemens.com (194.138.21.71) by DB5EUR01FT049.mail.protection.outlook.com (10.152.5.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4930.15 via Frontend Transport; Mon, 31 Jan 2022 07:29:18 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC9SKA.ad011.siemens.net (194.138.21.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Mon, 31 Jan 2022 08:29:17 +0100 Received: from [167.87.72.142] (167.87.72.142) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Mon, 31 Jan 2022 08:29:17 +0100 Message-ID: <95781e0b-07a3-5956-a210-7b3dd14aedce@siemens.com> Date: Mon, 31 Jan 2022 08:29:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 2/3] refactor linux-custom.inc to use ISAR's DEB_BUILD_PROFILES support Content-Language: en-US To: "Moessbauer, Felix (T CED SES-DE)" , "isar-users@googlegroups.com" CC: "vijaikumar.kanagarajan@gmail.com" References: <20220112143949.3456842-1-felix.moessbauer@siemens.com> <20220112143949.3456842-3-felix.moessbauer@siemens.com> <189b5510-ecdc-62a7-fc43-aec2a7d66866@siemens.com> From: Jan Kiszka In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [167.87.72.142] X-ClientProxiedBy: DEMCHDC89YA.ad011.siemens.net (139.25.226.104) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b80c0051-2fcb-447d-55db-08d9e48b6425 X-MS-TrafficTypeDiagnostic: DB8PR10MB3766:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jGvixLr19isz1H8CcEZNY+kr85OKvGAr7FVcguYLAcrKXtNWvxApic0ZivWvFrhj/Rbw+innNCGrfl3tmN1dupBQwbwipjlmq+OTtpbiRbG/wb5pNfXDQs4gDku23aaUiW3RUSvnLjVnJVI6Ie4yNoWY7z2sdpR+ZrM3/PcH6uWFLY/bXS5K3BOXB5wBZksxfrCD7vrOBoS243Ti+OPXgzyuP1SVlX3hhpqgK8CsUNTqoHhE+WY1sstN0W/0W7hxK7BUtt1cpQ+hDPtyLzaLs9KwIeNaA/mEp19JmceKOEQEk1tBuJbsY/b/e6ZmExiSdIgzGZXVtx9RfklOtqmgk3d7UhJZqXU8KTCT0Ps5F32a2JQqyIzPu01GpF7pV1ySeXfNqF6XX9asHxpZWoNPRv/x6p6HEhp819jxNO8GVnB0eoSt3+mg01X7lqlRX5XKK71XqJjs7cprxL2UT0xiy8gKDFs7Byj6BEzz34IfMYKbsS/Pfdd1Icdl0s36F/tt5l0hDEcd+tSLS+hragx6bMxo+7prv1KJl71KDMdpiW2BeL74p+2nJGA8jbYFYng52u0Gn2UlDj6bqRHJAxXP3+w9QgO6myDRbKOYcrLJdqNZ1BrE2+KNrZ6liBt6t7u7MZwGGAshDsGYydVN2/DgtVXbOm4KoZqVweEkQgA6P8G1LpkmNow8qs2hYpkYG58iQz68rO8zYySg+JkjQc45jjdtFOfqmfoPCXPTJe9iNf0TUCsL6TgWHKQKxPKc2KrKxHHI8CB9W9E5pzFSVfbCJw== X-Forefront-Antispam-Report: CIP:194.138.21.71;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(2616005)(31696002)(40460700003)(336012)(956004)(186003)(16526019)(86362001)(26005)(82960400001)(82310400004)(36860700001)(47076005)(83380400001)(5660300002)(44832011)(36756003)(70586007)(70206006)(356005)(81166007)(31686004)(8936002)(8676002)(2906002)(508600001)(53546011)(110136005)(6706004)(316002)(16576012)(4326008)(3940600001)(43740500002)(36900700001)(20210929001);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2022 07:29:18.0610 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b80c0051-2fcb-447d-55db-08d9e48b6425 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.71];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR01FT049.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3766 X-TUID: oLT140D2HJns On 27.01.22 16:51, Moessbauer, Felix (T CED SES-DE) wrote: >> -----Original Message----- >> From: Kiszka, Jan (T CED) >> Sent: Thursday, January 27, 2022 10:29 AM >> To: Moessbauer, Felix (T CED SES-DE) ; isar- >> users@googlegroups.com >> Cc: vijaikumar.kanagarajan@gmail.com >> Subject: Re: [PATCH v5 2/3] refactor linux-custom.inc to use ISAR's >> DEB_BUILD_PROFILES support >> >> On 12.01.22 15:39, Felix Moessbauer wrote: >>> This patch replaces the manual setup of the DEB_BUILD_PROFILES >>> environment variable in the linux-custom.inc recipe. >>> Instead, the recently introduced DEB_BUILD_PROFILES infrastructure of >>> ISAR is used. >>> >>> Signed-off-by: Felix Moessbauer >>> --- >>> meta/recipes-kernel/linux/linux-custom.inc | 13 ++++++++----- >>> 1 file changed, 8 insertions(+), 5 deletions(-) >>> >>> diff --git a/meta/recipes-kernel/linux/linux-custom.inc >>> b/meta/recipes-kernel/linux/linux-custom.inc >>> index ed89aa09..59d42c84 100644 >>> --- a/meta/recipes-kernel/linux/linux-custom.inc >>> +++ b/meta/recipes-kernel/linux/linux-custom.inc >>> @@ -117,6 +117,14 @@ def config_fragments(d): >>> fragments.append(local) >>> return fragments >>> >>> +def get_additional_build_profiles(d): >>> + profiles = d.getVar('BASE_DISTRO', True) >>> + if d.getVar('KERNEL_LIBC_DEV_DEPLOY', True) != '1': >>> + profiles += ' nolibcdev' >>> + return profiles >>> + >>> +DEB_BUILD_PROFILES += "${@get_additional_build_profiles(d)}" >>> + >>> do_prepare_build_prepend() { >>> # copy meta-data over to source tree >>> rm -rf ${S}/debian >>> @@ -176,10 +184,5 @@ dpkg_configure_kernel() { >>> } >>> >>> dpkg_runbuild_prepend() { >>> - profiles="${BASE_DISTRO}" >>> - if [ "${KERNEL_LIBC_DEV_DEPLOY}" != "1" ]; then >>> - profiles="${profiles} nolibcdev" >>> - fi >>> - export DEB_BUILD_PROFILES="${profiles}" >>> dpkg_configure_kernel >>> } >> >> After local experiments, it looks like this patch must be folded into patch 1 in >> order to avoid that linux-libc-dev gets built accidentally when it shouldn't. > > I just sent out a v6 with all commits squashed. > > While we are at it: > Without sbuilder, removing packages due to conflicting build dependencies is a recipe for disaster. > The do_install_builddeps and do_dpkg_build steps are not atomic, so another package might remove build deps in between the two tasks. They are atomic (do_install_builddeps[lockfiles] vs. read-lock in do_dpkg_build), don't worry about that. But, yes, this can cause troubles if undesired packages are being pushed into the buildchroot and/or dependencies were not properly expressed. > > We should at least scan the do_install_builddeps log and search for "[1-9]+ to remove" and issue a warning if we find such a line. On partial rebuild, you do want to see those messages. Jan > > But don't know when sbuilder will be ready, and if we should put time into this check. > Opinions? > > Felix > >> >> Jan >> >> -- >> Siemens AG, Technology >> Competence Center Embedded Linux -- Siemens AG, Technology Competence Center Embedded Linux