From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Thu, 06 Nov 2025 09:43:02 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-lf1-f55.google.com (mail-lf1-f55.google.com [209.85.167.55]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 5A68h1wP024822 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 6 Nov 2025 09:43:01 +0100 Received: by mail-lf1-f55.google.com with SMTP id 2adb3069b0e04-57b9c463726sf503491e87.1 for ; Thu, 06 Nov 2025 00:43:01 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1762418576; cv=pass; d=google.com; s=arc-20240605; b=BN7imMFddqstiKjwI5Yfc7otTlr2tHLASbU0fNrTEzFQ70e28slgPpebfPCWWf2FRC Q/58Fd3uUw8mtk4ZFCKYjiimbqEqzGflhjLZraR7Z2r8MRNZENzZuxV8O98tQvFQ+87W x3iwZ4AhUDEMwdGS7NOtLYHOo5Y9rGlkJLV7jHxNlClJO9ff9KxLFpKa8GsSJ29MwtQI kSqGkfJhZLfZ3iZtparjrMwrzqhttFfTJDlrbpVCGKX+QJQDNm+EnLmZILyNSKZfViTY 0bZF49/njI7YvctZPkNJrzwwdYZwKngtCk2GP3CLtGSXBgF7Yjhg8vAeD6gT6jR+p+Be 4WGw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=t5MGLpUBN1HmJYwAt2V4PIxi4AvH7JFzkdF+KyjgOII=; fh=gWI1jNi4/omHZfhSCDlO1Z6RqI1ZphXXrmoxt/XGN7o=; b=e3BiE582ziIQqs8dDqP4PHZfnBjeLAjXKJdL+nQs2aliWRhX3aPHmILMHfhl7JKOgr 63jwLqrnWR/I6DznccS7qo5F3jvfmdATqDZS+PfnBFBCf6ZuoeTQIaK1L+GR17H6twyR c29EDDU2DjaE+O+qIJ2Sxo61x+6prqWE/hZQnSBsKwyUqj3omADEkGB5Y1rv3MFIJBZW S2DMO0y7Crml6VjLP6O+nHlqJhaS0BBL5ppWQZlHEwLiyS4lNadAxo9SzxqY0HQgAubY nGIi2YmcuSxr28MWu5KFQSmelp0GOJZNKN2gop6x+VJnDFocQZmhsxrLli955RZKBz9t TsAA==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@emlix.com header.s=20250930 header.b=Syl0RihP; dkim=pass header.i=@emlix.com header.s=20250930 header.b=Syl0RihP; spf=pass (google.com: domain of anaumann@emlix.com designates 178.63.209.131 as permitted sender) smtp.mailfrom=anaumann@emlix.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=emlix.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1762418576; x=1763023376; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:in-reply-to :from:content-language:references:cc:to:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=t5MGLpUBN1HmJYwAt2V4PIxi4AvH7JFzkdF+KyjgOII=; b=JNPL3EA3nyHc/lWsAJPvpsPasdrsm9g/zj7JNWTjsdPR6RcZfF30YGHZJkSuAgPvkp RhjE+lYJASHbL3LtDKtwCvPGOZgsf4QfayQ0hj79ri6Hj+6W3EKwzkNOJs9Ef7TljFf8 U1hGT9QyLMbMNuNts6ZLd2Y9TbnlGYf1TmB2asXEFKRWBdKDKlF5gn0AzVlFqrHcUVxn gGQrHlLek5XlopxKn7s7QZIskkIam50YAE9MnSDruzlbzlyyuBamcmYjiFFLDvp8mizt T4Wcm1S1z0W0I4cMTl0aAyiVuug9bLCRlRyTtaJXo0147xDbhyNvqFlyO+cepDwBwLH7 8yDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762418576; x=1763023376; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:in-reply-to :from:content-language:references:cc:to:subject:user-agent :mime-version:date:message-id:x-beenthere:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=t5MGLpUBN1HmJYwAt2V4PIxi4AvH7JFzkdF+KyjgOII=; b=rn9rVR4JqWGxD1BKjbbOE7poco93b8EvFd9pa05P/2WcFKdv09IsVP1E3LUmR1/t3v qVHlDR1G8jPeANVvyPeSkJOw8UhKxIrCKUy5yeqWkJywpNaWR3FjldlIcOcuQc5x2mOU qh0co4cTUrnkA/Nh7MFiNohKkDF8NKgQMSANeIxjmSsPz/IvbO6ybnJAQhQuD+Fes8ex jJAIQXEaeHkwqdwzSChgDK+yEVohv8HE3ESMpuvOd+DG+mz7rwwjsVVHxUL10EFxhZF+ m6sezm9kyi2vykAfqHikihbtJI9uYRvmO/DJvpPzMDf6Agf7sfOcamPUbo78U29Pvg2R T8aw== X-Forwarded-Encrypted: i=2; AJvYcCXfj25h32QP0N/hzobHIaf+obTOrvHYYFWkgZjAFGOrdwXB3OumxI6NgduWRzfQihbtcfIA@ilbers.de X-Gm-Message-State: AOJu0YyqmG2yd+xS9Jj1Bwuzato+o/YJiYZsdQjPS2YNgRmLt90VWgC/ CBEwpZBn7dMONM8/ZbY/YXWR2CKFMacfMTHxEyJ9XZ8gqYPhJ+h5V/Ji X-Google-Smtp-Source: AGHT+IGdOHzBicqUf8I1JiUIBeD/bnQFcQSyTsNqb1Uoamj0jvGsNTkBKtgQBAc50kdlrhA6sVw83w== X-Received: by 2002:a05:6512:3b0d:b0:592:fd2d:71be with SMTP id 2adb3069b0e04-5943d7bf567mr2140177e87.34.1762418575147; Thu, 06 Nov 2025 00:42:55 -0800 (PST) X-BeenThere: isar-users@googlegroups.com; h="Ae8XA+aX0M6vBUBTAVmz3u0o9SFOcPq+ZSXNEy1OPEs7P2o+2A==" Received: by 2002:ac2:5686:0:b0:594:27b6:4809 with SMTP id 2adb3069b0e04-59449c2565fls31712e87.0.-pod-prod-07-eu; Thu, 06 Nov 2025 00:42:51 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXX2NdKZVQwokf8sNhYFJWJeWI/oLOZ3Zq8MIekrzdubpdHCIX5dDVNa4T4eBiiL1Og1RzhjulGZPHU@googlegroups.com X-Received: by 2002:a05:6512:61b3:b0:594:273f:3a7e with SMTP id 2adb3069b0e04-5943d7da0e0mr1912389e87.48.1762418571426; Thu, 06 Nov 2025 00:42:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1762418571; cv=none; d=google.com; s=arc-20240605; b=fHXq8kikI4bbcdwUhAPygS3rtDNPh7SJoIJE9EdL2L9cglu3am4Phh//BS6AozM0lM qLJtsgdilTSt4E3Q3QXKIcagWq0O/Q1SP9N71cIeui+V2wbx2+n4mMVk/AkOf8UUeMJh J6cRN1Lw83mzXpZhskfVZgJ7D1dtITSA3ZnLPzMe74geyg5+XaV7hQ/37ee1VwtH5Goi K3UkRd0UkxkWM1uaOX+CLyxKAA4z7272W5y91KqcJVvANkmBeICe9P6Vqvv+/gf6IMlv 1OQvKZCejumx/K2WeC8HS0OtvxL5d93oeY9ndGx74qRPaFh7qDYnuX8SSGQyyLwQRGzJ oCuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :dkim-signature:dkim-signature; bh=W5KgEXu+xASB6weeUUb6yLrX8zTExUStgXC68XXdedE=; fh=LNaw2Wg4ItPv844VeBf75uuGV20HmWFCI4hg4NJi8ok=; b=MuVk9h7vUvpxWFTg090/TAfsifS5Wv59dy5/lAjdXuwjywIpnnRjDIm9JQJFB9D/02 bqMYbyhSFNCpfi90A97CsmWlosXWMJMQgkZMXfSd+r8kftGPoaab0lOJat8T5/MAZv7N k5R5oPGGx3D/y+Rh/kX848ZBj17HBk7BzBwad7QJYq3EyJxaPiD0KCe+KaOWq8QnITVA p2iNpyBIZ1IIKTFbboPwUnYJa9LkUZplaqbWfNgI0CvltkWzrYdS8nSDP0fO+FIV+5Gg fD9SeamTdivoVesgKk3HP9kR4jNooS9AcR26YNavWot2EKSCQGZzDN/KNyIdJVTIICff HiKQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@emlix.com header.s=20250930 header.b=Syl0RihP; dkim=pass header.i=@emlix.com header.s=20250930 header.b=Syl0RihP; spf=pass (google.com: domain of anaumann@emlix.com designates 178.63.209.131 as permitted sender) smtp.mailfrom=anaumann@emlix.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=emlix.com Received: from mx1.emlix.com (mx1.emlix.com. [178.63.209.131]) by gmr-mx.google.com with ESMTPS id 38308e7fff4ca-37a5f0ff75asi318751fa.6.2025.11.06.00.42.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Nov 2025 00:42:51 -0800 (PST) Received-SPF: pass (google.com: domain of anaumann@emlix.com designates 178.63.209.131 as permitted sender) client-ip=178.63.209.131; Received: from mx1.emlix.com (localhost [127.0.0.1]) by mx1.emlix.com (Postfix) with ESMTP id 8992A5F960; Thu, 6 Nov 2025 09:42:50 +0100 (CET) Received: from mailer.emlix.com (p5098be52.dip0.t-ipconnect.de [80.152.190.82]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id 6CE8C5F84A; Thu, 6 Nov 2025 09:42:50 +0100 (CET) Message-ID: <95d9fef7-32c2-4b46-83e1-51cff7af961a@emlix.com> Date: Thu, 6 Nov 2025 09:42:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/1] rootfs: rework no-generate-initrd rootfs feature To: Christoph Steiger , isar-users@googlegroups.com Cc: felix.moessbauer@siemens.com, jan.kiszka@siemens.com References: <20251105072630.37142-1-christoph.steiger@siemens.com> Content-Language: en-US From: "'Andreas Naumann' via isar-users" In-Reply-To: <20251105072630.37142-1-christoph.steiger@siemens.com> Content-Type: text/plain; charset="UTF-8"; format=flowed X-Virus-Scanned: ClamAV using ClamSMTP X-Original-Sender: anaumann@emlix.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@emlix.com header.s=20250930 header.b=Syl0RihP; dkim=pass header.i=@emlix.com header.s=20250930 header.b=Syl0RihP; spf=pass (google.com: domain of anaumann@emlix.com designates 178.63.209.131 as permitted sender) smtp.mailfrom=anaumann@emlix.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=emlix.com X-Original-From: Andreas Naumann Reply-To: Andreas Naumann Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: HFwVLB1aunEZ Am 05.11.25 um 08:26 schrieb 'Christoph Steiger' via isar-users: > Instead of using a negative feature replace it with a positive one: > generate-initrd. It can be confusing for the user why a initrd is > generated even though no additional rootfs features are enabled. > > To keep default behavior the same add generate-initrd to the default > rootfs features, unless INITRD_IMAGE is provided. > > Signed-off-by: Christoph Steiger > --- > > Changes in v3: > - enable generate-initrd also when there are already other rootfs > features > > Changes in v2: > - move initialisation of INITRD_IMAGE to rootfs > > RECIPE-API-CHANGELOG.md | 14 ++++++++++++++ > meta/classes/image.bbclass | 3 --- > meta/classes/rootfs.bbclass | 10 ++++++---- > .../sbuild-chroot/sbuild-chroot.inc | 2 +- > 4 files changed, 21 insertions(+), 8 deletions(-) > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md > index 1826667a..1a5eba31 100644 > --- a/RECIPE-API-CHANGELOG.md > +++ b/RECIPE-API-CHANGELOG.md > @@ -797,3 +797,17 @@ root file modifications) are required. > A new class called `opensbi` has been introduced that shall help writing > shorter recipes for custom OpenSBI builds. Usage examples can be found in > `meta-isar/recipes/bsp/opensbi`. > + > +### Rework `no-generate-initrd` rootfs feature > + > +This negative feature is being replaced with a positive one: > +`generate-initrd`. The default behavior remains unchanged, as `generate-initrd` > +is now a default rootfs feature. Disabling initrd creation can be done in the I stumbled over this a while ago and was suprised because I didnt see a the change to "is now a default rootfs feature" announced anywhere. Maybe it could be included in this Changelog entry. > +following way: > +``` > +ROOTFS_FEATURE:remove = "generate-initrd" This is definitely easier to understand. Thx. regards, Andreas > +``` > +instead of > +``` > +ROOTFS_FEATURE += "no-generate-initrd" > +``` > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 441ea936..b58711d0 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -23,7 +23,6 @@ IMAGE_FULLNAME = "${PN}-${DISTRO}-${MACHINE}" > > # These variables are used by wic and start_vm > KERNEL_IMAGE ?= "${IMAGE_FULLNAME}-${KERNEL_FILE}" > -INITRD_IMAGE ?= "" > INITRD_DEPLOY_FILE = "${@ d.getVar('INITRD_IMAGE') or '${IMAGE_FULLNAME}-initrd.img'}" > > # This defines the deployed dtbs for reuse by imagers > @@ -67,8 +66,6 @@ inherit essential > > ROOTFSDIR = "${IMAGE_ROOTFS}" > ROOTFS_FEATURES += "clean-package-cache clean-pycache generate-manifest export-dpkg-status clean-log-files clean-debconf-cache" > -# when using a custom initrd, do not generate one as part of the image rootfs > -ROOTFS_FEATURES += "${@ '' if d.getVar('INITRD_IMAGE') == '' else 'no-generate-initrd'}" > ROOTFS_PACKAGES += "${IMAGE_PREINSTALL} ${@isar_multiarch_packages('IMAGE_INSTALL', d)}" > ROOTFS_MANIFEST_DEPLOY_DIR ?= "${DEPLOY_DIR_IMAGE}" > ROOTFS_DPKGSTATUS_DEPLOY_DIR ?= "${DEPLOY_DIR_IMAGE}" > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index 2fef3120..32d49146 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -8,14 +8,16 @@ ROOTFS_DISTRO ?= "${DISTRO}" > ROOTFS_PACKAGES ?= "" > ROOTFS_BASE_DISTRO ?= "${BASE_DISTRO}" > > +INITRD_IMAGE ?= "" > + > # Features of the rootfs creation: > # available features are: > # 'clean-package-cache' - delete package cache from rootfs > # 'generate-manifest' - generate a package manifest of the rootfs into ${ROOTFS_MANIFEST_DEPLOY_DIR} > # 'export-dpkg-status' - exports /var/lib/dpkg/status file to ${ROOTFS_DPKGSTATUS_DEPLOY_DIR} > # 'clean-log-files' - delete log files that are not owned by packages > -# 'no-generate-initrd' - do not generate debian default initrd > -ROOTFS_FEATURES ?= "" > +# 'generate-initrd' - generate debian default initrd > +ROOTFS_FEATURES += "${@ 'generate-initrd' if d.getVar('INITRD_IMAGE') == '' else ''}" > > ROOTFS_APT_ARGS="install --yes -o Debug::pkgProblemResolver=yes" > > @@ -349,7 +351,7 @@ rootfs_restore_initrd_tooling() { > EOSUDO > } > > -ROOTFS_INSTALL_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'no-generate-initrd', 'rootfs_clear_initrd_symlinks', '', d)}" > +ROOTFS_INSTALL_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'generate-initrd', '', 'rootfs_clear_initrd_symlinks', d)}" > rootfs_clear_initrd_symlinks() { > sudo rm -f ${ROOTFSDIR}/initrd.img > sudo rm -f ${ROOTFSDIR}/initrd.img.old > @@ -594,7 +596,7 @@ rootfs_generate_initramfs() { > } > > python() { > - if 'no-generate-initrd' not in d.getVar('ROOTFS_FEATURES', True).split(): > + if 'generate-initrd' in d.getVar('ROOTFS_FEATURES', True).split(): > bb.build.addtask('do_generate_initramfs', 'do_rootfs', 'do_rootfs_postprocess', d) > bb.build.addtask('do_generate_initramfs_setscene', None, None, d) > } > diff --git a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc > index 479aa91d..61d37760 100644 > --- a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc > +++ b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc > @@ -55,7 +55,7 @@ SBUILD_CHROOT_PREINSTALL_COMMON = " \ > SBUILD_CHROOT_DIR = "${WORKDIR}/rootfs" > ROOTFSDIR = "${SBUILD_CHROOT_DIR}" > ROOTFS_PACKAGES = "${SBUILD_CHROOT_PREINSTALL}" > -ROOTFS_FEATURES += "no-generate-initrd" > +ROOTFS_FEATURES:remove = "generate-initrd" > > ROOTFS_INSTALL_COMMAND:remove = "rootfs_restore_initrd_tooling" > -- Andreas Naumann emlix GmbH Headquarters: Berliner Str. 12, 37073 Goettingen, Germany Phone +49 (0)551 30664-0, e-mail info@emlix.com District Court of Goettingen, Registry Number HR B 3160 Managing Directors: Heike Jordan, Dr. Uwe Kracke VAT ID No. DE 205 198 055 Office Berlin: Panoramastr. 1, 10178 Berlin, Germany Office Bonn: Bachstr. 6, 53115 Bonn, Germany http://www.emlix.com -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/95d9fef7-32c2-4b46-83e1-51cff7af961a%40emlix.com.