Re: [PATCH] meta: Add targz image class

[Harald Seiler <hws@denx.de>]

On Tue, 2018-11-20 at 13:51 +0100, Henning Schild wrote:
> Am Tue, 20 Nov 2018 12:50:24 +0100
> schrieb Harald Seiler <hws@denx.de>:
> 
> > Signed-off-by: Harald Seiler <hws@denx.de>
> > ---
> >  meta/classes/targz-img.bbclass | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >  create mode 100644 meta/classes/targz-img.bbclass
> > 
> > diff --git a/meta/classes/targz-img.bbclass
> > b/meta/classes/targz-img.bbclass new file mode 100644
> > index 0000000..898c2a8
> > --- /dev/null
> > +++ b/meta/classes/targz-img.bbclass
> > @@ -0,0 +1,12 @@
> > +# This software is a part of ISAR.
> > +
> > +TARGZ_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${IMAGE_FULLNAME}.tar.gz"
> > +
> > +do_targz_image[stamp-extra-info] = "${DISTRO}-${MACHINE}"
> > +
> > +do_targz_image() {
> > +    rm -f ${TARGZ_IMAGE_FILE}
> 
> Can be skipped, probably fails anyways.

It seems to be necessary.  While testing, tar did not overwrite
the archive during a rebuild.

> 
> > +    sudo tar -cvzf ${TARGZ_IMAGE_FILE} -C ${IMAGE_ROOTFS} .
> > +}
> > +
> > +addtask targz_image before do_build after do_copy_boot_files
> 
> "after do_rootfs" in fact we do not need the copy for that one

Ok, makes sense ...

> How will we test that?

The final tar could be checked agains the rootfs tree generated
during the build using:

	tar --compare --file=archive-file.tar -C /some/where/

I am not sure if this is worth it though, as this will always work
unless tar itself made a mistake ... I think the recipe is trivial
enough that this check can be omitted.

-- 
Harald

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-62  Fax: +49-8142-66989-80   Email: hws@denx.de