From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6625908871596605440 X-Received: by 2002:a1c:1887:: with SMTP id 129-v6mr565877wmy.3.1542719255425; Tue, 20 Nov 2018 05:07:35 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:e8d1:: with SMTP id k17ls886136wrn.6.gmail; Tue, 20 Nov 2018 05:07:35 -0800 (PST) X-Google-Smtp-Source: AFSGD/W2A081TF34WJxK/tXWpMin6fCtmVK/2fKTb7YPrbCRENdQfOA4jSJeSnD9cKSx8eSvTDVy X-Received: by 2002:adf:9d83:: with SMTP id p3-v6mr439704wre.31.1542719254990; Tue, 20 Nov 2018 05:07:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542719254; cv=none; d=google.com; s=arc-20160816; b=O8KgPkZUmhwM/aDbJteyOuSmkR56vglNY7gpuUWeTo/IPBA8clB/dl7ZCEQAbDS7LA WrEiiVGor9QrF27xmQbMFh5I9EoDONRkax7bTyy7HUuXBOSr+CDnpsy67jwRAk1nGWAz 3LXP7fGnGwyQgyQRI5o5lt5sX6SsAfyEsblGHw6dVt26ugEf8/CPn+POWGpA+GQvu1Kr WEbFqVXVeiHPiXnP86FTS5iwqfRWH2xtPgm+C0UvB5b0Vi8AA7zHt+ystJa5ScxiqoPW 5j3Q1B0lwusP+jmIiwJgP6lXEyLB37uHlSZ8t2IwbS3fhZVAt2HhdfzwjrDjnnMhlA8E LW/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id; bh=ZS+Upgw07hqkUv5zuNXxJibsjE1tVVMqSOOhRQ5xSXY=; b=LOcUCXdYXmM7BFEhYeOiu9asYLkzgkSYDfk9NM3Dx0fZ4RtaXfdV05Bh0/vrWfXySQ l935w+f/MfdpsWkUvmtMHa+ELHoOegYN2ouicJ0ATykllXmsODI3LO4CRcrTGPYCapGt ejudmL3m6iLjAOgX5RuC2JlSLGeaRz0XXcXgDU+lrEsd5YEEOZGaM5F80N4yWgoA0A6c G6NRmkok+irKi4mEpBwRp3mo5n1QrR9Rupwa5Mh9QWQM0YpI+aTWKfSL4zQQPAr2uj9W Ypaa3bZ15ewaLKNAgmf7NKYorjAAIt7Hcwt0zf7h8mEQb5V2GxvJ6YGhV/t9z6yYb2Xi LJ9w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of hws@denx.de) smtp.mailfrom=hws@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id p19-v6si27005wmc.1.2018.11.20.05.07.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Nov 2018 05:07:34 -0800 (PST) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of hws@denx.de) client-ip=212.18.0.9; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of hws@denx.de) smtp.mailfrom=hws@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 42zmFy5W6Bz1qvTy; Tue, 20 Nov 2018 14:07:34 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 42zmFy5LRNz1qrn8; Tue, 20 Nov 2018 14:07:34 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id RpfKkigJTYak; Tue, 20 Nov 2018 14:07:33 +0100 (CET) X-Auth-Info: lCexBNP38D/kcfQX5OaooJ32t3yBpg0ix0I3t8Xpm4I= Received: from sandvich (p5B04CBC6.dip0.t-ipconnect.de [91.4.203.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 20 Nov 2018 14:07:33 +0100 (CET) Message-ID: <96df0cdff3e6f9f50eaba46ab163b40bfb88e946.camel@denx.de> Subject: Re: [PATCH] meta: Add targz image class From: Harald Seiler To: Henning Schild Cc: isar-users@googlegroups.com Date: Tue, 20 Nov 2018 14:07:32 +0100 In-Reply-To: <20181120135119.119185af@md1za8fc.ad001.siemens.net> References: <525a1c5b7730f98e1236e1596cf31dc3e23e1b5e.camel@denx.de> <20181120135119.119185af@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUID: IImT9tAFVAeL On Tue, 2018-11-20 at 13:51 +0100, Henning Schild wrote: > Am Tue, 20 Nov 2018 12:50:24 +0100 > schrieb Harald Seiler : > > > Signed-off-by: Harald Seiler > > --- > > meta/classes/targz-img.bbclass | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > create mode 100644 meta/classes/targz-img.bbclass > > > > diff --git a/meta/classes/targz-img.bbclass > > b/meta/classes/targz-img.bbclass new file mode 100644 > > index 0000000..898c2a8 > > --- /dev/null > > +++ b/meta/classes/targz-img.bbclass > > @@ -0,0 +1,12 @@ > > +# This software is a part of ISAR. > > + > > +TARGZ_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${IMAGE_FULLNAME}.tar.gz" > > + > > +do_targz_image[stamp-extra-info] = "${DISTRO}-${MACHINE}" > > + > > +do_targz_image() { > > + rm -f ${TARGZ_IMAGE_FILE} > > Can be skipped, probably fails anyways. It seems to be necessary. While testing, tar did not overwrite the archive during a rebuild. > > > + sudo tar -cvzf ${TARGZ_IMAGE_FILE} -C ${IMAGE_ROOTFS} . > > +} > > + > > +addtask targz_image before do_build after do_copy_boot_files > > "after do_rootfs" in fact we do not need the copy for that one Ok, makes sense ... > How will we test that? The final tar could be checked agains the rootfs tree generated during the build using: tar --compare --file=archive-file.tar -C /some/where/ I am not sure if this is worth it though, as this will always work unless tar itself made a mistake ... I think the recipe is trivial enough that this check can be omitted. -- Harald DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-62 Fax: +49-8142-66989-80 Email: hws@denx.de