Re: [PATCH v3 0/8] Hanging mount fixes

[Uladzimir Bely <ubely@ilbers.de>]

On Fri, 2024-10-11 at 13:00 +0300, Anton Mikanovich wrote:
> Consolidate the patches to address the hanging mount issues.
> 
> Addresses the following issues:
> 
>  1. Cleanup handler is called multiple times, unmounting any hanging
>     mounts.
> 
>  2. Hanging mount warnings are discarded in the current setup.
> 
>  3. Incorrect asymmetric mount-umount logic inherited from
> buildchroot
>     times.
> 
> In this series, cleanup is done in reverse /proc/mounts order to
> unmount e.g. /dev/shm before /dev. This happens to work for us today
> but we could perform stricter semantic ordering if necessary.
> 
> ISAR_FAIL_ON_CLEANUP=1 can be set in the environment to fail builds
> if
> mounts are left behind. We will use this for Isar CI. The default is
> 0.
> 
> p1 comes from 'Additional CI improvements' series.
> Patches p4-p6 come from v2 of 'Start to address umount problems'
> series
> by Jan.
> p7 comes from 'Fix leftover mounts in rootfs.bbclass' by Florian.
> p2, p3 and p8 are new one.
> 
> Anton Mikanovich (4):
>   CI: Do not lose output on bitbake / qemu exit
>   isar-events: Unhide mounts left behind
>   CI: Pass ISAR_FAIL_ON_CLEANUP from environment to bitbake
>   image: Do not call rootfs_do_umounts twice
> 
> Florian Bezdeka (1):
>   rootfs: Add missing umounts in rootfs_postprocess() and
>     rootfs_install()
> 
> Jan Kiszka (3):
>   image: Avoid breaking the build when mounts are no longer present
> on
>     umount
>   rootfs: Provide rootfs_do_umounts
>   initramfs: Add missing umounts after generation
> 
>  RECIPE-API-CHANGELOG.md          | 15 ++++++++
>  meta/classes/image.bbclass       | 19 ----------
>  meta/classes/initramfs.bbclass   |  2 +
>  meta/classes/isar-events.bbclass | 40 ++++++++++++++++----
>  meta/classes/rootfs.bbclass      | 63 ++++++++++++++++++++++++++----
> --
>  testsuite/cibuilder.py           | 13 +++++--
>  6 files changed, 110 insertions(+), 42 deletions(-)
> 
> -- 
> 2.34.1
> 

Applied to next, thanks all.

-- 
Best regards,
Uladzimir.



-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/96f3c61318d93964c175ebd9e3406aa3b3e9712b.camel%40ilbers.de.