From: Andreas Reichel <andreas.reichel@tngtech.com>
To: jan kiszka <jan.kiszka@siemens.com>
Cc: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] isar-image: umount base-apt when doing offline build
Date: Thu, 29 Nov 2018 15:28:44 +0100 (CET) [thread overview]
Message-ID: <972244766.28119253.1543501724198.JavaMail.zimbra@tngtech.com> (raw)
In-Reply-To: <f9f45b91-4775-a1c8-0f9c-e10e6a1b0a7e@siemens.com>
Thanks Jan :)
-------------------------------------------------------------------
Andreas J. Reichel
Dipl.-Phys. (Univ.)
Software Consultant
Andreas.Reichel@tngtech.com
+49-174-3180074
TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterföhring
Geschäftsführer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Müller
Sitz: Unterföhring * Amtsgericht München * HRB 135082
----- Original Message -----
From: "jan kiszka" <jan.kiszka@siemens.com>
To: "isar-users" <isar-users@googlegroups.com>
Cc: "Andreas Reichel" <Andreas.Reichel@tngtech.com>
Sent: Thursday, November 29, 2018 3:19:01 PM
Subject: [PATCH] isar-image: umount base-apt when doing offline build
Leaving it mounted "slightly" increases the target image size.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
meta/classes/isar-image.bbclass | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass
index 7aaaecb..23b3a99 100644
--- a/meta/classes/isar-image.bbclass
+++ b/meta/classes/isar-image.bbclass
@@ -63,6 +63,10 @@ isar_image_cleanup() {
sudo umount -l ${IMAGE_ROOTFS}/proc
sudo umount -R -l ${IMAGE_ROOTFS}/sys
sudo rm -f "${IMAGE_ROOTFS}/etc/apt/apt.conf.d/55isar-fallback.conf"
+ if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then
+ sudo umount -l ${IMAGE_ROOTFS}/base-apt
+ sudo rmdir ${IMAGE_ROOTFS}/base-apt
+ fi
}
python do_rootfs() {
--
2.16.4
next prev parent reply other threads:[~2018-11-29 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 14:19 Jan Kiszka
2018-11-29 14:28 ` Andreas Reichel [this message]
2018-11-29 14:55 ` Jan Kiszka
2018-12-07 13:44 ` Maxim Yu. Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=972244766.28119253.1543501724198.JavaMail.zimbra@tngtech.com \
--to=andreas.reichel@tngtech.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox