* [PATCH] ubi-img/ubifs-img: change fatal error to skip recipe
@ 2019-03-27 15:41 claudius.heine.ext
2019-03-27 15:45 ` Maxim Yu. Osipov
2019-03-28 7:50 ` [PATCH v2] " claudius.heine.ext
0 siblings, 2 replies; 8+ messages in thread
From: claudius.heine.ext @ 2019-03-27 15:41 UTC (permalink / raw)
To: isar-users; +Cc: Claudius Heine
From: Claudius Heine <ch@denx.de>
In machines that have not set those variables, it is stil possible that
those classes are parsed. The parsing itself should not fail in that
case, instead those recipes should just be skipped.
Signed-off-by: Claudius Heine <ch@denx.de>
---
meta/classes/ubi-img.bbclass | 2 +-
meta/classes/ubifs-img.bbclass | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/classes/ubi-img.bbclass b/meta/classes/ubi-img.bbclass
index f61a940..777b8c4 100644
--- a/meta/classes/ubi-img.bbclass
+++ b/meta/classes/ubi-img.bbclass
@@ -5,7 +5,7 @@
python() {
if not d.getVar("UBINIZE_ARGS"):
- bb.fatal("UBINIZE_ARGS must be set")
+ raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set")
}
UBINIZE_CFG ??= "ubinize.cfg"
diff --git a/meta/classes/ubifs-img.bbclass b/meta/classes/ubifs-img.bbclass
index ed37357..881d2bb 100644
--- a/meta/classes/ubifs-img.bbclass
+++ b/meta/classes/ubifs-img.bbclass
@@ -5,7 +5,7 @@
python() {
if not d.getVar("MKUBIFS_ARGS"):
- bb.fatal("MKUBIFS_ARGS must be set")
+ raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set")
}
inherit image
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ubi-img/ubifs-img: change fatal error to skip recipe
2019-03-27 15:41 [PATCH] ubi-img/ubifs-img: change fatal error to skip recipe claudius.heine.ext
@ 2019-03-27 15:45 ` Maxim Yu. Osipov
2019-03-27 17:10 ` Henning Schild
2019-03-28 7:50 ` [PATCH v2] " claudius.heine.ext
1 sibling, 1 reply; 8+ messages in thread
From: Maxim Yu. Osipov @ 2019-03-27 15:45 UTC (permalink / raw)
To: claudius.heine.ext, isar-users; +Cc: Claudius Heine
On 3/27/19 4:41 PM, claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
>
> In machines that have not set those variables, it is stil possible that
> those classes are parsed. The parsing itself should not fail in that
> case, instead those recipes should just be skipped.
Please use spell checker (especially in commit message before submitting
patches).
Maxim.
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
> meta/classes/ubi-img.bbclass | 2 +-
> meta/classes/ubifs-img.bbclass | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/ubi-img.bbclass b/meta/classes/ubi-img.bbclass
> index f61a940..777b8c4 100644
> --- a/meta/classes/ubi-img.bbclass
> +++ b/meta/classes/ubi-img.bbclass
> @@ -5,7 +5,7 @@
>
> python() {
> if not d.getVar("UBINIZE_ARGS"):
> - bb.fatal("UBINIZE_ARGS must be set")
> + raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set")
> }
>
> UBINIZE_CFG ??= "ubinize.cfg"
> diff --git a/meta/classes/ubifs-img.bbclass b/meta/classes/ubifs-img.bbclass
> index ed37357..881d2bb 100644
> --- a/meta/classes/ubifs-img.bbclass
> +++ b/meta/classes/ubifs-img.bbclass
> @@ -5,7 +5,7 @@
>
> python() {
> if not d.getVar("MKUBIFS_ARGS"):
> - bb.fatal("MKUBIFS_ARGS must be set")
> + raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set")
> }
>
> inherit image
>
--
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ubi-img/ubifs-img: change fatal error to skip recipe
2019-03-27 15:45 ` Maxim Yu. Osipov
@ 2019-03-27 17:10 ` Henning Schild
2019-03-27 17:12 ` Maxim Yu. Osipov
0 siblings, 1 reply; 8+ messages in thread
From: Henning Schild @ 2019-03-27 17:10 UTC (permalink / raw)
To: Maxim Yu. Osipov; +Cc: claudius.heine.ext, isar-users, Claudius Heine
Am Wed, 27 Mar 2019 16:45:08 +0100
schrieb "Maxim Yu. Osipov" <mosipov@ilbers.de>:
> On 3/27/19 4:41 PM, claudius.heine.ext@siemens.com wrote:
> > From: Claudius Heine <ch@denx.de>
> >
> > In machines that have not set those variables, it is stil possible
> > that those classes are parsed. The parsing itself should not fail
> > in that case, instead those recipes should just be skipped.
>
> Please use spell checker (especially in commit message before
> submitting patches).
Please use _a_ spell checker when being that picky ;).
Henning
> Maxim.
>
> > Signed-off-by: Claudius Heine <ch@denx.de>
> > ---
> > meta/classes/ubi-img.bbclass | 2 +-
> > meta/classes/ubifs-img.bbclass | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta/classes/ubi-img.bbclass
> > b/meta/classes/ubi-img.bbclass index f61a940..777b8c4 100644
> > --- a/meta/classes/ubi-img.bbclass
> > +++ b/meta/classes/ubi-img.bbclass
> > @@ -5,7 +5,7 @@
> >
> > python() {
> > if not d.getVar("UBINIZE_ARGS"):
> > - bb.fatal("UBINIZE_ARGS must be set")
> > + raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set")
> > }
> >
> > UBINIZE_CFG ??= "ubinize.cfg"
> > diff --git a/meta/classes/ubifs-img.bbclass
> > b/meta/classes/ubifs-img.bbclass index ed37357..881d2bb 100644
> > --- a/meta/classes/ubifs-img.bbclass
> > +++ b/meta/classes/ubifs-img.bbclass
> > @@ -5,7 +5,7 @@
> >
> > python() {
> > if not d.getVar("MKUBIFS_ARGS"):
> > - bb.fatal("MKUBIFS_ARGS must be set")
> > + raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set")
> > }
> >
> > inherit image
> >
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ubi-img/ubifs-img: change fatal error to skip recipe
2019-03-27 17:10 ` Henning Schild
@ 2019-03-27 17:12 ` Maxim Yu. Osipov
0 siblings, 0 replies; 8+ messages in thread
From: Maxim Yu. Osipov @ 2019-03-27 17:12 UTC (permalink / raw)
To: Henning Schild; +Cc: claudius.heine.ext, isar-users, Claudius Heine
On 3/27/19 6:10 PM, Henning Schild wrote:
> Am Wed, 27 Mar 2019 16:45:08 +0100
> schrieb "Maxim Yu. Osipov" <mosipov@ilbers.de>:
>
>> On 3/27/19 4:41 PM, claudius.heine.ext@siemens.com wrote:
>>> From: Claudius Heine <ch@denx.de>
>>>
>>> In machines that have not set those variables, it is stil possible
>>> that those classes are parsed. The parsing itself should not fail
>>> in that case, instead those recipes should just be skipped.
>>
>> Please use spell checker (especially in commit message before
>> submitting patches).
>
> Please use _a_ spell checker when being that picky ;).
Yep, but this missing 'a' doesn't go to the commit message :).
Maxim.
> Henning
>
>> Maxim.
>>
>>> Signed-off-by: Claudius Heine <ch@denx.de>
>>> ---
>>> meta/classes/ubi-img.bbclass | 2 +-
>>> meta/classes/ubifs-img.bbclass | 2 +-
>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/meta/classes/ubi-img.bbclass
>>> b/meta/classes/ubi-img.bbclass index f61a940..777b8c4 100644
>>> --- a/meta/classes/ubi-img.bbclass
>>> +++ b/meta/classes/ubi-img.bbclass
>>> @@ -5,7 +5,7 @@
>>>
>>> python() {
>>> if not d.getVar("UBINIZE_ARGS"):
>>> - bb.fatal("UBINIZE_ARGS must be set")
>>> + raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set")
>>> }
>>>
>>> UBINIZE_CFG ??= "ubinize.cfg"
>>> diff --git a/meta/classes/ubifs-img.bbclass
>>> b/meta/classes/ubifs-img.bbclass index ed37357..881d2bb 100644
>>> --- a/meta/classes/ubifs-img.bbclass
>>> +++ b/meta/classes/ubifs-img.bbclass
>>> @@ -5,7 +5,7 @@
>>>
>>> python() {
>>> if not d.getVar("MKUBIFS_ARGS"):
>>> - bb.fatal("MKUBIFS_ARGS must be set")
>>> + raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set")
>>> }
>>>
>>> inherit image
>>>
>>
>>
>
--
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] ubi-img/ubifs-img: change fatal error to skip recipe
2019-03-27 15:41 [PATCH] ubi-img/ubifs-img: change fatal error to skip recipe claudius.heine.ext
2019-03-27 15:45 ` Maxim Yu. Osipov
@ 2019-03-28 7:50 ` claudius.heine.ext
2019-04-24 8:48 ` Claudius Heine
1 sibling, 1 reply; 8+ messages in thread
From: claudius.heine.ext @ 2019-03-28 7:50 UTC (permalink / raw)
To: isar-users; +Cc: Claudius Heine
From: Claudius Heine <ch@denx.de>
In machines that have not set those variables, it is still possible that
those classes are parsed. The parsing itself should not fail in that
case, instead those recipes should just be skipped.
Signed-off-by: Claudius Heine <ch@denx.de>
---
meta/classes/ubi-img.bbclass | 2 +-
meta/classes/ubifs-img.bbclass | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/classes/ubi-img.bbclass b/meta/classes/ubi-img.bbclass
index f61a940..777b8c4 100644
--- a/meta/classes/ubi-img.bbclass
+++ b/meta/classes/ubi-img.bbclass
@@ -5,7 +5,7 @@
python() {
if not d.getVar("UBINIZE_ARGS"):
- bb.fatal("UBINIZE_ARGS must be set")
+ raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set")
}
UBINIZE_CFG ??= "ubinize.cfg"
diff --git a/meta/classes/ubifs-img.bbclass b/meta/classes/ubifs-img.bbclass
index ed37357..881d2bb 100644
--- a/meta/classes/ubifs-img.bbclass
+++ b/meta/classes/ubifs-img.bbclass
@@ -5,7 +5,7 @@
python() {
if not d.getVar("MKUBIFS_ARGS"):
- bb.fatal("MKUBIFS_ARGS must be set")
+ raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set")
}
inherit image
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ubi-img/ubifs-img: change fatal error to skip recipe
2019-03-28 7:50 ` [PATCH v2] " claudius.heine.ext
@ 2019-04-24 8:48 ` Claudius Heine
2019-04-25 5:50 ` Maxim Yu. Osipov
0 siblings, 1 reply; 8+ messages in thread
From: Claudius Heine @ 2019-04-24 8:48 UTC (permalink / raw)
To: isar-users; +Cc: Claudius Heine
ping
On 28/03/2019 08.50, [ext] claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
>
> In machines that have not set those variables, it is still possible that
> those classes are parsed. The parsing itself should not fail in that
> case, instead those recipes should just be skipped.
>
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
> meta/classes/ubi-img.bbclass | 2 +-
> meta/classes/ubifs-img.bbclass | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/ubi-img.bbclass b/meta/classes/ubi-img.bbclass
> index f61a940..777b8c4 100644
> --- a/meta/classes/ubi-img.bbclass
> +++ b/meta/classes/ubi-img.bbclass
> @@ -5,7 +5,7 @@
>
> python() {
> if not d.getVar("UBINIZE_ARGS"):
> - bb.fatal("UBINIZE_ARGS must be set")
> + raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set")
> }
>
> UBINIZE_CFG ??= "ubinize.cfg"
> diff --git a/meta/classes/ubifs-img.bbclass b/meta/classes/ubifs-img.bbclass
> index ed37357..881d2bb 100644
> --- a/meta/classes/ubifs-img.bbclass
> +++ b/meta/classes/ubifs-img.bbclass
> @@ -5,7 +5,7 @@
>
> python() {
> if not d.getVar("MKUBIFS_ARGS"):
> - bb.fatal("MKUBIFS_ARGS must be set")
> + raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set")
> }
>
> inherit image
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ubi-img/ubifs-img: change fatal error to skip recipe
2019-04-24 8:48 ` Claudius Heine
@ 2019-04-25 5:50 ` Maxim Yu. Osipov
2019-07-23 15:29 ` Henning Schild
0 siblings, 1 reply; 8+ messages in thread
From: Maxim Yu. Osipov @ 2019-04-25 5:50 UTC (permalink / raw)
To: Claudius Heine, isar-users; +Cc: Claudius Heine
On 4/24/19 10:48 AM, Claudius Heine wrote:
> ping
>
> On 28/03/2019 08.50, [ext] claudius.heine.ext@siemens.com wrote:
>> From: Claudius Heine <ch@denx.de>
>>
>> In machines that have not set those variables, it is still possible that
>> those classes are parsed. The parsing itself should not fail in that
>> case, instead those recipes should just be skipped.
Rebased and applied to the 'next'.
Maxim.
>> Signed-off-by: Claudius Heine <ch@denx.de>
>> ---
>> meta/classes/ubi-img.bbclass | 2 +-
>> meta/classes/ubifs-img.bbclass | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/classes/ubi-img.bbclass b/meta/classes/ubi-img.bbclass
>> index f61a940..777b8c4 100644
>> --- a/meta/classes/ubi-img.bbclass
>> +++ b/meta/classes/ubi-img.bbclass
>> @@ -5,7 +5,7 @@
>> python() {
>> if not d.getVar("UBINIZE_ARGS"):
>> - bb.fatal("UBINIZE_ARGS must be set")
>> + raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set")
>> }
>> UBINIZE_CFG ??= "ubinize.cfg"
>> diff --git a/meta/classes/ubifs-img.bbclass
>> b/meta/classes/ubifs-img.bbclass
>> index ed37357..881d2bb 100644
>> --- a/meta/classes/ubifs-img.bbclass
>> +++ b/meta/classes/ubifs-img.bbclass
>> @@ -5,7 +5,7 @@
>> python() {
>> if not d.getVar("MKUBIFS_ARGS"):
>> - bb.fatal("MKUBIFS_ARGS must be set")
>> + raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set")
>> }
>> inherit image
>>
>
--
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ubi-img/ubifs-img: change fatal error to skip recipe
2019-04-25 5:50 ` Maxim Yu. Osipov
@ 2019-07-23 15:29 ` Henning Schild
0 siblings, 0 replies; 8+ messages in thread
From: Henning Schild @ 2019-07-23 15:29 UTC (permalink / raw)
To: Maxim Yu. Osipov
Cc: Claudius Heine, isar-users, Claudius Heine, Gylstorff,
Quirin (CT RDA IOT SES-DE)
Am Thu, 25 Apr 2019 08:50:57 +0300
schrieb "Maxim Yu. Osipov" <mosipov@ilbers.de>:
> On 4/24/19 10:48 AM, Claudius Heine wrote:
> > ping
> >
> > On 28/03/2019 08.50, [ext] claudius.heine.ext@siemens.com wrote:
> >> From: Claudius Heine <ch@denx.de>
> >>
> >> In machines that have not set those variables, it is still
> >> possible that those classes are parsed. The parsing itself should
> >> not fail in that case, instead those recipes should just be
> >> skipped.
>
> Rebased and applied to the 'next'.
That rebase actually caused the problem that Quirin just found. The
patch from Claudius does not contain the bug just found.
Henning
>
> Maxim.
>
> >> Signed-off-by: Claudius Heine <ch@denx.de>
> >> ---
> >> meta/classes/ubi-img.bbclass | 2 +-
> >> meta/classes/ubifs-img.bbclass | 2 +-
> >> 2 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/meta/classes/ubi-img.bbclass
> >> b/meta/classes/ubi-img.bbclass index f61a940..777b8c4 100644
> >> --- a/meta/classes/ubi-img.bbclass
> >> +++ b/meta/classes/ubi-img.bbclass
> >> @@ -5,7 +5,7 @@
> >> python() {
> >> if not d.getVar("UBINIZE_ARGS"):
> >> - bb.fatal("UBINIZE_ARGS must be set")
> >> + raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set")
> >> }
> >> UBINIZE_CFG ??= "ubinize.cfg"
> >> diff --git a/meta/classes/ubifs-img.bbclass
> >> b/meta/classes/ubifs-img.bbclass
> >> index ed37357..881d2bb 100644
> >> --- a/meta/classes/ubifs-img.bbclass
> >> +++ b/meta/classes/ubifs-img.bbclass
> >> @@ -5,7 +5,7 @@
> >> python() {
> >> if not d.getVar("MKUBIFS_ARGS"):
> >> - bb.fatal("MKUBIFS_ARGS must be set")
> >> + raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set")
> >> }
> >> inherit image
> >>
> >
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-07-23 15:29 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-27 15:41 [PATCH] ubi-img/ubifs-img: change fatal error to skip recipe claudius.heine.ext
2019-03-27 15:45 ` Maxim Yu. Osipov
2019-03-27 17:10 ` Henning Schild
2019-03-27 17:12 ` Maxim Yu. Osipov
2019-03-28 7:50 ` [PATCH v2] " claudius.heine.ext
2019-04-24 8:48 ` Claudius Heine
2019-04-25 5:50 ` Maxim Yu. Osipov
2019-07-23 15:29 ` Henning Schild
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox