From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6673096226406137856 X-Received: by 2002:a1c:f214:: with SMTP id s20mr465260wmc.20.1553706771435; Wed, 27 Mar 2019 10:12:51 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:540a:: with SMTP id g10ls1249095wrv.14.gmail; Wed, 27 Mar 2019 10:12:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqzjzHGj6rTgO+j/XwzTcxhlRVoOTzX9GCX632ModJYpSJrUNYvquCfJuRs4L5Xsw6kGj47E X-Received: by 2002:adf:fb0c:: with SMTP id c12mr631980wrr.28.1553706771000; Wed, 27 Mar 2019 10:12:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553706770; cv=none; d=google.com; s=arc-20160816; b=Er4VhAindl6LN9fiZMJc4c9v8EBZqyWhFFLzsCgOCy8zk/i5qjAqE6dzIVURSNO3fC iGKFkqUeLqq4A0iDiQpux+wIx458nK/feMG6lzPwPZvUsc6JbtCj5qn4HjlxRafT226w N9AqrYN2OFSF6s/LRLwhPRhtp2VJhYLmEUO1fTpV+cSViPEBpNbKK5h6eNEKZUdRFqo3 VTda1ouy0zkPafsfvyoeRKAOpiMwx4O7WO7JWmPi9PhSiIlAiswBjNkMPqsqF5MyclM6 iJjACxzBt/KRIyLjR0x3Q6v1hrYvhI7eEy17xXHuGBnK0QyX/NG7BlLMRWrMzz3C4A5b ya4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:cc:to :subject; bh=q6frSExbMpnB+3z4hCvvh6h2sDLJJFPpRZf3A4xSFYw=; b=YMWVISasOmzZR8vv8N0y300I0swex7uJjp805jNvGYqj/pgCs0POTzvJjYUaUuXiC6 n8nR3o4Wyj+0MsZL+DgNybbEv62sKF9rQjNd57B6gXozLorBuYtk2GYxmEIg7mRGJTvU aJudV/noihlDFNEsJsv7x0RjPIkMSZS2SopQT2prwXIwlD9d59/ywMaSqtLhDCUbJW4B lv2IT22XKdVmCUJ3bd3mgXbrLLi4uNwkna5Z0M1KMJgymELOb9sdIwZLGRqg63eufQh8 vHZ0N83mpR1hKa1FiUf7IVJdq5cUvuLH2MpzVYf8OamSOZbGh8ACfglDJ1OPAVF8x7IE jikw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id v17si328930wmc.4.2019.03.27.10.12.50 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 10:12:50 -0700 (PDT) Received-SPF: pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.1.3] (221.18-242-81.adsl-dyn.isp.belgacom.be [81.242.18.221]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x2RHCnBB000395 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Mar 2019 18:12:49 +0100 Subject: Re: [PATCH] ubi-img/ubifs-img: change fatal error to skip recipe To: Henning Schild Cc: claudius.heine.ext@siemens.com, isar-users@googlegroups.com, Claudius Heine References: <20190327154124.14663-1-claudius.heine.ext@siemens.com> <5c5d2c74-6585-1481-0ce4-6be4e898e708@ilbers.de> <20190327181027.78a0b9ca@md1za8fc.ad001.siemens.net> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <974cecdd-349f-8c99-60cf-b883ee6ce0e0@ilbers.de> Date: Wed, 27 Mar 2019 18:12:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190327181027.78a0b9ca@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: lQhLlnv9vaBY On 3/27/19 6:10 PM, Henning Schild wrote: > Am Wed, 27 Mar 2019 16:45:08 +0100 > schrieb "Maxim Yu. Osipov" : > >> On 3/27/19 4:41 PM, claudius.heine.ext@siemens.com wrote: >>> From: Claudius Heine >>> >>> In machines that have not set those variables, it is stil possible >>> that those classes are parsed. The parsing itself should not fail >>> in that case, instead those recipes should just be skipped. >> >> Please use spell checker (especially in commit message before >> submitting patches). > > Please use _a_ spell checker when being that picky ;). Yep, but this missing 'a' doesn't go to the commit message :). Maxim. > Henning > >> Maxim. >> >>> Signed-off-by: Claudius Heine >>> --- >>> meta/classes/ubi-img.bbclass | 2 +- >>> meta/classes/ubifs-img.bbclass | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/meta/classes/ubi-img.bbclass >>> b/meta/classes/ubi-img.bbclass index f61a940..777b8c4 100644 >>> --- a/meta/classes/ubi-img.bbclass >>> +++ b/meta/classes/ubi-img.bbclass >>> @@ -5,7 +5,7 @@ >>> >>> python() { >>> if not d.getVar("UBINIZE_ARGS"): >>> - bb.fatal("UBINIZE_ARGS must be set") >>> + raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set") >>> } >>> >>> UBINIZE_CFG ??= "ubinize.cfg" >>> diff --git a/meta/classes/ubifs-img.bbclass >>> b/meta/classes/ubifs-img.bbclass index ed37357..881d2bb 100644 >>> --- a/meta/classes/ubifs-img.bbclass >>> +++ b/meta/classes/ubifs-img.bbclass >>> @@ -5,7 +5,7 @@ >>> >>> python() { >>> if not d.getVar("MKUBIFS_ARGS"): >>> - bb.fatal("MKUBIFS_ARGS must be set") >>> + raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set") >>> } >>> >>> inherit image >>> >> >> > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov