From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6527286083495919616 X-Received: by 10.46.145.150 with SMTP id f22mr424959ljg.13.1520008250371; Fri, 02 Mar 2018 08:30:50 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.25.105.3 with SMTP id e3ls1154234lfc.14.gmail; Fri, 02 Mar 2018 08:30:49 -0800 (PST) X-Google-Smtp-Source: AG47ELsqdhxX6VoKUIyMHq7DY0OA7nCW3S2/irIKHFlPZFroChjHyZvXRqeZZqfXRt+cRAwV1f+p X-Received: by 10.25.32.8 with SMTP id g8mr470803lfg.13.1520008249613; Fri, 02 Mar 2018 08:30:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520008249; cv=none; d=google.com; s=arc-20160816; b=O5TGFlxtcteF09TZDazR/Aa9evopSFcQVvobC1A5TYP4LXasmnJYvjx+jxG6LRG0tP TgMwDYYz4TzilcsCv4xBwjiQ44y78D7R5WQSYhk2pktK+AKwsrhrIvMBe4tE21pa7vIN ImtlrC3rXPFtLankN8VnyhY112RFAwoZZTaf+fgvqcEjGzGWF4f7zp3J8ye4e9Z6PzmX eMo3hoa6Z5CGTg6s6d2ug5Vt3K4R8JqBZv263KRrp1vMOs0UWPgKXIho0pgqexd5ZFEJ M3oUE02vvKPR9MybPJrRD5Oby/F7BOGH3vDDTWPGreLnAf5fnnEYN0zfcPG32XIR7vI8 0rkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=1spV6rmW610RcNymDcBm/8YRrqNJ83VOUidHU0/z9TQ=; b=xdsMvWtdtF59lYd7EXoF3DbtBUCVK+we6QlX35NEiJB4OeB2d8aL6W1YWxXfPnXeC/ lx+w77hPCP4C3V3L/SOHfXpUJKuABhTTlooa8yAeK5U636H9W1rysPyZx9uKq2uy/XAj j7XIPxebgJ6lY2qwTtlwejvJX7FC5EtGxn3VknUA9Fq+4jQSpc47TgztNocJRmHSVOZR bvrVzsKd7IYflXyg2fnWR4EqA4XN36Llk5iwwwEXIeb1e5uh/7mJ8uXZxdiJIFo3ijft Sh9QRMIssIG/Q2VmVni+JpjSLLQUIaveReVKyLDS9VdXTr7L96n93B60B9mCyHQbrZ3h fAmQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id u72si278108lfi.4.2018.03.02.08.30.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Mar 2018 08:30:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w22GUkED014472 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 2 Mar 2018 17:30:47 +0100 Subject: Re: [PATCH] meta: image: detect broken symlinks To: Henning Schild , isar-users@googlegroups.com References: <20180227172336.19786-1-henning.schild@siemens.com> From: Alexander Smirnov Message-ID: <976515bd-b435-879f-9a57-84078d9c6149@ilbers.de> Date: Fri, 2 Mar 2018 19:30:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20180227172336.19786-1-henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: ePJZ0BxGNrNH On 02/27/2018 08:23 PM, Henning Schild wrote: > Switch get_image_name from os.path.lexists to os.path.exists because the > latter detects broken symlinks correctly. > > Issue: > If you build a kernel without CONFIG_BLK_DEV_INITRD the postinst hook will > still call "linux-update-symlinks" and create a broken symlink. After > that os.path.lexists will return True and "sudo cp" in do_copy_boot_files > will fail. > Applied, thanks. P.S.: fixed to upper case after semicolon in patch topic. Alex