From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6530156151538974720 X-Received: by 10.28.106.16 with SMTP id f16mr1754395wmc.10.1520421866704; Wed, 07 Mar 2018 03:24:26 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.45.136 with SMTP id t130ls353218wmt.7.gmail; Wed, 07 Mar 2018 03:24:26 -0800 (PST) X-Google-Smtp-Source: AG47ELv/g9mgQkcPoJii37jjp5Q5GOpRzpGxMA62tXSPNoHncpe8+wev5sh5WtNFq/aXw21HOn9J X-Received: by 10.28.144.17 with SMTP id s17mr501423wmd.29.1520421866130; Wed, 07 Mar 2018 03:24:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520421866; cv=none; d=google.com; s=arc-20160816; b=bBoqYfMKWyGXtKEUsXzplqbkbt78M/L2mQ0dZcoZt7TvSXTTIfnmuFB4toRi+KXBQ2 jZAvYxYxrkgMWjTRIxf+cvLR4xm6aYU/ozRa3+vj3GAIrFZ6yVW49I/saEqp4gGnQ/Zz QTb/yqmjxdyWL3E52wgWktP3YgvUp8S/MC6yuhCoeKNakf8ePLJ23aBh3LYPW/gLsX2u sOf87O6dcSG1P7f9G7DNoIztOIkknj1S16mLUt9Iwb266ugPMy2ivUBWv2ul3SPIe72Z 5Dm+qaRHK/W76daiT4mHzilVHULiE1S6XET3QZf6SI+sTd5R5qZKAJGo1TWSfOHZITGS VPtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=Jd9U0OmEPYJNzZUjIA131Eod4UB7boW9CsoY6MmihTc=; b=LJ/6JQkydnVKF0AHiZKFI7xXsZ0LN4FWv0l3f4Dyq4LI0zOQkCbroQssC4VnQatFP6 1WUfdsXFwEErzS+/+vUCcYETFbTSrrhW1s3CqtOruxo1PYOlRsFjTf32+aVp+6YDMqN8 2JxC0dC1TQN7FZJZPp9QjKBcCy2RuRFtM2Nr6kkWEe6mmACn8lxQL79LJkGzkiflnGCF b+nBEa7gqv2ylwJFQt5aU5fx3+f2TWNuXlIX4jZxN3g0QoLkjseEPyGQnXwJdaw8IovE gzQTaeuUOjL8KVG7g8ZVgfx51nGcoj4BxpiNr3J96qrxcZLl6smP4cBu6x+wDDAVgw3u KERg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id d4si72309wmh.2.2018.03.07.03.24.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Mar 2018 03:24:26 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w27BOPtf018990 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 7 Mar 2018 12:24:25 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id w27BOP8a030565; Wed, 7 Mar 2018 12:24:25 +0100 Subject: Re: [PATCH 1/1] isar-events: try unmounting all mounts before returning an error To: Cedric Hombourger , isar-users@googlegroups.com References: <20180307110049.43760-1-Cedric_Hombourger@mentor.com> <20180307110049.43760-2-Cedric_Hombourger@mentor.com> From: Jan Kiszka Message-ID: <977ddcc3-508c-ca08-d813-5b7b05ea249b@siemens.com> Date: Wed, 7 Mar 2018 12:24:24 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20180307110049.43760-2-Cedric_Hombourger@mentor.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: wgY36F0URdXd On 2018-03-07 12:00, Cedric Hombourger wrote: > Isar would loop forever if a mount cannot be unmounted because another > bind mount was done underneath it (e.g. /sys/devices on top > of /sys). Increase of chances of success by trying to unmount > everything before returning an error. In the /sys/dev case, > we may try /sys first and fail but would continue to unmount > /sys/dev. On the following call, only /sys will remain > and the unmount_all should now succeed. We may want to implement a > timeout: e.g. giveup after 30 tries (i.e. approximately 30 seconds)? > > Signed-off-by: Cedric Hombourger > --- > meta/classes/isar-events.bbclass | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass > index 29c7437..b3ce434 100644 > --- a/meta/classes/isar-events.bbclass > +++ b/meta/classes/isar-events.bbclass > @@ -14,14 +14,15 @@ python isar_handler () { > # '/proc/mounts' contains all the active mounts, so knowing basepath > # we can get the list of mounts for the specific multiconfig and > # clean them. > + result = True > with open('/proc/mounts', 'rU') as f: > for line in f: > if basepath in line: > if subprocess.call('sudo umount ' + line.split()[1], > stdout=devnull, stderr=devnull, > shell=True) != 0: > - return False > - return True > + result = False > + return result > > devnull = open(os.devnull, 'w') > > This is by design because it gives us more time when waiting for pending build steps. The problem is that things like multistrap can continue to run in the background, no longer under the control of cooker daemon, and we should wait for them to terminate before Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux