From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6691586504498610176 X-Received: by 2002:adf:b613:: with SMTP id f19mr467242wre.192.1565798457226; Wed, 14 Aug 2019 09:00:57 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:283:: with SMTP id 3ls951647wmk.5.canary-gmail; Wed, 14 Aug 2019 09:00:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqyzrZKgA99w0pkwDbsj0eXa3LxZVf8cMwPnA8vyA41xkZUFu5rbKEurVJKPH+/Wt5uBl/f3 X-Received: by 2002:a05:600c:2245:: with SMTP id a5mr9241649wmm.121.1565798456581; Wed, 14 Aug 2019 09:00:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565798456; cv=none; d=google.com; s=arc-20160816; b=OwM8xRrgmOknyoJKnhgPSW3y3lxABrMvjCwvoot5FUFvA51PjWkqsbo7zFIHUgZHL3 zX0xlL2sgWRhhV5IA1vl3SzHbAECvIhcFM2ot2FGYLNXSsqWIvfXJpcv2+BXhSJ2m7E/ OWP4jyBsrVkH+BSFkCo0g5JnAORn9WtbycYVsglLnTVne2/nyy9Q8CsizP5ExFSud3At bZo/A3sxL23wl9R6xbaU+gmwAniI3b8WGVjdgh0O1UFFBzjj0kOa2CS5+8RefgfL1TfS YFWc6gAaW/OCLc0hadrwOhzqRng4AzNxCJYJuWe5lMndLRpa8+ztjr4UJRMc0EaHC52n sqWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=xZ23drouCSDXkk78j0NrWvyDImUKfAONJvp4q1Q2WJk=; b=O/yS0Y9+2qi6C4aB+2E8oXiX+zkzc7VDEtI1LMUqCKaTqTJ3Rd8p1/pgZXawt9SxG4 nDgHLQKQlnnIhybiwlbPf7soMBgp2tmpLmQqp8Z2NZdsm7MEtYHYfgEQJe5P9oxWKxun xEAaHfPPr9s6Rh8s4728gm3n9NUze4Dnu0Th3YHmwvSt70V1oUs4osxCxAPAgGkUhJQP RDzOmZ9G6e3NMDSWJHT1J0YiVcyojJ29i4GHSEQ8Y9WifFqgj3NPjYnlS1uXE8E5hW3P MlR9m+d6OxYrYaCVrltS31YE3BZM4sLXBoIdqL3GPciFSfDm3eazWijqLQ5gcwwU5JAd 4pew== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id g7si318021wmk.0.2019.08.14.09.00.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Aug 2019 09:00:56 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x7EG0taV018452 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Aug 2019 18:00:55 +0200 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x7EG0sbL013031; Wed, 14 Aug 2019 18:00:54 +0200 Subject: Re: [PATCH v4 2/8] split up isar-bootstrap helper and implement pre-process pipeline To: "[ext] claudius.heine.ext@siemens.com" , isar-users@googlegroups.com Cc: Claudius Heine References: <20190523145521.23050-1-claudius.heine.ext@siemens.com> <20190523145521.23050-3-claudius.heine.ext@siemens.com> From: Jan Kiszka Message-ID: <9854b2df-897d-393a-e968-e23fccbb67a1@siemens.com> Date: Wed, 14 Aug 2019 18:00:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190523145521.23050-3-claudius.heine.ext@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: sq4EVIin085o On 23.05.19 16:55, [ext] claudius.heine.ext@siemens.com wrote: > From: Claudius Heine > > This removes the isar-bootstrap-helper.bbclass and integrates its > functionality into the rootfs.bbclass. > > It introduces the rootfs_install task that runs through multiple > functions from command lists in order to allow easy integration of > custom functions. > > The introduced functions are, in general order of execution: > > rootfs_prepare: copy the isar-bootstrap rootfs base to workdir > rootfs_configure_*: basic configuration of the root file system, > before any custom packages where installed. (`/dev`, `/proc`, etc. > are not mounted). Functions are added to `ROOTFS_CONFIGURE_COMMAND`. > rootfs_do_mount: mount standard directories and repositories into the > rootfs > do_rootfs_install_*: downloading and installing packages. Functions > are added to `ROOTFS_INSTALL_COMMAND`. > > Signed-off-by: Claudius Heine > --- > meta/classes/image.bbclass | 24 +-- > meta/classes/isar-bootstrap-helper.bbclass | 132 -------------- > meta/classes/rootfs.bbclass | 172 +++++++++++++++++- > .../isar-bootstrap/isar-bootstrap.inc | 5 + > .../buildchroot/buildchroot-host.bb | 16 +- > .../buildchroot/buildchroot-target.bb | 2 - > .../buildchroot/buildchroot.inc | 26 ++- > meta/recipes-devtools/sdkchroot/sdkchroot.bb | 48 ++--- > 8 files changed, 228 insertions(+), 197 deletions(-) > delete mode 100644 meta/classes/isar-bootstrap-helper.bbclass > [...] > diff --git a/meta/recipes-devtools/buildchroot/buildchroot-host.bb b/meta/recipes-devtools/buildchroot/buildchroot-host.bb > index 73cd548..121992c 100644 > --- a/meta/recipes-devtools/buildchroot/buildchroot-host.bb > +++ b/meta/recipes-devtools/buildchroot/buildchroot-host.bb > @@ -7,6 +7,8 @@ DESCRIPTION = "Isar development filesystem for host" > PF = "${PN}-${HOST_DISTRO}-${HOST_ARCH}-${DISTRO_ARCH}" > > require buildchroot.inc > +ROOTFS_ARCH = "${HOST_ARCH}" > +ROOTFS_DISTRO = "${HOST_DISTRO}" > > BUILDCHROOT_PREINSTALL ?= "make \ > debhelper \ > @@ -18,15 +20,5 @@ BUILDCHROOT_PREINSTALL ?= "make \ > automake \ > devscripts \ > equivs \ > - libc6:${DISTRO_ARCH}" > - > -# According to the wiki page: > -# https://wiki.debian.org/CrossToolchains > -BUILDCHROOT_PREINSTALL_append_armhf += "binutils-arm-linux-gnueabihf \ > - crossbuild-essential-armhf" > -BUILDCHROOT_PREINSTALL_append_arm64 += "binutils-aarch64-linux-gnu \ > - crossbuild-essential-arm64" Where did binutils go after this patch? Don't we need them? Wondering because there is no remark in the commit why they were removed. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux