From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7192322883099557888 X-Received: by 2002:a92:3f07:0:b0:310:d43c:edf1 with SMTP id m7-20020a923f07000000b00310d43cedf1mr1796455ila.34.1675413235772; Fri, 03 Feb 2023 00:33:55 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a6b:7109:0:b0:729:275d:371f with SMTP id q9-20020a6b7109000000b00729275d371fls747401iog.2.-pod-prod-gmail; Fri, 03 Feb 2023 00:33:55 -0800 (PST) X-Google-Smtp-Source: AK7set9xTuc5ARQlX7WGMyHGy1TdWrVtbPA9vkJUvL71/ADP5XtAWKxqTDf7jqmpg+rRxOhqkWI2 X-Received: by 2002:a6b:da1a:0:b0:6e4:80fc:4885 with SMTP id x26-20020a6bda1a000000b006e480fc4885mr7292334iob.4.1675413235060; Fri, 03 Feb 2023 00:33:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675413235; cv=none; d=google.com; s=arc-20160816; b=MlVNZuG4cvueIsSHOz6o2HpN+qtbKMwoxUobCduW8ASeMyYV5xeBvtyKWbEWAHOemC LOZt6pPytqWGpKStuxkNs/U+W9ylXPp9I+JidamJg73lKBNe0eh7lEB2n5pA/+MLy4Ue Prgi1UJtWpYICBfy806AQVLbuC6TRODimx71izvCeu5oQAM8YILHm3FQv+iB6lOTBzUY O4w+1V3ASL7E8JGdD/kCG1BVgbJeIBzb3BogdXq+dbfgq3OFnU3gRemn0WHKanPjH5Hm vfpu8nmxgQa5k+EuwvZp7oScuMf0P8ud5i8EgwXzPUBgvZPS3bx5jJGY1NitsY04oCrp IQPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=t0BfPPM/QSpqjwpCKRPAY8NgivCksSgvp15KY56YZQ4=; b=ZmirRsJQdC5jl6k+L7oNywSkdwzv+ZWgPbdDInETVCZDbRQooz5mZ9Q4YEgDXeJLWX nO3cbXLA+9UNpL9cseQzoGFsIY8MrJ0GoaArgO7F/Ws/Sbrtw202eAgY32fBWnbxj57S AYn7DD+pdP9Fuyas38KA/4Zb6roKhTrBLlIGrKRG3+7sHvezsmhO1E/fHucKzcDwyG4P 4xFYS+k6QBWfvWQgMd7YZH5uprP8dE1jvcbryWme/ZwBnznLcptIgwQUK32amqaSWaT/ 6eNn2okxN/ZEh5qQnEXC3kTGpNDDIQ0DGvZ4PoZ6v8CQ6xU2pJlFBE+mrpLk6QtToHDQ w+Sw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id o184-20020a6bbec1000000b00722c80c69d5si147868iof.4.2023.02.03.00.33.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Feb 2023 00:33:55 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from hp.localnet (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 3138XpLO024904 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 3 Feb 2023 09:33:52 +0100 From: Uladzimir Bely To: isar-users@googlegroups.com Cc: Uladzimir Bely , "Schild, Henning" Subject: Re: [PATCH v3 07/15] CI: install qemu-system when qemu testing is requested Date: Fri, 03 Feb 2023 11:33:38 +0300 Message-ID: <9864451.tdPhlSkOF2@hp> In-Reply-To: <20230203044427.32711-8-ubely@ilbers.de> References: <20230203044427.32711-1-ubely@ilbers.de> <20230203044427.32711-8-ubely@ilbers.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: uk6VVqrybDg2 In mail from Friday, 3 February 2023 07:44:18 +03 user Uladzimir Bely wrote: > From: Henning Schild > > And also change gitlab ci config to request qemu testing. > > Signed-off-by: Henning Schild > Signed-off-by: Anton Mikanovich > --- > .gitlab-ci.yml | 4 ++-- > scripts/ci_build.sh | 5 +++++ > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index fcdefa87..6a49ce43 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -27,7 +27,7 @@ fast-ci: > except: > - schedules > script: > - - scripts/ci_build.sh -q -f -n > + - scripts/ci_build.sh -q -f > > full-ci: > <<: *common-build > @@ -37,7 +37,7 @@ full-ci: > - PREVIOUS_SHA="$(cat .CI_COMMIT_SHA || true)" > - if [ "$CI_COMMIT_SHA" != "$PREVIOUS_SHA" ]; then > echo "$CI_COMMIT_SHA" > .CI_COMMIT_SHA; > - scripts/ci_build.sh -q -c -r -n; > + scripts/ci_build.sh -q -c -r; > fi > cache: > key: "$CI_COMMIT_REF_SLUG" > diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh > index e5f20d4f..960ee94e 100755 > --- a/scripts/ci_build.sh > +++ b/scripts/ci_build.sh > @@ -127,6 +127,11 @@ fi > > if [ -n "$NORUN" ]; then > TAGS="$TAGS,-startvm" > +else > + if ! command -v qemu-system-x86_64 > /dev/null; then For now, this check is not changed to testing '/usr/share/doc/qemu-system/ copyright' or something more general. Additionally, it might be good to use "--no-install-recommends" to install less dependencies. For example, under kas docker image: ``` sudo apt-get install qemu-system ... 2 upgraded, 232 newly installed, 0 to remove and 78 not upgraded. Need to get 228 MB of archives. After this operation, 1,084 MB of additional disk space will be used. ``` vs ``` sudo apt-get install --no-install-recommends qemu-system ipxe-qemu ... 0 upgraded, 56 newly installed, 0 to remove and 80 not upgraded. Need to get 92.1 MB of archives. After this operation, 423 MB of additional disk space will be used. ``` Package `ipxe-qemu` is definitely required for network working. But for now I'm not sure if we don't need any more packages here, this is to be checked under Gitlab CI. > + sudo apt-get update -qq > + sudo apt-get install -y qemu-system > + fi > fi > > # Provide working path