From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6605860083084558336 X-Received: by 2002:a1c:ed0f:: with SMTP id l15-v6mr1299280wmh.24.1538048735210; Thu, 27 Sep 2018 04:45:35 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:f2ce:: with SMTP id d14-v6ls2043375wrp.14.gmail; Thu, 27 Sep 2018 04:45:34 -0700 (PDT) X-Google-Smtp-Source: ACcGV60WKrKiKRbQoPfusmULS/o5deI2wbpTxQP1j02SRbkKcWxz9kfqf7a7KiWFz62JikI7Cm2z X-Received: by 2002:adf:ead0:: with SMTP id o16-v6mr1063800wrn.23.1538048734772; Thu, 27 Sep 2018 04:45:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538048734; cv=none; d=google.com; s=arc-20160816; b=S4MrSF60KXR6yGy3ERENJh3Q3346zafvnvJpKiSp1IrO9vYlHh+vmAhD9QPbgk/duT KeN2s7/TssmF2NOXyuoScDNuxSTY/4SRAQwKdHtqRMhgzeF4t7W3WV0tjzj8bXzhb9Oq 9HhAnpAINRvrU1SBLNhWLp6EqzEV65eQrMjjKJ1H5LQDDXnu1vfDukrR1AmBhRNH3N8y qVsT4OSb6WRPFJIQ/0wKF6HNtGEp2AwdrZhbDEo4JR3dLmMG2UWBtm4mZS55F7D2kivO YPrRVBRbqNhViN7Z90rHxKQM92qN65WDwPPQjcx+XMm3G/+4Z2P9smfgsQA0G+QhCzQ/ UAzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:to:subject; bh=cJArcGFwsOa8lN/erS1J+yGBpkHSnYUQu+9fSx/Wkkc=; b=AYhTtn6uAXvnH3r7BBiILg6EzSBowflW9hhJNXg+Xaof8qjuYh7A7bMVZZLVLbEJI3 q8F9FAWn8efUJIO1krpMad2+gHjQzLa0Myc/LxtVWHspy6Oo1kgO3MNc3kigKRZkzBQp yI5DoPR0iuVF2eArRqXi0NU5/eaunqdmYgZHRNd+FtILr8G0wkHdCZXNFnZ8kMK4CUpq XgiTvj7wzmfoFCBoFc/v+jFeSxvb8efzGVA2ke1dBHzDzry9tT39wPjL09gIxDB3Fr6G DduxiGRCHdyWuzQEHT+s15v4pic/t99i5c1aebC4j4UnvFcaohGcoDnQrpXp9JNTWlvu gz+A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id z21-v6si85716wmi.2.2018.09.27.04.45.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Sep 2018 04:45:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.211] (nat-ppp-217.71.235.199-satnet-spb.ru [217.71.235.199] (may be forged)) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w8RBjV00024564 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Thu, 27 Sep 2018 13:45:33 +0200 Subject: Re: [PATCH 2/2] sdk: Check if directories are mounted before unmounting To: Jan Kiszka , isar-users@googlegroups.com References: <20180927111039.16872-1-mosipov@ilbers.de> <20180927111039.16872-3-mosipov@ilbers.de> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <991fc356-7b8e-6748-ccaf-0f3c06d656b2@ilbers.de> Date: Thu, 27 Sep 2018 14:45:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 6TnHgxzng7+f On 9/27/18 2:16 PM, Jan Kiszka wrote: > ...because it generates an error otherwise? > > On 27.09.18 13:10, Maxim Yu. Osipov wrote: >> Signed-off-by: Maxim Yu. Osipov >> --- >> meta/classes/image.bbclass | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass >> index 1db2394..3206877 100644 >> --- a/meta/classes/image.bbclass >> +++ b/meta/classes/image.bbclass >> @@ -98,6 +98,16 @@ addtask copy_boot_files before do_build after do_rootfs >> do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}" >> do_copy_boot_files[stamp-extra-info] = "${DISTRO}-${MACHINE}" >> >> +is_mounted() { >> + dir_dev=`stat -c '%D' "$1"` >> + parent_dev=`stat -c '%D' "$1/.."` >> + if [ $dir_dev != $parent_dev ]; then >> + return 0 >> + else >> + return 1 >> + fi >> +} >> + >> SDKCHROOT_DIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/sdkchroot-${HOST_DISTRO}-${HOST_ARCH}" >> >> do_populate_sdk() { >> @@ -107,8 +117,10 @@ do_populate_sdk() { >> # Purge apt cache to make image slimmer >> sudo rm -rf ${SDKCHROOT_DIR}/rootfs/var/cache/apt/* >> >> + is_mounted ${SDKCHROOT_DIR}/rootfs/dev && sudo umount ${SDKCHROOT_DIR}/rootfs/dev >> + is_mounted ${SDKCHROOT_DIR}/rootfs/proc && sudo umount ${SDKCHROOT_DIR}/rootfs/proc >> + >> # Create SDK archive >> - sudo umount ${SDKCHROOT_DIR}/rootfs/dev ${SDKCHROOT_DIR}/rootfs/proc > > Wouldn't it suffice to append "|| true" then? Yep, that would be more short... Thanks, Maxim. > > Jan > >> sudo tar -C ${SDKCHROOT_DIR} --transform="s|^rootfs|sdk-${DISTRO}-${DISTRO_ARCH}|" \ >> -c rootfs | xz -T0 > ${DEPLOY_DIR_IMAGE}/sdk-${DISTRO}-${DISTRO_ARCH}.tar.xz >> >> > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov