From: Anton Mikanovich <amikan@ilbers.de>
To: Jan Kiszka <jan.kiszka@siemens.com>,
isar-users <isar-users@googlegroups.com>,
"Schmidt, Adriaan" <adriaan.schmidt@siemens.com>,
Baurzhan Ismagulov <ibr@ilbers.de>
Subject: Re: Style question on IMAGER_INSTALL
Date: Fri, 10 Nov 2023 10:38:57 +0200 [thread overview]
Message-ID: <994f0630-ab2c-4331-aa13-37a2ddb3e31b@ilbers.de> (raw)
In-Reply-To: <6a0118aa-a05c-4275-8ca1-ed144234d9e2@siemens.com>
Hello Jan,
In my opinion IMAGER_INSTALL:wic is more preferable because this kind of
syntax
is more generic and can be used with any image type.
Maybe we can even deprecate WIC_IMAGER_INSTALL with some warning output to
remove it in later releases.
10/11/2023 10:03, 'Jan Kiszka' via isar-users wrote:
> Hi all,
>
> since we have sophisticated imagetypes support with per-type chroots, we
> also have more options how to model imager dependencies:
>
> IMAGER_INSTALL += "${GRUB_BOOTLOADER_INSTALL}"
>
> WIC_IMAGER_INSTALL += "${GRUB_BOOTLOADER_INSTALL}"
>
> IMAGER_INSTALL:wic += "${GRUB_BOOTLOADER_INSTALL}"
>
> Which of those should we try to promote today, consistently in code and
> documentation (and our own downstream layers)? Not the first one, I
> would say, as it potentially injects dependencies into image types that
> have no need for it. The second one probably only exists today because
> of historic reason, I suppose. Should we move everything to the third
> style and start to deprecate WIC_IMAGER_INSTALL?
>
> Jan
>
prev parent reply other threads:[~2023-11-10 8:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 8:03 Jan Kiszka
2023-11-10 8:38 ` Anton Mikanovich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=994f0630-ab2c-4331-aa13-37a2ddb3e31b@ilbers.de \
--to=amikan@ilbers.de \
--cc=adriaan.schmidt@siemens.com \
--cc=ibr@ilbers.de \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox