From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7299741097732866048 X-Received: by 2002:a50:d596:0:b0:543:c50c:cacc with SMTP id v22-20020a50d596000000b00543c50ccaccmr6088768edi.41.1699605541624; Fri, 10 Nov 2023 00:39:01 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:aa7:d044:0:b0:53d:beed:e28f with SMTP id n4-20020aa7d044000000b0053dbeede28fls74956edo.1.-pod-prod-02-eu; Fri, 10 Nov 2023 00:39:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiZfyvEYMZ0Wj3IIk/k7UJLUJMmLNkAUgaDJfvMm8S1Vi59l2xKImVbDkWOESvRYo7veCO X-Received: by 2002:a50:d6da:0:b0:53d:bdd2:3d62 with SMTP id l26-20020a50d6da000000b0053dbdd23d62mr6177576edj.30.1699605539740; Fri, 10 Nov 2023 00:38:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699605539; cv=none; d=google.com; s=arc-20160816; b=Me4FAczOtXqgZALNtcRrmC8hc9tc844Q5GxolguHnDAIUGfqV8YhbAATuppWJqyHD6 LYcb0b0yaIEm1O5/sbOSQp55IKjIH05X668AjVNnI5V42IyjToBJlsitWkIQ/wdCNt7D sQg3IiPr1Ux4kDpXPdUBOhXEnRIUF0VTrYrlOlYmVY54X9qpwzCuGMnTkYNuCTWubeZp ZE7Q4sc8XgYWqwjwsFEWUPK0GznUaEUNTjJ5Ltu1axv6X+7wQ+Y5JFDPHLOXDGgXH9Xn B8k2Ub8DBrm6cvNANahE7U0fr7LGt2XdAKVX1iSJQKzcyqeH7AVCZQJX1spmnefxFqZT L+AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id; bh=uJvkAMl+XmEVIkIQXQLYpnJladLKzPJVwccL0DsXbZ0=; fh=1/3WEph8XYSSF0HOjpANLJFzwBuUKG8E0B5st3Y2bMc=; b=xdqsxuwLd9t7oAEzgWObd0F1Kjw0akT3Ri9ZfzP2QuprdGgfLciLzPJqGOjLQEi3yp y5G33Es6yjic/BZ1y+5wEN9E4CVPBXyjAPV51WxXE8R9flqnNkezX4UVMye68234KyO4 1/jlPuqGO0Jern40ZLR41Id1XgZeek8XZ86NzAths6O4oZLIQg+PTx4w6+h49eBE+EGn twrFLfIp05YjckEDn6adfbaxoRHkq+1LIi/lOPDCvf89A8Osg6+yrgGngf1nuGKsDBD/ QE90buortrsT2Nl9vG4lubwPnI8BIL+dLszgQEDjK2dz/+O1jzC7d8oRCfeIyJTCDv+H Q/3Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id n20-20020a05640206d400b0053e90546ff6si1186579edy.1.2023.11.10.00.38.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 Nov 2023 00:38:59 -0800 (PST) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 3AA8cvBh021115 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Nov 2023 09:38:58 +0100 Message-ID: <994f0630-ab2c-4331-aa13-37a2ddb3e31b@ilbers.de> Date: Fri, 10 Nov 2023 10:38:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Style question on IMAGER_INSTALL Content-Language: en-US To: Jan Kiszka , isar-users , "Schmidt, Adriaan" , Baurzhan Ismagulov References: <6a0118aa-a05c-4275-8ca1-ed144234d9e2@siemens.com> From: Anton Mikanovich In-Reply-To: <6a0118aa-a05c-4275-8ca1-ed144234d9e2@siemens.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: Z+1I9uffgM/Y Hello Jan, In my opinion IMAGER_INSTALL:wic is more preferable because this kind of syntax is more generic and can be used with any image type. Maybe we can even deprecate WIC_IMAGER_INSTALL with some warning output to remove it in later releases. 10/11/2023 10:03, 'Jan Kiszka' via isar-users wrote: > Hi all, > > since we have sophisticated imagetypes support with per-type chroots, we > also have more options how to model imager dependencies: > > IMAGER_INSTALL += "${GRUB_BOOTLOADER_INSTALL}" > > WIC_IMAGER_INSTALL += "${GRUB_BOOTLOADER_INSTALL}" > > IMAGER_INSTALL:wic += "${GRUB_BOOTLOADER_INSTALL}" > > Which of those should we try to promote today, consistently in code and > documentation (and our own downstream layers)? Not the first one, I > would say, as it potentially injects dependencies into image types that > have no need for it. The second one probably only exists today because > of historic reason, I suppose. Should we move everything to the third > style and start to deprecate WIC_IMAGER_INSTALL? > > Jan >